All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Linux USB <linux-usb@vger.kernel.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	stable@vger.kernel.org
Subject: usb: dwc3: core: Clean up ULPI device
Date: Tue, 30 Oct 2018 15:39:41 +0200	[thread overview]
Message-ID: <87o9bbeeoy.fsf@linux.intel.com> (raw)

Hi,

Felipe Balbi <felipe.balbi@linux.intel.com> writes:
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> If dwc3_core_init_mode() fails with deferred probe,
> next probe fails on sysfs with
>
> sysfs: cannot create duplicate filename '/devices/pci0000:00/0000:00:11.0/dwc3.0.auto/dwc3.0.auto.ulpi'
>
> To avoid this failure, clean up ULPI device.
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
> ---
>  drivers/usb/dwc3/core.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index 88c80fcc39f5..fec97465ccac 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -1499,6 +1499,7 @@ static int dwc3_probe(struct platform_device *pdev)
>  
>  err5:
>  	dwc3_event_buffers_cleanup(dwc);
> +	dwc3_ulpi_exit(dwc);
>  
>  err4:
>  	dwc3_free_scratch_buffers(dwc);
> -- 
> 2.19.1
>
> ---------------------------------------------------------------------
> Intel Finland Oy
> Registered Address: PL 281, 00181 Helsinki 
> Business Identity Code: 0357606 - 4 
> Domiciled in Helsinki 
>
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.

argh, apologies for this footer. Mail server had changes recently.

WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Linux USB <linux-usb@vger.kernel.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH] usb: dwc3: core: Clean up ULPI device
Date: Tue, 30 Oct 2018 15:39:41 +0200	[thread overview]
Message-ID: <87o9bbeeoy.fsf@linux.intel.com> (raw)
In-Reply-To: <20181030131950.15422-1-felipe.balbi@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 1592 bytes --]


Hi,

Felipe Balbi <felipe.balbi@linux.intel.com> writes:
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> If dwc3_core_init_mode() fails with deferred probe,
> next probe fails on sysfs with
>
> sysfs: cannot create duplicate filename '/devices/pci0000:00/0000:00:11.0/dwc3.0.auto/dwc3.0.auto.ulpi'
>
> To avoid this failure, clean up ULPI device.
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
> ---
>  drivers/usb/dwc3/core.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index 88c80fcc39f5..fec97465ccac 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -1499,6 +1499,7 @@ static int dwc3_probe(struct platform_device *pdev)
>  
>  err5:
>  	dwc3_event_buffers_cleanup(dwc);
> +	dwc3_ulpi_exit(dwc);
>  
>  err4:
>  	dwc3_free_scratch_buffers(dwc);
> -- 
> 2.19.1
>
> ---------------------------------------------------------------------
> Intel Finland Oy
> Registered Address: PL 281, 00181 Helsinki 
> Business Identity Code: 0357606 - 4 
> Domiciled in Helsinki 
>
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.

argh, apologies for this footer. Mail server had changes recently.

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

             reply	other threads:[~2018-10-30 13:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-30 13:39 Felipe Balbi [this message]
2018-10-30 13:39 ` [PATCH] usb: dwc3: core: Clean up ULPI device Felipe Balbi
  -- strict thread matches above, loose matches on Subject: below --
2018-10-30 13:19 Felipe Balbi
2018-10-30 13:19 ` [PATCH] " Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o9bbeeoy.fsf@linux.intel.com \
    --to=felipe.balbi@linux.intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.