From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 03/13] net: mvneta: fix bit assignment in MVNETA_RXQ_CONFIG_REG
Date: Wed, 25 Nov 2015 19:25:02 +0100 [thread overview]
Message-ID: <87oaei7x8h.fsf@free-electrons.com> (raw)
In-Reply-To: <1448178839-3541-4-git-send-email-mw@semihalf.com> (Marcin Wojtas's message of "Sun, 22 Nov 2015 08:53:49 +0100")
Hi Marcin,
On dim., nov. 22 2015, Marcin Wojtas <mw@semihalf.com> wrote:
> MVNETA_RXQ_HW_BUF_ALLOC bit which controls enabling hardware buffer
> allocation was mistakenly set as BIT(1). This commit fixes the
> assignment.
I confirm it from the datasheet I got:
Reviewed-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Thanks,
Gregory
>
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> Cc: <stable@vger.kernel.org> # v3.8+
> ---
> drivers/net/ethernet/marvell/mvneta.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
> index 0f30aaa..d12b8c6 100644
> --- a/drivers/net/ethernet/marvell/mvneta.c
> +++ b/drivers/net/ethernet/marvell/mvneta.c
> @@ -36,7 +36,7 @@
>
> /* Registers */
> #define MVNETA_RXQ_CONFIG_REG(q) (0x1400 + ((q) << 2))
> -#define MVNETA_RXQ_HW_BUF_ALLOC BIT(1)
> +#define MVNETA_RXQ_HW_BUF_ALLOC BIT(0)
> #define MVNETA_RXQ_PKT_OFFSET_ALL_MASK (0xf << 8)
> #define MVNETA_RXQ_PKT_OFFSET_MASK(offs) ((offs) << 8)
> #define MVNETA_RXQ_THRESHOLD_REG(q) (0x14c0 + ((q) << 2))
> --
> 1.8.3.1
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Marcin Wojtas <mw@semihalf.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
davem@davemloft.net, linux@arm.linux.org.uk,
sebastian.hesselbarth@gmail.com, andrew@lunn.ch,
jason@lakedaemon.net, thomas.petazzoni@free-electrons.com,
simon.guinot@sequanux.org, nadavh@marvell.com, alior@marvell.com,
xswang@marvell.com, myair@marvell.com, nitroshift@yahoo.com,
jaz@semihalf.com, tn@semihalf.com, <stable@vger.kernel.org>
Subject: Re: [PATCH 03/13] net: mvneta: fix bit assignment in MVNETA_RXQ_CONFIG_REG
Date: Wed, 25 Nov 2015 19:25:02 +0100 [thread overview]
Message-ID: <87oaei7x8h.fsf@free-electrons.com> (raw)
In-Reply-To: <1448178839-3541-4-git-send-email-mw@semihalf.com> (Marcin Wojtas's message of "Sun, 22 Nov 2015 08:53:49 +0100")
Hi Marcin,
On dim., nov. 22 2015, Marcin Wojtas <mw@semihalf.com> wrote:
> MVNETA_RXQ_HW_BUF_ALLOC bit which controls enabling hardware buffer
> allocation was mistakenly set as BIT(1). This commit fixes the
> assignment.
I confirm it from the datasheet I got:
Reviewed-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Thanks,
Gregory
>
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> Cc: <stable@vger.kernel.org> # v3.8+
> ---
> drivers/net/ethernet/marvell/mvneta.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
> index 0f30aaa..d12b8c6 100644
> --- a/drivers/net/ethernet/marvell/mvneta.c
> +++ b/drivers/net/ethernet/marvell/mvneta.c
> @@ -36,7 +36,7 @@
>
> /* Registers */
> #define MVNETA_RXQ_CONFIG_REG(q) (0x1400 + ((q) << 2))
> -#define MVNETA_RXQ_HW_BUF_ALLOC BIT(1)
> +#define MVNETA_RXQ_HW_BUF_ALLOC BIT(0)
> #define MVNETA_RXQ_PKT_OFFSET_ALL_MASK (0xf << 8)
> #define MVNETA_RXQ_PKT_OFFSET_MASK(offs) ((offs) << 8)
> #define MVNETA_RXQ_THRESHOLD_REG(q) (0x14c0 + ((q) << 2))
> --
> 1.8.3.1
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2015-11-25 18:25 UTC|newest]
Thread overview: 112+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-22 7:53 [PATCH 00/13] mvneta Buffer Management and enhancements Marcin Wojtas
2015-11-22 7:53 ` Marcin Wojtas
2015-11-22 7:53 ` [PATCH 01/13] net: mvneta: add configuration for MBUS windows access protection Marcin Wojtas
2015-11-22 7:53 ` Marcin Wojtas
2015-11-22 7:53 ` Marcin Wojtas
2015-11-25 18:19 ` Gregory CLEMENT
2015-11-25 18:19 ` Gregory CLEMENT
2015-11-22 7:53 ` [PATCH 02/13] net: mvneta: enable IP checksum with jumbo frames for Armada 38x on Port0 Marcin Wojtas
2015-11-22 7:53 ` Marcin Wojtas
2015-11-22 20:00 ` Arnd Bergmann
2015-11-22 20:00 ` Arnd Bergmann
2015-11-22 21:04 ` Marcin Wojtas
2015-11-22 21:04 ` Marcin Wojtas
2015-11-22 21:04 ` Marcin Wojtas
2015-11-22 21:32 ` Arnd Bergmann
2015-11-22 21:32 ` Arnd Bergmann
2015-11-22 21:55 ` Marcin Wojtas
2015-11-22 21:55 ` Marcin Wojtas
2015-11-22 7:53 ` [PATCH 03/13] net: mvneta: fix bit assignment in MVNETA_RXQ_CONFIG_REG Marcin Wojtas
2015-11-22 7:53 ` Marcin Wojtas
2015-11-25 18:25 ` Gregory CLEMENT [this message]
2015-11-25 18:25 ` Gregory CLEMENT
2015-11-22 7:53 ` [PATCH 04/13] net: mvneta: enable suspend/resume support Marcin Wojtas
2015-11-22 7:53 ` Marcin Wojtas
2015-11-22 7:53 ` Marcin Wojtas
2015-11-25 18:35 ` Gregory CLEMENT
2015-11-25 18:35 ` Gregory CLEMENT
2015-11-25 18:35 ` Gregory CLEMENT
2015-11-26 17:39 ` Marcin Wojtas
2015-11-26 17:39 ` Marcin Wojtas
2015-11-22 7:53 ` [PATCH 05/13] net: mvneta: add xmit_more support Marcin Wojtas
2015-11-22 7:53 ` Marcin Wojtas
2015-11-22 7:53 ` [PATCH 06/13] net: mvneta: enable mixed egress processing using HR timer Marcin Wojtas
2015-11-22 7:53 ` Marcin Wojtas
2015-11-26 16:45 ` Simon Guinot
2015-11-26 16:45 ` Simon Guinot
2015-11-30 15:57 ` Marcin Wojtas
2015-11-30 15:57 ` Marcin Wojtas
2015-12-02 10:03 ` Marcin Wojtas
2015-12-02 10:03 ` Marcin Wojtas
2015-11-22 7:53 ` [PATCH 07/13] bus: mvebu-mbus: provide api for obtaining IO and DRAM window information Marcin Wojtas
2015-11-22 7:53 ` Marcin Wojtas
2015-11-22 7:53 ` Marcin Wojtas
2015-11-22 20:02 ` Arnd Bergmann
2015-11-22 20:02 ` Arnd Bergmann
2015-11-22 21:24 ` Marcin Wojtas
2015-11-22 21:24 ` Marcin Wojtas
2015-11-23 16:58 ` Arnd Bergmann
2015-11-23 16:58 ` Arnd Bergmann
2015-11-22 7:53 ` [PATCH 08/13] ARM: mvebu: enable SRAM support in mvebu_v7_defconfig Marcin Wojtas
2015-11-22 7:53 ` Marcin Wojtas
2016-02-16 10:51 ` Gregory CLEMENT
2016-02-16 10:51 ` Gregory CLEMENT
2015-11-22 7:53 ` [PATCH 09/13] net: mvneta: bm: add support for hardware buffer management Marcin Wojtas
2015-11-22 7:53 ` Marcin Wojtas
2015-11-22 7:53 ` [PATCH 10/13] ARM: mvebu: add buffer manager nodes to armada-38x.dtsi Marcin Wojtas
2015-11-22 7:53 ` Marcin Wojtas
2015-11-22 9:41 ` Sergei Shtylyov
2015-11-22 9:41 ` Sergei Shtylyov
2015-11-22 9:41 ` Sergei Shtylyov
2015-11-22 7:53 ` [PATCH 11/13] ARM: mvebu: enable buffer manager support on Armada 38x boards Marcin Wojtas
2015-11-22 7:53 ` Marcin Wojtas
2015-11-22 7:53 ` [PATCH 12/13] ARM: mvebu: add buffer manager nodes to armada-xp.dtsi Marcin Wojtas
2015-11-22 7:53 ` Marcin Wojtas
2015-11-22 7:53 ` [PATCH 13/13] ARM: mvebu: enable buffer manager support on Armada XP boards Marcin Wojtas
2015-11-22 7:53 ` Marcin Wojtas
2015-11-22 20:06 ` [PATCH 00/13] mvneta Buffer Management and enhancements Arnd Bergmann
2015-11-22 20:06 ` Arnd Bergmann
2015-11-22 21:37 ` Marcin Wojtas
2015-11-22 21:37 ` Marcin Wojtas
2015-11-24 16:22 ` David Miller
2015-11-24 16:22 ` David Miller
2015-11-24 16:47 ` Marcin Wojtas
2015-11-24 16:47 ` Marcin Wojtas
2015-11-25 18:34 ` Florian Fainelli
2015-11-25 18:34 ` Florian Fainelli
2015-11-25 18:34 ` Florian Fainelli
2015-11-29 13:21 ` Marcin Wojtas
2015-11-29 13:21 ` Marcin Wojtas
2015-11-30 2:02 ` David Miller
2015-11-30 2:02 ` David Miller
2015-11-30 14:13 ` Marcin Wojtas
2015-11-30 14:13 ` Marcin Wojtas
2015-11-30 16:25 ` David Miller
2015-11-30 16:25 ` David Miller
2015-12-02 8:26 ` Marcin Wojtas
2015-12-02 8:26 ` Marcin Wojtas
2015-12-04 20:15 ` Florian Fainelli
2015-12-04 20:15 ` Florian Fainelli
2015-12-08 10:56 ` Marcin Wojtas
2015-12-08 10:56 ` Marcin Wojtas
2015-12-08 16:57 ` David Miller
2015-12-08 16:57 ` David Miller
2015-11-30 17:16 ` Gregory CLEMENT
2015-11-30 17:16 ` Gregory CLEMENT
2015-11-30 19:53 ` Marcin Wojtas
2015-11-30 19:53 ` Marcin Wojtas
2015-12-01 13:12 ` Gregory CLEMENT
2015-12-01 13:12 ` Gregory CLEMENT
2015-12-01 21:40 ` Marcin Wojtas
2015-12-01 21:40 ` Marcin Wojtas
2015-12-01 23:34 ` Marcin Wojtas
2015-12-01 23:34 ` Marcin Wojtas
2015-12-01 23:34 ` Marcin Wojtas
2015-12-02 10:40 ` Gregory CLEMENT
2015-12-02 10:40 ` Gregory CLEMENT
2015-12-02 16:21 ` Gregory CLEMENT
2015-12-02 16:21 ` Gregory CLEMENT
2015-12-02 22:15 ` Marcin Wojtas
2015-12-02 22:15 ` Marcin Wojtas
2015-12-02 22:56 ` Gregory CLEMENT
2015-12-02 22:56 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oaei7x8h.fsf@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.