From: Jani Nikula <jani.nikula@linux.intel.com>
To: Daniel Vetter <daniel.vetter@intel.com>, David Airlie <airlied@linux.ie>
Cc: Geliang Tang <geliangtang@163.com>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: fix kernel-doc warnings in i915_gem.c
Date: Fri, 18 Sep 2015 14:26:26 +0300 [thread overview]
Message-ID: <87oah0rmsd.fsf@intel.com> (raw)
In-Reply-To: <f29f22d22d0024001d950c0f5082bdccc7894042.1442350597.git.geliangtang@163.com>
On Tue, 15 Sep 2015, Geliang Tang <geliangtang@163.com> wrote:
> Fix the following 'make htmldocs' warnings:
>
> .//drivers/gpu/drm/i915/i915_gem.c:1729: warning: No description found for parameter 'vma'
> .//drivers/gpu/drm/i915/i915_gem.c:1729: warning: No description found for parameter 'vmf'
>
> .//drivers/gpu/drm/i915/i915_gem.c:4962: warning: No description found for parameter 'old'
> .//drivers/gpu/drm/i915/i915_gem.c:4962: warning: No description found for parameter 'new'
> .//drivers/gpu/drm/i915/i915_gem.c:4962: warning: No description found for parameter 'frontbuffer_bits'
>
> Signed-off-by: Geliang Tang <geliangtang@163.com>
Pushed to drm-intel-next-queued, thanks for the patch.
BR,
Jani.
> ---
> drivers/gpu/drm/i915/i915_gem.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index 4d631a9..a96f97c 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -1711,8 +1711,8 @@ i915_gem_mmap_ioctl(struct drm_device *dev, void *data,
>
> /**
> * i915_gem_fault - fault a page into the GTT
> - * vma: VMA in question
> - * vmf: fault info
> + * @vma: VMA in question
> + * @vmf: fault info
> *
> * The fault handler is set up by drm_gem_mmap() when a object is GTT mapped
> * from userspace. The fault handler takes care of binding the object to
> @@ -4949,9 +4949,9 @@ int i915_gem_open(struct drm_device *dev, struct drm_file *file)
>
> /**
> * i915_gem_track_fb - update frontbuffer tracking
> - * old: current GEM buffer for the frontbuffer slots
> - * new: new GEM buffer for the frontbuffer slots
> - * frontbuffer_bits: bitmask of frontbuffer slots
> + * @old: current GEM buffer for the frontbuffer slots
> + * @new: new GEM buffer for the frontbuffer slots
> + * @frontbuffer_bits: bitmask of frontbuffer slots
> *
> * This updates the frontbuffer tracking bits @frontbuffer_bits by clearing them
> * from @old and setting them in @new. Both @old and @new can be NULL.
> --
> 1.9.1
>
>
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Geliang Tang <geliangtang@163.com>,
Daniel Vetter <daniel.vetter@intel.com>,
David Airlie <airlied@linux.ie>
Cc: Geliang Tang <geliangtang@163.com>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/i915: fix kernel-doc warnings in i915_gem.c
Date: Fri, 18 Sep 2015 14:26:26 +0300 [thread overview]
Message-ID: <87oah0rmsd.fsf@intel.com> (raw)
In-Reply-To: <f29f22d22d0024001d950c0f5082bdccc7894042.1442350597.git.geliangtang@163.com>
On Tue, 15 Sep 2015, Geliang Tang <geliangtang@163.com> wrote:
> Fix the following 'make htmldocs' warnings:
>
> .//drivers/gpu/drm/i915/i915_gem.c:1729: warning: No description found for parameter 'vma'
> .//drivers/gpu/drm/i915/i915_gem.c:1729: warning: No description found for parameter 'vmf'
>
> .//drivers/gpu/drm/i915/i915_gem.c:4962: warning: No description found for parameter 'old'
> .//drivers/gpu/drm/i915/i915_gem.c:4962: warning: No description found for parameter 'new'
> .//drivers/gpu/drm/i915/i915_gem.c:4962: warning: No description found for parameter 'frontbuffer_bits'
>
> Signed-off-by: Geliang Tang <geliangtang@163.com>
Pushed to drm-intel-next-queued, thanks for the patch.
BR,
Jani.
> ---
> drivers/gpu/drm/i915/i915_gem.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index 4d631a9..a96f97c 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -1711,8 +1711,8 @@ i915_gem_mmap_ioctl(struct drm_device *dev, void *data,
>
> /**
> * i915_gem_fault - fault a page into the GTT
> - * vma: VMA in question
> - * vmf: fault info
> + * @vma: VMA in question
> + * @vmf: fault info
> *
> * The fault handler is set up by drm_gem_mmap() when a object is GTT mapped
> * from userspace. The fault handler takes care of binding the object to
> @@ -4949,9 +4949,9 @@ int i915_gem_open(struct drm_device *dev, struct drm_file *file)
>
> /**
> * i915_gem_track_fb - update frontbuffer tracking
> - * old: current GEM buffer for the frontbuffer slots
> - * new: new GEM buffer for the frontbuffer slots
> - * frontbuffer_bits: bitmask of frontbuffer slots
> + * @old: current GEM buffer for the frontbuffer slots
> + * @new: new GEM buffer for the frontbuffer slots
> + * @frontbuffer_bits: bitmask of frontbuffer slots
> *
> * This updates the frontbuffer tracking bits @frontbuffer_bits by clearing them
> * from @old and setting them in @new. Both @old and @new can be NULL.
> --
> 1.9.1
>
>
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2015-09-18 11:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 12:58 [PATCH] drm/i915: fix kernel-doc warnings in i915_gem.c Geliang Tang
2015-09-18 11:26 ` Jani Nikula [this message]
2015-09-18 11:26 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oah0rmsd.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@linux.ie \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=geliangtang@163.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.