All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Martin Kepplinger <martink@posteo.de>,
	daniel.vetter@intel.com, airlied@linux.ie
Cc: intel-gfx@lists.freedesktop.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	dri-devel@lists.freedesktop.org
Subject: Re: [BUG] i915: suspend by closing Laptop lid broken
Date: Thu, 07 May 2015 16:50:06 +0300	[thread overview]
Message-ID: <87oalw5wfl.fsf@intel.com> (raw)
In-Reply-To: <554B6A1B.9050201@posteo.de>

On Thu, 07 May 2015, Martin Kepplinger <martink@posteo.de> wrote:
> Am 2015-05-04 um 13:24 schrieb Jani Nikula:
>> On Mon, 04 May 2015, Martin Kepplinger <martink@posteo.de> wrote:
>>> So. -rc1 broke suspending by closing my laptop lid and it's not fixed in
>>> -rc2. It works exactly *one* first time and every subsequent lid-closing
>>> is ignored.
>>>
>>> Biscted and tested first bad commit:
>>> 14aa02449064541217836b9f3d3295e241d5ae9c
>>>
>>> This pulls in i915 changes as well as ACPI changes. I don't know the
>>> driver but I'm sure you can find the mistake. I'm happy to test changes.
>>>
>>> There are no log differences.
>> 
>> Any chance you could bisect into the merge? It would be helpful.
>> 
>> BR,
>> Jani.
>> 
>> 
>
> My attempt to go into the merge was too much effort as the checkouts in
> between break random other stuff.

This should obviously *not* be the case. :(

> We should be between 09d51602cf84a1264946711dd4ea0dddbac599a1 (good) and
> c0f404284192f2d4a0159a714372a8c8610c1f6d. Could you have a look and
> maybe you have guesses for me, what I should test? It's not sooo much
> anymore, maybe you even have a guess about the bug?

$ git log --oneline 09d51602cf..c0f4042841 | grep drm/i915 | wc -l
286

Oof, I eyeballed the list, but didn't spot any obvious candidates.

If a commit is inconclusive or borken in other ways, you could try git
bisect skip to try another commit...

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Martin Kepplinger <martink@posteo.de>,
	daniel.vetter@intel.com, airlied@linux.ie
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [BUG] i915: suspend by closing Laptop lid broken
Date: Thu, 07 May 2015 16:50:06 +0300	[thread overview]
Message-ID: <87oalw5wfl.fsf@intel.com> (raw)
In-Reply-To: <554B6A1B.9050201@posteo.de>

On Thu, 07 May 2015, Martin Kepplinger <martink@posteo.de> wrote:
> Am 2015-05-04 um 13:24 schrieb Jani Nikula:
>> On Mon, 04 May 2015, Martin Kepplinger <martink@posteo.de> wrote:
>>> So. -rc1 broke suspending by closing my laptop lid and it's not fixed in
>>> -rc2. It works exactly *one* first time and every subsequent lid-closing
>>> is ignored.
>>>
>>> Biscted and tested first bad commit:
>>> 14aa02449064541217836b9f3d3295e241d5ae9c
>>>
>>> This pulls in i915 changes as well as ACPI changes. I don't know the
>>> driver but I'm sure you can find the mistake. I'm happy to test changes.
>>>
>>> There are no log differences.
>> 
>> Any chance you could bisect into the merge? It would be helpful.
>> 
>> BR,
>> Jani.
>> 
>> 
>
> My attempt to go into the merge was too much effort as the checkouts in
> between break random other stuff.

This should obviously *not* be the case. :(

> We should be between 09d51602cf84a1264946711dd4ea0dddbac599a1 (good) and
> c0f404284192f2d4a0159a714372a8c8610c1f6d. Could you have a look and
> maybe you have guesses for me, what I should test? It's not sooo much
> anymore, maybe you even have a guess about the bug?

$ git log --oneline 09d51602cf..c0f4042841 | grep drm/i915 | wc -l
286

Oof, I eyeballed the list, but didn't spot any obvious candidates.

If a commit is inconclusive or borken in other ways, you could try git
bisect skip to try another commit...

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center

  reply	other threads:[~2015-05-07 13:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-04 10:54 [BUG] i915: suspend by closing Laptop lid broken Martin Kepplinger
2015-05-04 11:24 ` Jani Nikula
2015-05-04 11:24   ` Jani Nikula
2015-05-07 13:35   ` Martin Kepplinger
2015-05-07 13:35     ` Martin Kepplinger
2015-05-07 13:50     ` Jani Nikula [this message]
2015-05-07 13:50       ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87oalw5wfl.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=airlied@linux.ie \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martink@posteo.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.