All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Ingo Molnar <mingo@kernel.org>, Paulo Zanoni <paulo.r.zanoni@intel.com>
Cc: Ander Conselvan de Oliveira
	<ander.conselvan.de.oliveira@intel.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	intel-gfx@lists.freedesktop.org, x86@kernel.org,
	linux-kernel@vger.kernel.org,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>,
	"H . Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] x86/gpu: GLK uses the same GMS values as SKL
Date: Wed, 25 Jan 2017 13:33:29 +0200	[thread overview]
Message-ID: <87pojb4bna.fsf@intel.com> (raw)
In-Reply-To: <87sho74br5.fsf@intel.com>


(Now without the typo in Daniel's address; apologies for the extra
noise.)

On Wed, 25 Jan 2017, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Wed, 25 Jan 2017, Ingo Molnar <mingo@kernel.org> wrote:
>> * Paulo Zanoni <paulo.r.zanoni@intel.com> wrote:
>>
>>> So don't forget to reserve its stolen memory bits.
>>> 
>>> Cc: Ingo Molnar <mingo@kernel.org>
>>> Cc: H. Peter Anvin <hpa@zytor.com>
>>> Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
>>> Cc: x86@kernel.org
>>> Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
>>> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
>>> ---
>>>  arch/x86/kernel/early-quirks.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>> 
>>> Found by code inspection. This is completely untested since I don't have
>>> GLK hardware.
>>> 
>>> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
>>> index 6a08e25..23c4f1c 100644
>>> --- a/arch/x86/kernel/early-quirks.c
>>> +++ b/arch/x86/kernel/early-quirks.c
>>> @@ -526,6 +526,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
>>>  	INTEL_SKL_IDS(&gen9_early_ops),
>>>  	INTEL_BXT_IDS(&gen9_early_ops),
>>>  	INTEL_KBL_IDS(&gen9_early_ops),
>>> +	INTEL_GLK_IDS(&gen9_early_ops),
>>>  };
>>
>> There's no INTEL_GLK_IDS() upstream - is there any dependency here on other 
>> changes to the i915 GPU driver?
>
> It's in our -next. Ack for merging this through drm-intel along with the
> deps?
>
> BR,
> Jani.
>
>>
>> Thanks,
>>
>> 	Ingo
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Ingo Molnar <mingo@kernel.org>, Paulo Zanoni <paulo.r.zanoni@intel.com>
Cc: Ander Conselvan de Oliveira 
	<ander.conselvan.de.oliveira@intel.com>,
	"H . Peter Anvin" <hpa@zytor.com>,
	intel-gfx@lists.freedesktop.org, x86@kernel.org,
	linux-kernel@vger.kernel.org,
	Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [Intel-gfx] [PATCH] x86/gpu: GLK uses the same GMS values as SKL
Date: Wed, 25 Jan 2017 13:33:29 +0200	[thread overview]
Message-ID: <87pojb4bna.fsf@intel.com> (raw)
In-Reply-To: <87sho74br5.fsf@intel.com>


(Now without the typo in Daniel's address; apologies for the extra
noise.)

On Wed, 25 Jan 2017, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Wed, 25 Jan 2017, Ingo Molnar <mingo@kernel.org> wrote:
>> * Paulo Zanoni <paulo.r.zanoni@intel.com> wrote:
>>
>>> So don't forget to reserve its stolen memory bits.
>>> 
>>> Cc: Ingo Molnar <mingo@kernel.org>
>>> Cc: H. Peter Anvin <hpa@zytor.com>
>>> Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
>>> Cc: x86@kernel.org
>>> Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
>>> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
>>> ---
>>>  arch/x86/kernel/early-quirks.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>> 
>>> Found by code inspection. This is completely untested since I don't have
>>> GLK hardware.
>>> 
>>> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
>>> index 6a08e25..23c4f1c 100644
>>> --- a/arch/x86/kernel/early-quirks.c
>>> +++ b/arch/x86/kernel/early-quirks.c
>>> @@ -526,6 +526,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
>>>  	INTEL_SKL_IDS(&gen9_early_ops),
>>>  	INTEL_BXT_IDS(&gen9_early_ops),
>>>  	INTEL_KBL_IDS(&gen9_early_ops),
>>> +	INTEL_GLK_IDS(&gen9_early_ops),
>>>  };
>>
>> There's no INTEL_GLK_IDS() upstream - is there any dependency here on other 
>> changes to the i915 GPU driver?
>
> It's in our -next. Ack for merging this through drm-intel along with the
> deps?
>
> BR,
> Jani.
>
>>
>> Thanks,
>>
>> 	Ingo
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center

  reply	other threads:[~2017-01-25 11:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-24 18:47 [PATCH] x86/gpu: GLK uses the same GMS values as SKL Paulo Zanoni
2017-01-24 19:53 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-01-25  7:29 ` [PATCH] " Ingo Molnar
2017-01-25 11:31   ` Jani Nikula
2017-01-25 11:31     ` [Intel-gfx] " Jani Nikula
2017-01-25 11:33     ` Jani Nikula [this message]
2017-01-25 11:33       ` Jani Nikula
2017-01-25 11:37       ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pojb4bna.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=ander.conselvan.de.oliveira@intel.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dhinakaran.pandiyan@intel.com \
    --cc=hpa@zytor.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=paulo.r.zanoni@intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.