All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: kernel-janitors@vger.kernel.org, linux-wireless@vger.kernel.org,
	linux-kernel@vger.kernel.org, ath10k@lists.infradead.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH 8/8] ath10k: fix error return code
Date: Tue, 13 Jan 2015 16:16:40 +0200	[thread overview]
Message-ID: <87ppai6a0n.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1419872683-32709-9-git-send-email-Julia.Lawall@lip6.fr> (Julia Lawall's message of "Mon, 29 Dec 2014 18:04:43 +0100")

Julia Lawall <Julia.Lawall@lip6.fr> writes:

> Return a negative error code on failure.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> identifier ret; expression e1,e2;
> @@
> (
> if (\(ret < 0\|ret != 0\))
>  { ... return ret; }
> |
> ret = 0
> )
> ... when != ret = e1
>     when != &ret
> *if(...)
> {
>   ... when != ret = e2
>       when forall
>  return ret;
> }
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Thanks, applied to ath.git.

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: kernel-janitors@vger.kernel.org, linux-wireless@vger.kernel.org,
	linux-kernel@vger.kernel.org, ath10k@lists.infradead.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH 8/8] ath10k: fix error return code
Date: Tue, 13 Jan 2015 14:16:40 +0000	[thread overview]
Message-ID: <87ppai6a0n.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1419872683-32709-9-git-send-email-Julia.Lawall@lip6.fr> (Julia Lawall's message of "Mon, 29 Dec 2014 18:04:43 +0100")

Julia Lawall <Julia.Lawall@lip6.fr> writes:

> Return a negative error code on failure.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> identifier ret; expression e1,e2;
> @@
> (
> if (\(ret < 0\|ret != 0\))
>  { ... return ret; }
> |
> ret = 0
> )
> ... when != ret = e1
>     when != &ret
> *if(...)
> {
>   ... when != ret = e2
>       when forall
>  return ret;
> }
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Thanks, applied to ath.git.

-- 
Kalle Valo

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: <linux-wireless@vger.kernel.org>,
	<kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<ath10k@lists.infradead.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH 8/8] ath10k: fix error return code
Date: Tue, 13 Jan 2015 16:16:40 +0200	[thread overview]
Message-ID: <87ppai6a0n.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1419872683-32709-9-git-send-email-Julia.Lawall@lip6.fr> (Julia Lawall's message of "Mon, 29 Dec 2014 18:04:43 +0100")

Julia Lawall <Julia.Lawall@lip6.fr> writes:

> Return a negative error code on failure.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> identifier ret; expression e1,e2;
> @@
> (
> if (\(ret < 0\|ret != 0\))
>  { ... return ret; }
> |
> ret = 0
> )
> ... when != ret = e1
>     when != &ret
> *if(...)
> {
>   ... when != ret = e2
>       when forall
>  return ret;
> }
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Thanks, applied to ath.git.

-- 
Kalle Valo

  reply	other threads:[~2015-01-13 14:17 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-29 17:04 [PATCH 0/8] fix error return code Julia Lawall
2014-12-29 17:04 ` Julia Lawall
2014-12-29 17:04 ` Julia Lawall
2014-12-29 17:04 ` Julia Lawall
2014-12-29 17:04 ` [PATCH 1/8] net: Xilinx: " Julia Lawall
2014-12-29 17:04   ` Julia Lawall
2014-12-29 17:04   ` Julia Lawall
2015-01-01  0:20   ` David Miller
2015-01-01  0:20     ` David Miller
2015-01-01  0:20     ` David Miller
2014-12-29 17:04 ` [PATCH 2/8] myri10ge: " Julia Lawall
2014-12-29 17:04   ` Julia Lawall
2015-01-01  0:20   ` David Miller
2015-01-01  0:20     ` David Miller
2014-12-29 17:04 ` [PATCH 3/8] soc: ti: knav_qmss_queue: " Julia Lawall
2014-12-29 17:04   ` Julia Lawall
2014-12-29 17:04   ` Julia Lawall
2014-12-29 17:04 ` [PATCH 4/8] drm: " Julia Lawall
2014-12-29 17:04   ` Julia Lawall
2014-12-29 17:04 ` [PATCH 5/8] net: sun4i-emac: " Julia Lawall
2014-12-29 17:04   ` Julia Lawall
2014-12-29 17:04   ` Julia Lawall
2015-01-01  0:20   ` David Miller
2015-01-01  0:20     ` David Miller
2015-01-01  0:20     ` David Miller
2014-12-29 17:04 ` [PATCH 6/8] adm8211: " Julia Lawall
2014-12-29 17:04   ` Julia Lawall
2015-01-15 12:45   ` Kalle Valo
2015-01-15 12:45     ` Kalle Valo
2014-12-29 17:04 ` [PATCH 7/8] net: axienet: " Julia Lawall
2014-12-29 17:04   ` Julia Lawall
2014-12-29 17:04   ` Julia Lawall
2015-01-01  0:19   ` David Miller
2015-01-01  0:19     ` David Miller
2015-01-01  0:19     ` David Miller
2014-12-29 17:04 ` [PATCH 8/8] ath10k: " Julia Lawall
2014-12-29 17:04   ` Julia Lawall
2014-12-29 17:04   ` Julia Lawall
2015-01-13 14:16   ` Kalle Valo [this message]
2015-01-13 14:16     ` Kalle Valo
2015-01-13 14:16     ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ppai6a0n.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=Julia.Lawall@lip6.fr \
    --cc=ath10k@lists.infradead.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.