From: Cornelia Huck <cohuck@redhat.com>
To: Jason Gunthorpe <jgg@nvidia.com>,
Alex Williamson <alex.williamson@redhat.com>,
kvm@vger.kernel.org
Cc: "Christoph Hellwig" <hch@lst.de>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH v4 2/5] vfio/spapr: Move VFIO_CHECK_EXTENSION into tce_iommu_ioctl()
Date: Thu, 01 Dec 2022 12:44:05 +0100 [thread overview]
Message-ID: <87r0xjwdq2.fsf@redhat.com> (raw)
In-Reply-To: <2-v4-7993c351e9dc+33a818-vfio_modules_jgg@nvidia.com>
On Tue, Nov 29 2022, Jason Gunthorpe <jgg@nvidia.com> wrote:
> The PPC64 kconfig is a bit of a rats nest, but it turns out that if
> CONFIG_SPAPR_TCE_IOMMU is on then EEH must be too:
>
> config SPAPR_TCE_IOMMU
> bool "sPAPR TCE IOMMU Support"
> depends on PPC_POWERNV || PPC_PSERIES
> select IOMMU_API
> help
> Enables bits of IOMMU API required by VFIO. The iommu_ops
> is not implemented as it is not necessary for VFIO.
>
> config PPC_POWERNV
> select FORCE_PCI
>
> config PPC_PSERIES
> select FORCE_PCI
>
> config EEH
> bool
> depends on (PPC_POWERNV || PPC_PSERIES) && PCI
> default y
>
> So, just open code the call to eeh_enabled() into tce_iommu_ioctl().
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> ---
> drivers/vfio/vfio_iommu_spapr_tce.c | 10 ++++------
> drivers/vfio/vfio_spapr_eeh.c | 6 ------
> 2 files changed, 4 insertions(+), 12 deletions(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2022-12-01 11:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 0:10 [PATCH v4 0/5] Simplify the module and kconfig structure in vfio Jason Gunthorpe
2022-11-30 0:10 ` [PATCH v4 1/5] vfio/pci: Move all the SPAPR PCI specific logic to vfio_pci_core.ko Jason Gunthorpe
2022-12-01 11:34 ` Cornelia Huck
2022-12-01 23:59 ` Alex Williamson
2022-12-02 0:40 ` Jason Gunthorpe
2022-11-30 0:10 ` [PATCH v4 2/5] vfio/spapr: Move VFIO_CHECK_EXTENSION into tce_iommu_ioctl() Jason Gunthorpe
2022-12-01 11:44 ` Cornelia Huck [this message]
2022-11-30 0:10 ` [PATCH v4 3/5] vfio: Move vfio_spapr_iommu_eeh_ioctl into vfio_iommu_spapr_tce.c Jason Gunthorpe
2022-12-01 11:49 ` Cornelia Huck
2022-11-30 0:10 ` [PATCH v4 4/5] vfio: Remove CONFIG_VFIO_SPAPR_EEH Jason Gunthorpe
2022-11-30 6:05 ` Christoph Hellwig
2022-12-01 11:54 ` Cornelia Huck
2022-11-30 0:10 ` [PATCH v4 5/5] vfio: Fold vfio_virqfd.ko into vfio.ko Jason Gunthorpe
2022-12-01 15:22 ` Cornelia Huck
2022-12-01 15:39 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0xjwdq2.fsf@redhat.com \
--to=cohuck@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=hch@lst.de \
--cc=jgg@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=philmd@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.