All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: "Cornelia Huck" <cohuck@redhat.com>,
	kvm@vger.kernel.org, "Christoph Hellwig" <hch@lst.de>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH v4 1/5] vfio/pci: Move all the SPAPR PCI specific logic to vfio_pci_core.ko
Date: Thu, 1 Dec 2022 20:40:11 -0400	[thread overview]
Message-ID: <Y4lJaw8pr/Q2Sv1S@nvidia.com> (raw)
In-Reply-To: <20221201165908.3a21a1c7.alex.williamson@redhat.com>

On Thu, Dec 01, 2022 at 04:59:08PM -0700, Alex Williamson wrote:
> On Thu, 01 Dec 2022 12:34:33 +0100
> Cornelia Huck <cohuck@redhat.com> wrote:
> 
> > On Tue, Nov 29 2022, Jason Gunthorpe <jgg@nvidia.com> wrote:
> > 
> > > The vfio_spapr_pci_eeh_open/release() functions are one line wrappers
> > > around an arch function. Just call them directly and move them into
> > > vfio_pci_priv.h. This eliminates some weird exported symbols that don't  
> > 
> > Hm, that doesn't seem to match the current patch -- the only change to
> > vfio_pci_priv.h is removing an empty line :)
> 
> s/ and move them into vfio_pci_priv.h//?

Yes, and drop this:

> > >  drivers/vfio/pci/vfio_pci_priv.h |  1 -

It is a rebase error, I didn't notice it.

I made the two notes from Cornelia in my branch, I can send a v5
tomorrow.

Thanks,
Jason

  reply	other threads:[~2022-12-02  0:40 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-30  0:10 [PATCH v4 0/5] Simplify the module and kconfig structure in vfio Jason Gunthorpe
2022-11-30  0:10 ` [PATCH v4 1/5] vfio/pci: Move all the SPAPR PCI specific logic to vfio_pci_core.ko Jason Gunthorpe
2022-12-01 11:34   ` Cornelia Huck
2022-12-01 23:59     ` Alex Williamson
2022-12-02  0:40       ` Jason Gunthorpe [this message]
2022-11-30  0:10 ` [PATCH v4 2/5] vfio/spapr: Move VFIO_CHECK_EXTENSION into tce_iommu_ioctl() Jason Gunthorpe
2022-12-01 11:44   ` Cornelia Huck
2022-11-30  0:10 ` [PATCH v4 3/5] vfio: Move vfio_spapr_iommu_eeh_ioctl into vfio_iommu_spapr_tce.c Jason Gunthorpe
2022-12-01 11:49   ` Cornelia Huck
2022-11-30  0:10 ` [PATCH v4 4/5] vfio: Remove CONFIG_VFIO_SPAPR_EEH Jason Gunthorpe
2022-11-30  6:05   ` Christoph Hellwig
2022-12-01 11:54   ` Cornelia Huck
2022-11-30  0:10 ` [PATCH v4 5/5] vfio: Fold vfio_virqfd.ko into vfio.ko Jason Gunthorpe
2022-12-01 15:22   ` Cornelia Huck
2022-12-01 15:39     ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y4lJaw8pr/Q2Sv1S@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=alex.williamson@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=hch@lst.de \
    --cc=kvm@vger.kernel.org \
    --cc=philmd@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.