All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: "Alex Williamson" <alex.williamson@redhat.com>,
	kvm@vger.kernel.org, "Christoph Hellwig" <hch@lst.de>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH v4 5/5] vfio: Fold vfio_virqfd.ko into vfio.ko
Date: Thu, 1 Dec 2022 11:39:08 -0400	[thread overview]
Message-ID: <Y4jKnBT7ZOkTG9O6@nvidia.com> (raw)
In-Reply-To: <87ilivw3lk.fsf@redhat.com>

On Thu, Dec 01, 2022 at 04:22:47PM +0100, Cornelia Huck wrote:
> On Tue, Nov 29 2022, Jason Gunthorpe <jgg@nvidia.com> wrote:
> 
> > This is only 1.8k, putting it in its own module is not really
> > necessary. The kconfig infrastructure is still there to completely remove
> > it for systems that are trying for small footprint.
> >
> > Put it in the main vfio.ko module now that kbuild can support multiple .c
> > files.
> 
> The biggest difference is that we now always have the vfio-irqfd-cleanup
> wq once the vfio module has been loaded, even if pci or platform have
> not been loaded. I guess that only affects a minority of setups (s390x
> without pci?), and probably doesn't really matter.

Modern wq's are just a little bit of memory, it isn't a big deal

Thanks,
Jason

      reply	other threads:[~2022-12-01 15:40 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-30  0:10 [PATCH v4 0/5] Simplify the module and kconfig structure in vfio Jason Gunthorpe
2022-11-30  0:10 ` [PATCH v4 1/5] vfio/pci: Move all the SPAPR PCI specific logic to vfio_pci_core.ko Jason Gunthorpe
2022-12-01 11:34   ` Cornelia Huck
2022-12-01 23:59     ` Alex Williamson
2022-12-02  0:40       ` Jason Gunthorpe
2022-11-30  0:10 ` [PATCH v4 2/5] vfio/spapr: Move VFIO_CHECK_EXTENSION into tce_iommu_ioctl() Jason Gunthorpe
2022-12-01 11:44   ` Cornelia Huck
2022-11-30  0:10 ` [PATCH v4 3/5] vfio: Move vfio_spapr_iommu_eeh_ioctl into vfio_iommu_spapr_tce.c Jason Gunthorpe
2022-12-01 11:49   ` Cornelia Huck
2022-11-30  0:10 ` [PATCH v4 4/5] vfio: Remove CONFIG_VFIO_SPAPR_EEH Jason Gunthorpe
2022-11-30  6:05   ` Christoph Hellwig
2022-12-01 11:54   ` Cornelia Huck
2022-11-30  0:10 ` [PATCH v4 5/5] vfio: Fold vfio_virqfd.ko into vfio.ko Jason Gunthorpe
2022-12-01 15:22   ` Cornelia Huck
2022-12-01 15:39     ` Jason Gunthorpe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y4jKnBT7ZOkTG9O6@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=alex.williamson@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=hch@lst.de \
    --cc=kvm@vger.kernel.org \
    --cc=philmd@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.