All of lore.kernel.org
 help / color / mirror / Atom feed
From: gregory.clement@bootlin.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 02/17] arm64: dts: marvell: fix CP110 ICU node size
Date: Mon, 30 Apr 2018 14:38:35 +0200	[thread overview]
Message-ID: <87r2mwc1is.fsf@bootlin.com> (raw)
In-Reply-To: <20180421135537.24716-3-miquel.raynal@bootlin.com> (Miquel Raynal's message of "Sat, 21 Apr 2018 15:55:22 +0200")

Hi Miquel,
 
 On sam., avril 21 2018, Miquel Raynal <miquel.raynal@bootlin.com> wrote:

> ICU size in CP110 is not 0x10 but at least 0x440 bytes long (from the
> specification).
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>

This patch looks like a fix, could you resubmit it with the approriate
flags?

Thanks,

Gregory

> ---
>  arch/arm64/boot/dts/marvell/armada-cp110.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-cp110.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
> index 48cad7919efa..9fa41c54f69c 100644
> --- a/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
> @@ -146,7 +146,7 @@
>  
>  		CP110_LABEL(icu): interrupt-controller at 1e0000 {
>  			compatible = "marvell,cp110-icu";
> -			reg = <0x1e0000 0x10>;
> +			reg = <0x1e0000 0x440>;
>  			#interrupt-cells = <3>;
>  			interrupt-controller;
>  			msi-parent = <&gicp>;
> -- 
> 2.14.1
>

-- 
Gregory Clement, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com

WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Mark Rutland <mark.rutland@arm.com>, Andrew Lunn <andrew@lunn.ch>,
	Jason Cooper <jason@lakedaemon.net>,
	devicetree@vger.kernel.org, Marc Zyngier <marc.zyngier@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Hanna Hawa <hannah@marvell.com>, Haim Boot <hayim@marvell.com>,
	Will Deacon <will.deacon@arm.com>,
	Maxime Chevallier <maxime.chevallier@bootlin.com>,
	Nadav Haklai <nadavh@marvell.com>,
	Antoine Tenart <antoine.tenart@bootlin.com>,
	Rob Herring <robh+dt@kernel.org>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-arm-kernel@lists.infradead.org,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH 02/17] arm64: dts: marvell: fix CP110 ICU node size
Date: Mon, 30 Apr 2018 14:38:35 +0200	[thread overview]
Message-ID: <87r2mwc1is.fsf@bootlin.com> (raw)
In-Reply-To: <20180421135537.24716-3-miquel.raynal@bootlin.com> (Miquel Raynal's message of "Sat, 21 Apr 2018 15:55:22 +0200")

Hi Miquel,
 
 On sam., avril 21 2018, Miquel Raynal <miquel.raynal@bootlin.com> wrote:

> ICU size in CP110 is not 0x10 but at least 0x440 bytes long (from the
> specification).
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>

This patch looks like a fix, could you resubmit it with the approriate
flags?

Thanks,

Gregory

> ---
>  arch/arm64/boot/dts/marvell/armada-cp110.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-cp110.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
> index 48cad7919efa..9fa41c54f69c 100644
> --- a/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
> @@ -146,7 +146,7 @@
>  
>  		CP110_LABEL(icu): interrupt-controller@1e0000 {
>  			compatible = "marvell,cp110-icu";
> -			reg = <0x1e0000 0x10>;
> +			reg = <0x1e0000 0x440>;
>  			#interrupt-cells = <3>;
>  			interrupt-controller;
>  			msi-parent = <&gicp>;
> -- 
> 2.14.1
>

-- 
Gregory Clement, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com

  reply	other threads:[~2018-04-30 12:38 UTC|newest]

Thread overview: 92+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-21 13:55 [PATCH 00/17] Add System Error Interrupt support to Armada SoCs Miquel Raynal
2018-04-21 13:55 ` Miquel Raynal
2018-04-21 13:55 ` [PATCH 01/17] dt-bindings/interrupt-controller: fix Marvell ICU length in the example Miquel Raynal
2018-04-21 13:55   ` Miquel Raynal
2018-04-27 20:16   ` Rob Herring
2018-04-27 20:16     ` Rob Herring
2018-04-30 13:44   ` Thomas Petazzoni
2018-04-30 13:44     ` Thomas Petazzoni
2018-04-21 13:55 ` [PATCH 02/17] arm64: dts: marvell: fix CP110 ICU node size Miquel Raynal
2018-04-21 13:55   ` Miquel Raynal
2018-04-30 12:38   ` Gregory CLEMENT [this message]
2018-04-30 12:38     ` Gregory CLEMENT
2018-04-30 13:44   ` Thomas Petazzoni
2018-04-30 13:44     ` Thomas Petazzoni
2018-04-21 13:55 ` [PATCH 03/17] arm64: dts: marvell: add syscon compatible to CP110 ICU node Miquel Raynal
2018-04-21 13:55   ` Miquel Raynal
2018-04-30 13:45   ` Thomas Petazzoni
2018-04-30 13:45     ` Thomas Petazzoni
2018-04-21 13:55 ` [PATCH 04/17] irqchip/irq-mvebu-icu: fix wrong user data retrieval Miquel Raynal
2018-04-21 13:55   ` Miquel Raynal
2018-04-30 13:49   ` Thomas Petazzoni
2018-04-30 13:49     ` Thomas Petazzoni
2018-05-03 14:57     ` Miquel Raynal
2018-05-03 14:57       ` Miquel Raynal
2018-04-21 13:55 ` [PATCH 05/17] irqchip/irq-mvebu-icu: clarify the reset operation of configured interrupts Miquel Raynal
2018-04-21 13:55   ` Miquel Raynal
2018-04-30 13:51   ` Thomas Petazzoni
2018-04-30 13:51     ` Thomas Petazzoni
2018-04-21 13:55 ` [PATCH 06/17] irqchip/irq-mvebu-icu: switch to regmap Miquel Raynal
2018-04-21 13:55   ` Miquel Raynal
2018-04-30 12:42   ` Gregory CLEMENT
2018-04-30 12:42     ` Gregory CLEMENT
2018-04-30 13:53   ` Thomas Petazzoni
2018-04-30 13:53     ` Thomas Petazzoni
2018-05-03 15:05     ` Miquel Raynal
2018-05-03 15:05       ` Miquel Raynal
2018-04-30 13:58   ` Thomas Petazzoni
2018-04-30 13:58     ` Thomas Petazzoni
2018-04-21 13:55 ` [PATCH 07/17] irqchip/irq-mvebu-icu: make irq_domain local Miquel Raynal
2018-04-21 13:55   ` Miquel Raynal
2018-05-02  8:02   ` Thomas Petazzoni
2018-05-02  8:02     ` Thomas Petazzoni
2018-04-21 13:55 ` [PATCH 08/17] irqchip/irq-mvebu-icu: disociate ICU and NSR Miquel Raynal
2018-04-21 13:55   ` Miquel Raynal
2018-05-02  8:03   ` Thomas Petazzoni
2018-05-02  8:03     ` Thomas Petazzoni
2018-04-21 13:55 ` [PATCH 09/17] irqchip/irq-mvebu-icu: support ICU subnodes Miquel Raynal
2018-04-21 13:55   ` Miquel Raynal
2018-05-02  8:13   ` Thomas Petazzoni
2018-05-02  8:13     ` Thomas Petazzoni
2018-05-04  8:32     ` Miquel Raynal
2018-05-04  8:32       ` Miquel Raynal
2018-04-21 13:55 ` [PATCH 10/17] irqchip/irq-mvebu-sei: add new driver for Marvell SEI Miquel Raynal
2018-04-21 13:55   ` Miquel Raynal
2018-05-02  9:17   ` Thomas Petazzoni
2018-05-02  9:17     ` Thomas Petazzoni
2018-05-02 15:56     ` Thomas Petazzoni
2018-05-02 15:56       ` Thomas Petazzoni
2018-05-18 13:22     ` Miquel Raynal
2018-05-18 13:22       ` Miquel Raynal
2018-04-21 13:55 ` [PATCH 11/17] arm64: marvell: enable SEI driver Miquel Raynal
2018-04-21 13:55   ` Miquel Raynal
2018-04-30 13:01   ` Gregory CLEMENT
2018-04-30 13:01     ` Gregory CLEMENT
2018-04-21 13:55 ` [PATCH 12/17] irqchip/irq-mvebu-icu: add support for System Error Interrupts (SEI) Miquel Raynal
2018-04-21 13:55   ` Miquel Raynal
2018-04-21 13:55 ` [PATCH 13/17] dt-bindings/interrupt-controller: update Marvell ICU bindings Miquel Raynal
2018-04-21 13:55   ` Miquel Raynal
2018-04-27 20:47   ` Rob Herring
2018-04-27 20:47     ` Rob Herring
2018-04-28 10:42     ` Miquel Raynal
2018-04-28 10:42       ` Miquel Raynal
2018-04-28 10:50       ` Thomas Petazzoni
2018-04-28 10:50         ` Thomas Petazzoni
2018-04-21 13:55 ` [PATCH 14/17] dt-bindings/interrupt-controller: add description for Marvell SEI node Miquel Raynal
2018-04-21 13:55   ` Miquel Raynal
2018-04-27 20:50   ` Rob Herring
2018-04-27 20:50     ` Rob Herring
2018-04-28 10:48     ` Miquel Raynal
2018-04-28 10:48       ` Miquel Raynal
2018-04-30 14:09       ` Rob Herring
2018-04-30 14:09         ` Rob Herring
2018-05-18 14:48         ` Miquel Raynal
2018-05-18 14:48           ` Miquel Raynal
2018-04-30 14:24   ` Thomas Petazzoni
2018-04-30 14:24     ` Thomas Petazzoni
2018-04-21 13:55 ` [PATCH 15/17] arm64: dts: marvell: add AP806 SEI subnode Miquel Raynal
2018-04-21 13:55   ` Miquel Raynal
2018-04-21 13:55 ` [PATCH 16/17] arm64: dts: marvell: use new bindings for CP110 interrupts Miquel Raynal
2018-04-21 13:55   ` Miquel Raynal
2018-04-21 13:55 ` [PATCH 17/17] arm64: dts: marvell: add CP110 ICU SEI subnode Miquel Raynal
2018-04-21 13:55   ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r2mwc1is.fsf@bootlin.com \
    --to=gregory.clement@bootlin.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.