From: Markus Armbruster <armbru@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>,
qemu-ppc@nongnu.org, david@gibson.dropbear.id.au,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] ppc/mmu-hash64: Remove duplicated #include statement
Date: Thu, 14 Jul 2016 18:32:43 +0200 [thread overview]
Message-ID: <87r3awkwno.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <5787A27B.8020703@redhat.com> (Eric Blake's message of "Thu, 14 Jul 2016 08:32:27 -0600")
Eric Blake <eblake@redhat.com> writes:
> On 07/14/2016 02:14 AM, Thomas Huth wrote:
>> No need to include error-report.h twice here.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>> target-ppc/mmu-hash64.c | 1 -
>> 1 file changed, 1 deletion(-)
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
> Markus, do your header cleanup scripts detect any other situations like
> this?
Not yet.
Here's how I'd eliminate double inclusion. Step 1: make our own headers
includable in any order. Step 2: include them in alphabetical order.
The duplicates become obvious, and get dropped. Step 3: tell the lazy
bums adding includes in the wrong place to mend their ways.
I'm knee-deep in step 1.
prev parent reply other threads:[~2016-07-14 16:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 8:14 [Qemu-devel] [PATCH] ppc/mmu-hash64: Remove duplicated #include statement Thomas Huth
2016-07-14 14:32 ` Eric Blake
2016-07-14 15:11 ` Thomas Huth
2016-07-14 16:32 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r3awkwno.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.