* [PATCH] ALSA: hda/realtek: Fix the push button function for the ALC257
@ 2024-09-30 8:57 Oder Chiou
2024-09-30 9:43 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Oder Chiou @ 2024-09-30 8:57 UTC (permalink / raw)
To: tiwai; +Cc: alsa-devel, kailang, flove, jennifer_chen, geans_chen, Oder Chiou
The patch "Fix noise from speakers on Lenovo IdeaPad 3 15IAU7" caused
that the headset push button cannot work properly in case of ALC257.
This patch reverted it to correct the side effect.
Signed-off-by: Oder Chiou <oder_chiou@realtek.com>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index f787ff4182d4..86db1a4ec24c 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -587,6 +587,7 @@ static void alc_shutup_pins(struct hda_codec *codec)
switch (codec->core.vendor_id) {
case 0x10ec0236:
case 0x10ec0256:
+ case 0x10ec0257:
case 0x19e58326:
case 0x10ec0283:
case 0x10ec0285:
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ALSA: hda/realtek: Fix the push button function for the ALC257
2024-09-30 8:57 [PATCH] ALSA: hda/realtek: Fix the push button function for the ALC257 Oder Chiou
@ 2024-09-30 9:43 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2024-09-30 9:43 UTC (permalink / raw)
To: Oder Chiou; +Cc: alsa-devel, kailang, flove, jennifer_chen, geans_chen
On Mon, 30 Sep 2024 10:57:31 +0200,
Oder Chiou wrote:
>
> The patch "Fix noise from speakers on Lenovo IdeaPad 3 15IAU7" caused
> that the headset push button cannot work properly in case of ALC257.
> This patch reverted it to correct the side effect.
If a previous commit caused such a regression, could you point it,
too? At best in a form of "Fixes:" tag.
thanks,
Takashi
>
> Signed-off-by: Oder Chiou <oder_chiou@realtek.com>
> ---
> sound/pci/hda/patch_realtek.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index f787ff4182d4..86db1a4ec24c 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -587,6 +587,7 @@ static void alc_shutup_pins(struct hda_codec *codec)
> switch (codec->core.vendor_id) {
> case 0x10ec0236:
> case 0x10ec0256:
> + case 0x10ec0257:
> case 0x19e58326:
> case 0x10ec0283:
> case 0x10ec0285:
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-30 9:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-30 8:57 [PATCH] ALSA: hda/realtek: Fix the push button function for the ALC257 Oder Chiou
2024-09-30 9:43 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.