From: Thomas Gleixner <tglx@linutronix.de>
To: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "chenhuacai@kernel.org" <chenhuacai@kernel.org>,
"darwi@linutronix.de" <darwi@linutronix.de>,
"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
"glaubitz@physik.fu-berlin.de" <glaubitz@physik.fu-berlin.de>,
"Torvalds, Linus" <torvalds@linux-foundation.org>,
"chris@zankel.net" <chris@zankel.net>,
"ysato@users.sourceforge.jp" <ysato@users.sourceforge.jp>,
"davem@davemloft.net" <davem@davemloft.net>,
"thomas.lendacky@amd.com" <thomas.lendacky@amd.com>,
"James.Bottomley@HansenPartnership.com"
<James.Bottomley@HansenPartnership.com>,
"mpe@ellerman.id.au" <mpe@ellerman.id.au>,
"kernel@xen0n.name" <kernel@xen0n.name>,
"linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>,
"dalias@libc.org" <dalias@libc.org>,
"loongarch@lists.linux.dev" <loongarch@lists.linux.dev>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"linux-m68k@lists.linux-m68k.org"
<linux-m68k@lists.linux-m68k.org>,
"nik.borisov@suse.com" <nik.borisov@suse.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"anton.ivanov@cambridgegreys.com"
<anton.ivanov@cambridgegreys.com>,
"sparclinux@vger.kernel.org" <sparclinux@vger.kernel.org>,
"richard@nod.at" <richard@nod.at>,
"johannes@sipsolutions.net" <johannes@sipsolutions.net>,
"linux-um@lists.infradead.org" <linux-um@lists.infradead.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"tsbogend@alpha.franken.de" <tsbogend@alpha.franken.de>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
"richard.henderson@linaro.org" <richard.henderson@linaro.org>,
"geert@linux-m68k.org" <geert@linux-m68k.org>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [patch 12/17] init: Invoke arch_cpu_finalize_init() earlier
Date: Fri, 16 Jun 2023 00:03:30 +0200 [thread overview]
Message-ID: <87sfas758t.ffs@tglx> (raw)
In-Reply-To: <b0be67b75d1c3f6b0e98b46a56b8588b9b9e4b2a.camel@intel.com>
On Thu, Jun 15 2023 at 21:44, Rick P. Edgecombe wrote:
> On Wed, 2023-06-14 at 01:39 +0200, Thomas Gleixner wrote:
>> Fortunately none of the init calls between calibrate_delay() and
>> arch_cpu_finalize_init() is relevant for the functionality of
>> arch_cpu_finalize_init().
>>
>
> Reviewed-by: Rick Edgecombe <rick.p.edgecombe@intel.com>
>
> I did my best to find a counterpoint to this statement. The only thing
> I found was that lockdep_init_task(&init_task) in fork_init() is now
> called after the spin_lock() usage in set_memory_4k().
>
> But AFAICT, that whole lockdep_init_task() call is unneeded because
> the fields it sets are already statically initialized.
Correct. The call there looks absolute pointless. Peter?
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de>
To: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "chenhuacai@kernel.org" <chenhuacai@kernel.org>,
"darwi@linutronix.de" <darwi@linutronix.de>,
"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
"glaubitz@physik.fu-berlin.de" <glaubitz@physik.fu-berlin.de>,
"Torvalds, Linus" <torvalds@linux-foundation.org>,
"chris@zankel.net" <chris@zankel.net>,
"ysato@users.sourceforge.jp" <ysato@users.sourceforge.jp>,
"davem@davemloft.net" <davem@davemloft.net>,
"thomas.lendacky@amd.com" <thomas.lendacky@amd.com>,
"James.Bottomley@HansenPartnership.com"
<James.Bottomley@HansenPartnership.com>,
"mpe@ellerman.id.au" <mpe@ellerman.id.au>,
"kernel@xen0n.name" <kernel@xen0n.name>,
"linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>,
"dalias@libc.org" <dalias@libc.org>,
"loongarch@lists.linux.dev" <loongarch@lists.linux.dev>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"linux-m68k@lists.linux-m68k.org"
<linux-m68k@lists.linux-m68k.org>,
"nik.borisov@suse.com" <nik.borisov@suse.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"anton.ivanov@cambridgegreys.com"
<anton.ivanov@cambridgegreys.com>,
"sparclinux@vger.kernel.org" <sparclinux@vger.kernel.org>,
"richard@nod.at" <richard@nod.at>,
"johannes@sipsolutions.net" <johannes@sipsolutions.net>,
"linux-um@lists.infradead.org" <linux-um@lists.infradead.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"tsbogend@alpha.franken.de" <tsbogend@alpha.franken.de>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
"richard.henderson@linaro.org" <richard.henderson@linaro.org>,
"geert@linux-m68k.org" <geert@linux-m68k.org>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [patch 12/17] init: Invoke arch_cpu_finalize_init() earlier
Date: Fri, 16 Jun 2023 00:03:30 +0200 [thread overview]
Message-ID: <87sfas758t.ffs@tglx> (raw)
In-Reply-To: <b0be67b75d1c3f6b0e98b46a56b8588b9b9e4b2a.camel@intel.com>
On Thu, Jun 15 2023 at 21:44, Rick P. Edgecombe wrote:
> On Wed, 2023-06-14 at 01:39 +0200, Thomas Gleixner wrote:
>> Fortunately none of the init calls between calibrate_delay() and
>> arch_cpu_finalize_init() is relevant for the functionality of
>> arch_cpu_finalize_init().
>>
>
> Reviewed-by: Rick Edgecombe <rick.p.edgecombe@intel.com>
>
> I did my best to find a counterpoint to this statement. The only thing
> I found was that lockdep_init_task(&init_task) in fork_init() is now
> called after the spin_lock() usage in set_memory_4k().
>
> But AFAICT, that whole lockdep_init_task() call is unneeded because
> the fields it sets are already statically initialized.
Correct. The call there looks absolute pointless. Peter?
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de>
To: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "chenhuacai@kernel.org" <chenhuacai@kernel.org>,
"darwi@linutronix.de" <darwi@linutronix.de>,
"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
"glaubitz@physik.fu-berlin.de" <glaubitz@physik.fu-berlin.de>,
"Torvalds, Linus" <torvalds@linux-foundation.org>,
"chris@zankel.net" <chris@zankel.net>,
"ysato@users.sourceforge.jp" <ysato@users.sourceforge.jp>,
"davem@davemloft.net" <davem@davemloft.net>,
"thomas.lendacky@amd.com" <thomas.lendacky@amd.com>,
"James.Bottomley@HansenPartnership.com"
<James.Bottomley@HansenPartnership.com>,
"mpe@ellerman.id.au" <mpe@ellerman.id.au>,
"kernel@xen0n.name" <kernel@xen0n.name>,
"linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>,
"dalias@libc.org" <dalias@libc.org>,
"loongarch@lists.linux.dev" <loongarch@lists.linux.dev>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"linux-m68k@lists.linux-m68k.org"
<linux-m68k@lists.linux-m68k.org>,
"nik.borisov@suse.com" <nik.borisov@suse.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"anton.ivanov@cambridgegreys.com"
<anton.ivanov@cambridgegreys.com>,
"sparclinux@vger.kernel.org" <sparclinux@vger.kernel.org>,
"richard@nod.at" <richard@nod.at>,
"johannes@sipsolutions.net" <johannes@sipsolutions.net>,
"linux-um@lists.infradead.org" <linux-um@lists.infradead.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"tsbogend@alpha.franken.de" <tsbogend@alpha.franken.de>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
"richard.henderson@linaro.org" <richard.henderson@linaro.org>,
"geert@linux-m68k.org" <geert@linux-m68k.org>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [patch 12/17] init: Invoke arch_cpu_finalize_init() earlier
Date: Fri, 16 Jun 2023 00:03:30 +0200 [thread overview]
Message-ID: <87sfas758t.ffs@tglx> (raw)
In-Reply-To: <b0be67b75d1c3f6b0e98b46a56b8588b9b9e4b2a.camel@intel.com>
On Thu, Jun 15 2023 at 21:44, Rick P. Edgecombe wrote:
> On Wed, 2023-06-14 at 01:39 +0200, Thomas Gleixner wrote:
>> Fortunately none of the init calls between calibrate_delay() and
>> arch_cpu_finalize_init() is relevant for the functionality of
>> arch_cpu_finalize_init().
>>
>
> Reviewed-by: Rick Edgecombe <rick.p.edgecombe@intel.com>
>
> I did my best to find a counterpoint to this statement. The only thing
> I found was that lockdep_init_task(&init_task) in fork_init() is now
> called after the spin_lock() usage in set_memory_4k().
>
> But AFAICT, that whole lockdep_init_task() call is unneeded because
> the fields it sets are already statically initialized.
Correct. The call there looks absolute pointless. Peter?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-06-15 22:03 UTC|newest]
Thread overview: 152+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 23:39 [patch 00/17] init, treewide, x86: Cleanup check_bugs() and start sanitizing the x86 boot process Thomas Gleixner
2023-06-13 23:39 ` Thomas Gleixner
2023-06-13 23:39 ` Thomas Gleixner
2023-06-13 23:39 ` [patch 01/17] init: Provide arch_cpu_finalize_init() Thomas Gleixner
2023-06-13 23:39 ` Thomas Gleixner
2023-06-13 23:39 ` Thomas Gleixner
2023-06-14 9:28 ` Borislav Petkov
2023-06-14 9:28 ` Borislav Petkov
2023-06-14 9:28 ` Borislav Petkov
2023-06-16 9:24 ` [tip: x86/boot] " tip-bot2 for Thomas Gleixner
2023-06-13 23:39 ` [patch 02/17] x86/cpu: Switch to arch_cpu_finalize_init() Thomas Gleixner
2023-06-13 23:39 ` Thomas Gleixner
2023-06-13 23:39 ` Thomas Gleixner
2023-06-14 9:53 ` Thomas Gleixner
2023-06-14 9:53 ` Thomas Gleixner
2023-06-14 9:53 ` Thomas Gleixner
2023-06-14 10:39 ` Borislav Petkov
2023-06-14 10:39 ` Borislav Petkov
2023-06-14 10:39 ` Borislav Petkov
2023-06-16 9:24 ` [tip: x86/boot] " tip-bot2 for Thomas Gleixner
2023-06-13 23:39 ` [patch 03/17] ARM: cpu: " Thomas Gleixner
2023-06-13 23:39 ` Thomas Gleixner
2023-06-13 23:39 ` Thomas Gleixner
2023-06-16 9:24 ` [tip: x86/boot] " tip-bot2 for Thomas Gleixner
2023-06-25 21:27 ` [patch 03/17] " Philippe Mathieu-Daudé
2023-06-25 21:27 ` Philippe Mathieu-Daudé
2023-06-25 21:27 ` Philippe Mathieu-Daudé
2023-06-13 23:39 ` [patch 04/17] ia64/cpu: " Thomas Gleixner
2023-06-13 23:39 ` Thomas Gleixner
2023-06-13 23:39 ` Thomas Gleixner
2023-06-16 9:24 ` [tip: x86/boot] " tip-bot2 for Thomas Gleixner
2023-06-25 21:24 ` [patch 04/17] " Philippe Mathieu-Daudé
2023-06-25 21:24 ` Philippe Mathieu-Daudé
2023-06-25 21:24 ` Philippe Mathieu-Daudé
2023-06-13 23:39 ` [patch 05/17] loongarch/cpu: " Thomas Gleixner
2023-06-13 23:39 ` Thomas Gleixner
2023-06-13 23:39 ` Thomas Gleixner
2023-06-16 9:24 ` [tip: x86/boot] " tip-bot2 for Thomas Gleixner
2023-06-25 21:24 ` [patch 05/17] " Philippe Mathieu-Daudé
2023-06-25 21:24 ` Philippe Mathieu-Daudé
2023-06-25 21:24 ` Philippe Mathieu-Daudé
2023-06-13 23:39 ` [patch 06/17] m68k/cpu: " Thomas Gleixner
2023-06-13 23:39 ` Thomas Gleixner
2023-06-13 23:39 ` Thomas Gleixner
2023-06-14 9:22 ` Geert Uytterhoeven
2023-06-14 9:22 ` Geert Uytterhoeven
2023-06-14 9:22 ` Geert Uytterhoeven
2023-06-16 9:24 ` [tip: x86/boot] " tip-bot2 for Thomas Gleixner
2023-06-13 23:39 ` [patch 07/17] mips/cpu: " Thomas Gleixner
2023-06-13 23:39 ` Thomas Gleixner
2023-06-13 23:39 ` Thomas Gleixner
2023-06-16 9:24 ` [tip: x86/boot] " tip-bot2 for Thomas Gleixner
2023-06-25 21:25 ` [patch 07/17] " Philippe Mathieu-Daudé
2023-06-25 21:25 ` Philippe Mathieu-Daudé
2023-06-25 21:25 ` Philippe Mathieu-Daudé
2023-06-13 23:39 ` [patch 08/17] sh/cpu: " Thomas Gleixner
2023-06-13 23:39 ` Thomas Gleixner
2023-06-13 23:39 ` Thomas Gleixner
2023-06-16 9:24 ` [tip: x86/boot] " tip-bot2 for Thomas Gleixner
2023-06-25 21:29 ` [patch 08/17] " Philippe Mathieu-Daudé
2023-06-25 21:29 ` Philippe Mathieu-Daudé
2023-06-25 21:29 ` Philippe Mathieu-Daudé
2023-06-25 21:45 ` John Paul Adrian Glaubitz
2023-06-25 21:45 ` John Paul Adrian Glaubitz
2023-06-25 21:45 ` John Paul Adrian Glaubitz
2023-06-13 23:39 ` [patch 09/17] sparc/cpu: " Thomas Gleixner
2023-06-13 23:39 ` Thomas Gleixner
2023-06-13 23:39 ` Thomas Gleixner
2023-06-14 20:41 ` Sam Ravnborg
2023-06-14 20:41 ` Sam Ravnborg
2023-06-14 20:41 ` Sam Ravnborg
2023-06-16 9:24 ` [tip: x86/boot] " tip-bot2 for Thomas Gleixner
2023-06-25 21:30 ` [patch 09/17] " Philippe Mathieu-Daudé
2023-06-25 21:30 ` Philippe Mathieu-Daudé
2023-06-25 21:30 ` Philippe Mathieu-Daudé
2023-06-13 23:39 ` [patch 10/17] um/cpu: " Thomas Gleixner
2023-06-13 23:39 ` Thomas Gleixner
2023-06-13 23:39 ` Thomas Gleixner
2023-06-14 6:51 ` Richard Weinberger
2023-06-14 6:51 ` Richard Weinberger
2023-06-14 6:51 ` Richard Weinberger
2023-06-16 9:24 ` [tip: x86/boot] " tip-bot2 for Thomas Gleixner
2023-06-25 21:28 ` [patch 10/17] " Philippe Mathieu-Daudé
2023-06-25 21:28 ` Philippe Mathieu-Daudé
2023-06-25 21:28 ` Philippe Mathieu-Daudé
2023-06-13 23:39 ` [patch 11/17] init: Remove check_bugs() leftovers Thomas Gleixner
2023-06-13 23:39 ` Thomas Gleixner
2023-06-13 23:39 ` Thomas Gleixner
2023-06-14 6:14 ` Richard Henderson
2023-06-14 6:14 ` Richard Henderson
2023-06-14 6:14 ` Richard Henderson
2023-06-16 9:24 ` [tip: x86/boot] " tip-bot2 for Thomas Gleixner
2023-06-25 21:31 ` [patch 11/17] " Philippe Mathieu-Daudé
2023-06-25 21:31 ` Philippe Mathieu-Daudé
2023-06-25 21:31 ` Philippe Mathieu-Daudé
2023-06-13 23:39 ` [patch 12/17] init: Invoke arch_cpu_finalize_init() earlier Thomas Gleixner
2023-06-13 23:39 ` Thomas Gleixner
2023-06-13 23:39 ` Thomas Gleixner
2023-06-15 21:44 ` Edgecombe, Rick P
2023-06-15 21:44 ` Edgecombe, Rick P
2023-06-15 21:44 ` Edgecombe, Rick P
2023-06-15 22:03 ` Thomas Gleixner [this message]
2023-06-15 22:03 ` Thomas Gleixner
2023-06-15 22:03 ` Thomas Gleixner
2023-06-16 9:24 ` [tip: x86/boot] " tip-bot2 for Thomas Gleixner
2023-06-13 23:39 ` [patch 13/17] init, x86: Move mem_encrypt_init() into arch_cpu_finalize_init() Thomas Gleixner
2023-06-13 23:39 ` Thomas Gleixner
2023-06-13 23:39 ` Thomas Gleixner
2023-06-16 9:24 ` [tip: x86/boot] " tip-bot2 for Thomas Gleixner
2023-06-21 17:12 ` [patch 13/17] " Tom Lendacky
2023-06-21 17:12 ` Tom Lendacky
2023-06-21 17:12 ` Tom Lendacky
2023-06-13 23:39 ` [patch 14/17] x86/init: Initialize signal frame size late Thomas Gleixner
2023-06-13 23:39 ` Thomas Gleixner
2023-06-13 23:39 ` Thomas Gleixner
2023-06-16 9:24 ` [tip: x86/boot] " tip-bot2 for Thomas Gleixner
2023-06-13 23:39 ` [patch 15/17] x86/fpu: Remove cpuinfo argument from init functions Thomas Gleixner
2023-06-13 23:39 ` Thomas Gleixner
2023-06-13 23:39 ` Thomas Gleixner
2023-06-16 9:24 ` [tip: x86/boot] " tip-bot2 for Thomas Gleixner
2023-06-13 23:39 ` [patch 16/17] x86/fpu: Mark init functions __init Thomas Gleixner
2023-06-13 23:39 ` Thomas Gleixner
2023-06-13 23:39 ` Thomas Gleixner
2023-06-16 9:24 ` [tip: x86/boot] " tip-bot2 for Thomas Gleixner
2023-06-13 23:39 ` [patch 17/17] x86/fpu: Move FPU initialization into arch_cpu_finalize_init() Thomas Gleixner
2023-06-13 23:39 ` Thomas Gleixner
2023-06-13 23:39 ` Thomas Gleixner
2023-06-14 5:03 ` Chang S. Bae
2023-06-14 5:03 ` Chang S. Bae
2023-06-14 5:03 ` Chang S. Bae
2023-06-14 9:52 ` Thomas Gleixner
2023-06-14 9:52 ` Thomas Gleixner
2023-06-14 9:52 ` Thomas Gleixner
2023-06-16 9:24 ` [tip: x86/boot] " tip-bot2 for Thomas Gleixner
2023-09-01 17:30 ` [patch 17/17] " Guenter Roeck
2023-09-01 17:30 ` Guenter Roeck
2023-09-01 17:30 ` Guenter Roeck
2023-09-01 18:00 ` Nikolay Borisov
2023-09-01 18:00 ` Nikolay Borisov
2023-09-01 18:00 ` Nikolay Borisov
2023-09-01 18:21 ` Guenter Roeck
2023-09-01 18:21 ` Guenter Roeck
2023-09-01 18:21 ` Guenter Roeck
2023-09-01 18:02 ` Nikolay Borisov
2023-09-01 18:02 ` Nikolay Borisov
2023-09-01 18:02 ` Nikolay Borisov
2023-09-01 21:09 ` Guenter Roeck
2023-09-01 21:09 ` Guenter Roeck
2023-09-01 21:09 ` Guenter Roeck
2023-06-28 3:38 ` [patch 00/17] init, treewide, x86: Cleanup check_bugs() and start sanitizing the x86 boot process Jan Engelhardt
2023-06-28 3:38 ` Jan Engelhardt
2023-06-28 3:38 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfas758t.ffs@tglx \
--to=tglx@linutronix.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=arnd@arndb.de \
--cc=chenhuacai@kernel.org \
--cc=chris@zankel.net \
--cc=dalias@libc.org \
--cc=darwi@linutronix.de \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=johannes@sipsolutions.net \
--cc=kernel@xen0n.name \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=loongarch@lists.linux.dev \
--cc=mpe@ellerman.id.au \
--cc=nik.borisov@suse.com \
--cc=richard.henderson@linaro.org \
--cc=richard@nod.at \
--cc=rick.p.edgecombe@intel.com \
--cc=sparclinux@vger.kernel.org \
--cc=thomas.lendacky@amd.com \
--cc=torvalds@linux-foundation.org \
--cc=tsbogend@alpha.franken.de \
--cc=x86@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.