* [PATCH] powerpc/prom_init: Include the termination message in ibm,os-term RTAS call
@ 2020-03-24 20:12 ` Fabiano Rosas
0 siblings, 0 replies; 10+ messages in thread
From: Fabiano Rosas @ 2020-03-24 20:12 UTC (permalink / raw)
To: linuxppc-dev; +Cc: linuxram, paulus, kvm-ppc
QEMU can now print the ibm,os-term message[1], so let's include it in
the RTAS call. E.g.:
qemu-system-ppc64: OS terminated: Switch to secure mode failed.
1- https://git.qemu.org/?p=qemu.git;a=commitdiff;h¤c3791ae0
Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com>
---
arch/powerpc/kernel/prom_init.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
index 577345382b23..d543fb6d29c5 100644
--- a/arch/powerpc/kernel/prom_init.c
+++ b/arch/powerpc/kernel/prom_init.c
@@ -1773,6 +1773,9 @@ static void __init prom_rtas_os_term(char *str)
if (token = 0)
prom_panic("Could not get token for ibm,os-term\n");
os_term_args.token = cpu_to_be32(token);
+ os_term_args.nargs = cpu_to_be32(1);
+ os_term_args.args[0] = cpu_to_be32(__pa(str));
+
prom_rtas_hcall((uint64_t)&os_term_args);
}
#endif /* CONFIG_PPC_SVM */
--
2.23.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH] powerpc/prom_init: Include the termination message in ibm, os-term RTAS call
@ 2020-03-24 20:12 ` Fabiano Rosas
0 siblings, 0 replies; 10+ messages in thread
From: Fabiano Rosas @ 2020-03-24 20:12 UTC (permalink / raw)
To: linuxppc-dev; +Cc: linuxram, paulus, kvm-ppc
QEMU can now print the ibm,os-term message[1], so let's include it in
the RTAS call. E.g.:
qemu-system-ppc64: OS terminated: Switch to secure mode failed.
1- https://git.qemu.org/?p=qemu.git;a=commitdiff;h=a4c3791ae0
Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com>
---
arch/powerpc/kernel/prom_init.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
index 577345382b23..d543fb6d29c5 100644
--- a/arch/powerpc/kernel/prom_init.c
+++ b/arch/powerpc/kernel/prom_init.c
@@ -1773,6 +1773,9 @@ static void __init prom_rtas_os_term(char *str)
if (token == 0)
prom_panic("Could not get token for ibm,os-term\n");
os_term_args.token = cpu_to_be32(token);
+ os_term_args.nargs = cpu_to_be32(1);
+ os_term_args.args[0] = cpu_to_be32(__pa(str));
+
prom_rtas_hcall((uint64_t)&os_term_args);
}
#endif /* CONFIG_PPC_SVM */
--
2.23.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] powerpc/prom_init: Include the termination message in ibm,os-term RTAS call
2020-03-24 20:12 ` [PATCH] powerpc/prom_init: Include the termination message in ibm, os-term " Fabiano Rosas
@ 2020-03-25 10:06 ` Michael Ellerman
-1 siblings, 0 replies; 10+ messages in thread
From: Michael Ellerman @ 2020-03-25 10:06 UTC (permalink / raw)
To: Fabiano Rosas, linuxppc-dev; +Cc: linuxram, paulus, kvm-ppc
Fabiano Rosas <farosas@linux.ibm.com> writes:
> QEMU can now print the ibm,os-term message[1], so let's include it in
> the RTAS call. E.g.:
>
> qemu-system-ppc64: OS terminated: Switch to secure mode failed.
>
> 1- https://git.qemu.org/?p=qemu.git;a=commitdiff;h¤c3791ae0
>
> Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com>
> ---
> arch/powerpc/kernel/prom_init.c | 3 +++
> 1 file changed, 3 insertions(+)
I have this queued:
https://patchwork.ozlabs.org/patch/1253390/
Which I think does the same thing?
cheers
> diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
> index 577345382b23..d543fb6d29c5 100644
> --- a/arch/powerpc/kernel/prom_init.c
> +++ b/arch/powerpc/kernel/prom_init.c
> @@ -1773,6 +1773,9 @@ static void __init prom_rtas_os_term(char *str)
> if (token = 0)
> prom_panic("Could not get token for ibm,os-term\n");
> os_term_args.token = cpu_to_be32(token);
> + os_term_args.nargs = cpu_to_be32(1);
> + os_term_args.args[0] = cpu_to_be32(__pa(str));
> +
> prom_rtas_hcall((uint64_t)&os_term_args);
> }
> #endif /* CONFIG_PPC_SVM */
> --
> 2.23.0
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] powerpc/prom_init: Include the termination message in ibm, os-term RTAS call
@ 2020-03-25 10:06 ` Michael Ellerman
0 siblings, 0 replies; 10+ messages in thread
From: Michael Ellerman @ 2020-03-25 10:06 UTC (permalink / raw)
To: Fabiano Rosas, linuxppc-dev; +Cc: linuxram, paulus, kvm-ppc
Fabiano Rosas <farosas@linux.ibm.com> writes:
> QEMU can now print the ibm,os-term message[1], so let's include it in
> the RTAS call. E.g.:
>
> qemu-system-ppc64: OS terminated: Switch to secure mode failed.
>
> 1- https://git.qemu.org/?p=qemu.git;a=commitdiff;h=a4c3791ae0
>
> Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com>
> ---
> arch/powerpc/kernel/prom_init.c | 3 +++
> 1 file changed, 3 insertions(+)
I have this queued:
https://patchwork.ozlabs.org/patch/1253390/
Which I think does the same thing?
cheers
> diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
> index 577345382b23..d543fb6d29c5 100644
> --- a/arch/powerpc/kernel/prom_init.c
> +++ b/arch/powerpc/kernel/prom_init.c
> @@ -1773,6 +1773,9 @@ static void __init prom_rtas_os_term(char *str)
> if (token == 0)
> prom_panic("Could not get token for ibm,os-term\n");
> os_term_args.token = cpu_to_be32(token);
> + os_term_args.nargs = cpu_to_be32(1);
> + os_term_args.args[0] = cpu_to_be32(__pa(str));
> +
> prom_rtas_hcall((uint64_t)&os_term_args);
> }
> #endif /* CONFIG_PPC_SVM */
> --
> 2.23.0
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] powerpc/prom_init: Include the termination message in ibm,os-term RTAS call
2020-03-25 10:06 ` [PATCH] powerpc/prom_init: Include the termination message in ibm, os-term " Michael Ellerman
@ 2020-03-25 10:34 ` Greg Kurz
-1 siblings, 0 replies; 10+ messages in thread
From: Greg Kurz @ 2020-03-25 10:34 UTC (permalink / raw)
To: Michael Ellerman; +Cc: linuxram, paulus, linuxppc-dev, kvm-ppc, Fabiano Rosas
On Wed, 25 Mar 2020 21:06:22 +1100
Michael Ellerman <mpe@ellerman.id.au> wrote:
> Fabiano Rosas <farosas@linux.ibm.com> writes:
>
> > QEMU can now print the ibm,os-term message[1], so let's include it in
> > the RTAS call. E.g.:
> >
> > qemu-system-ppc64: OS terminated: Switch to secure mode failed.
> >
> > 1- https://git.qemu.org/?p=qemu.git;a=commitdiff;h¤c3791ae0
> >
> > Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com>
> > ---
> > arch/powerpc/kernel/prom_init.c | 3 +++
> > 1 file changed, 3 insertions(+)
>
> I have this queued:
> https://patchwork.ozlabs.org/patch/1253390/
>
> Which I think does the same thing?
>
Alexey's patch also sets os_term_args.nret as indicated in PAPR.
Even if QEMU's handler for "ibm,os-term" doesn't seem to have
a use for nret, I think it's better to stick to the spec.
Cheers,
--
Greg
> cheers
>
> > diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
> > index 577345382b23..d543fb6d29c5 100644
> > --- a/arch/powerpc/kernel/prom_init.c
> > +++ b/arch/powerpc/kernel/prom_init.c
> > @@ -1773,6 +1773,9 @@ static void __init prom_rtas_os_term(char *str)
> > if (token = 0)
> > prom_panic("Could not get token for ibm,os-term\n");
> > os_term_args.token = cpu_to_be32(token);
> > + os_term_args.nargs = cpu_to_be32(1);
> > + os_term_args.args[0] = cpu_to_be32(__pa(str));
> > +
> > prom_rtas_hcall((uint64_t)&os_term_args);
> > }
> > #endif /* CONFIG_PPC_SVM */
> > --
> > 2.23.0
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] powerpc/prom_init: Include the termination message in ibm,os-term RTAS call
@ 2020-03-25 10:34 ` Greg Kurz
0 siblings, 0 replies; 10+ messages in thread
From: Greg Kurz @ 2020-03-25 10:34 UTC (permalink / raw)
To: Michael Ellerman; +Cc: linuxram, paulus, linuxppc-dev, kvm-ppc, Fabiano Rosas
On Wed, 25 Mar 2020 21:06:22 +1100
Michael Ellerman <mpe@ellerman.id.au> wrote:
> Fabiano Rosas <farosas@linux.ibm.com> writes:
>
> > QEMU can now print the ibm,os-term message[1], so let's include it in
> > the RTAS call. E.g.:
> >
> > qemu-system-ppc64: OS terminated: Switch to secure mode failed.
> >
> > 1- https://git.qemu.org/?p=qemu.git;a=commitdiff;h=a4c3791ae0
> >
> > Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com>
> > ---
> > arch/powerpc/kernel/prom_init.c | 3 +++
> > 1 file changed, 3 insertions(+)
>
> I have this queued:
> https://patchwork.ozlabs.org/patch/1253390/
>
> Which I think does the same thing?
>
Alexey's patch also sets os_term_args.nret as indicated in PAPR.
Even if QEMU's handler for "ibm,os-term" doesn't seem to have
a use for nret, I think it's better to stick to the spec.
Cheers,
--
Greg
> cheers
>
> > diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
> > index 577345382b23..d543fb6d29c5 100644
> > --- a/arch/powerpc/kernel/prom_init.c
> > +++ b/arch/powerpc/kernel/prom_init.c
> > @@ -1773,6 +1773,9 @@ static void __init prom_rtas_os_term(char *str)
> > if (token == 0)
> > prom_panic("Could not get token for ibm,os-term\n");
> > os_term_args.token = cpu_to_be32(token);
> > + os_term_args.nargs = cpu_to_be32(1);
> > + os_term_args.args[0] = cpu_to_be32(__pa(str));
> > +
> > prom_rtas_hcall((uint64_t)&os_term_args);
> > }
> > #endif /* CONFIG_PPC_SVM */
> > --
> > 2.23.0
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc/prom_init: Include the termination message in ibm,os-term RTAS call
2020-03-25 10:06 ` [PATCH] powerpc/prom_init: Include the termination message in ibm, os-term " Michael Ellerman
@ 2020-03-25 13:24 ` Fabiano Rosas
-1 siblings, 0 replies; 10+ messages in thread
From: Fabiano Rosas @ 2020-03-25 13:24 UTC (permalink / raw)
To: Michael Ellerman, linuxppc-dev; +Cc: linuxram, paulus, kvm-ppc
Michael Ellerman <mpe@ellerman.id.au> writes:
> Fabiano Rosas <farosas@linux.ibm.com> writes:
>
>> QEMU can now print the ibm,os-term message[1], so let's include it in
>> the RTAS call. E.g.:
>>
>> qemu-system-ppc64: OS terminated: Switch to secure mode failed.
>>
>> 1- https://git.qemu.org/?p=qemu.git;a=commitdiff;h¤c3791ae0
>>
>> Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com>
>> ---
>> arch/powerpc/kernel/prom_init.c | 3 +++
>> 1 file changed, 3 insertions(+)
>
> I have this queued:
> https://patchwork.ozlabs.org/patch/1253390/
>
> Which I think does the same thing?
>
Ah, all good then. Nothing to see here... =)
> cheers
>
>> diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
>> index 577345382b23..d543fb6d29c5 100644
>> --- a/arch/powerpc/kernel/prom_init.c
>> +++ b/arch/powerpc/kernel/prom_init.c
>> @@ -1773,6 +1773,9 @@ static void __init prom_rtas_os_term(char *str)
>> if (token = 0)
>> prom_panic("Could not get token for ibm,os-term\n");
>> os_term_args.token = cpu_to_be32(token);
>> + os_term_args.nargs = cpu_to_be32(1);
>> + os_term_args.args[0] = cpu_to_be32(__pa(str));
>> +
>> prom_rtas_hcall((uint64_t)&os_term_args);
>> }
>> #endif /* CONFIG_PPC_SVM */
>> --
>> 2.23.0
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] powerpc/prom_init: Include the termination message in ibm, os-term RTAS call
@ 2020-03-25 13:24 ` Fabiano Rosas
0 siblings, 0 replies; 10+ messages in thread
From: Fabiano Rosas @ 2020-03-25 13:24 UTC (permalink / raw)
To: Michael Ellerman, linuxppc-dev; +Cc: linuxram, paulus, kvm-ppc
Michael Ellerman <mpe@ellerman.id.au> writes:
> Fabiano Rosas <farosas@linux.ibm.com> writes:
>
>> QEMU can now print the ibm,os-term message[1], so let's include it in
>> the RTAS call. E.g.:
>>
>> qemu-system-ppc64: OS terminated: Switch to secure mode failed.
>>
>> 1- https://git.qemu.org/?p=qemu.git;a=commitdiff;h=a4c3791ae0
>>
>> Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com>
>> ---
>> arch/powerpc/kernel/prom_init.c | 3 +++
>> 1 file changed, 3 insertions(+)
>
> I have this queued:
> https://patchwork.ozlabs.org/patch/1253390/
>
> Which I think does the same thing?
>
Ah, all good then. Nothing to see here... =)
> cheers
>
>> diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
>> index 577345382b23..d543fb6d29c5 100644
>> --- a/arch/powerpc/kernel/prom_init.c
>> +++ b/arch/powerpc/kernel/prom_init.c
>> @@ -1773,6 +1773,9 @@ static void __init prom_rtas_os_term(char *str)
>> if (token == 0)
>> prom_panic("Could not get token for ibm,os-term\n");
>> os_term_args.token = cpu_to_be32(token);
>> + os_term_args.nargs = cpu_to_be32(1);
>> + os_term_args.args[0] = cpu_to_be32(__pa(str));
>> +
>> prom_rtas_hcall((uint64_t)&os_term_args);
>> }
>> #endif /* CONFIG_PPC_SVM */
>> --
>> 2.23.0
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc/prom_init: Include the termination message in ibm,os-term RTAS call
2020-03-24 20:12 ` [PATCH] powerpc/prom_init: Include the termination message in ibm, os-term " Fabiano Rosas
@ 2020-03-25 13:24 ` Ram Pai
-1 siblings, 0 replies; 10+ messages in thread
From: Ram Pai @ 2020-03-25 13:24 UTC (permalink / raw)
To: Fabiano Rosas; +Cc: paulus, linuxppc-dev, kvm-ppc
On Tue, Mar 24, 2020 at 05:12:11PM -0300, Fabiano Rosas wrote:
> QEMU can now print the ibm,os-term message[1], so let's include it in
> the RTAS call. E.g.:
>
> qemu-system-ppc64: OS terminated: Switch to secure mode failed.
>
> 1- https://git.qemu.org/?p=qemu.git;a=commitdiff;h¤c3791ae0
>
> Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com>
> ---
> arch/powerpc/kernel/prom_init.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
> index 577345382b23..d543fb6d29c5 100644
> --- a/arch/powerpc/kernel/prom_init.c
> +++ b/arch/powerpc/kernel/prom_init.c
> @@ -1773,6 +1773,9 @@ static void __init prom_rtas_os_term(char *str)
> if (token = 0)
> prom_panic("Could not get token for ibm,os-term\n");
> os_term_args.token = cpu_to_be32(token);
> + os_term_args.nargs = cpu_to_be32(1);
> + os_term_args.args[0] = cpu_to_be32(__pa(str));
> +
Reviewed-by: Ram Pai <linuxram@us.ibm.com>
RP
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] powerpc/prom_init: Include the termination message in ibm,os-term RTAS call
@ 2020-03-25 13:24 ` Ram Pai
0 siblings, 0 replies; 10+ messages in thread
From: Ram Pai @ 2020-03-25 13:24 UTC (permalink / raw)
To: Fabiano Rosas; +Cc: paulus, linuxppc-dev, kvm-ppc
On Tue, Mar 24, 2020 at 05:12:11PM -0300, Fabiano Rosas wrote:
> QEMU can now print the ibm,os-term message[1], so let's include it in
> the RTAS call. E.g.:
>
> qemu-system-ppc64: OS terminated: Switch to secure mode failed.
>
> 1- https://git.qemu.org/?p=qemu.git;a=commitdiff;h=a4c3791ae0
>
> Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com>
> ---
> arch/powerpc/kernel/prom_init.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
> index 577345382b23..d543fb6d29c5 100644
> --- a/arch/powerpc/kernel/prom_init.c
> +++ b/arch/powerpc/kernel/prom_init.c
> @@ -1773,6 +1773,9 @@ static void __init prom_rtas_os_term(char *str)
> if (token == 0)
> prom_panic("Could not get token for ibm,os-term\n");
> os_term_args.token = cpu_to_be32(token);
> + os_term_args.nargs = cpu_to_be32(1);
> + os_term_args.args[0] = cpu_to_be32(__pa(str));
> +
Reviewed-by: Ram Pai <linuxram@us.ibm.com>
RP
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-03-25 13:32 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-24 20:12 [PATCH] powerpc/prom_init: Include the termination message in ibm,os-term RTAS call Fabiano Rosas
2020-03-24 20:12 ` [PATCH] powerpc/prom_init: Include the termination message in ibm, os-term " Fabiano Rosas
2020-03-25 10:06 ` [PATCH] powerpc/prom_init: Include the termination message in ibm,os-term " Michael Ellerman
2020-03-25 10:06 ` [PATCH] powerpc/prom_init: Include the termination message in ibm, os-term " Michael Ellerman
2020-03-25 10:34 ` [PATCH] powerpc/prom_init: Include the termination message in ibm,os-term " Greg Kurz
2020-03-25 10:34 ` Greg Kurz
2020-03-25 13:24 ` Fabiano Rosas
2020-03-25 13:24 ` [PATCH] powerpc/prom_init: Include the termination message in ibm, os-term " Fabiano Rosas
2020-03-25 13:24 ` [PATCH] powerpc/prom_init: Include the termination message in ibm,os-term " Ram Pai
2020-03-25 13:24 ` Ram Pai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.