All of lore.kernel.org
 help / color / mirror / Atom feed
From: Francisco Jerez <currojerez@riseup.net>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] Revert "drm/i915: disable set/get_tiling ioctl on gen12+"
Date: Thu, 21 Nov 2019 11:19:03 -0800	[thread overview]
Message-ID: <87sgmhvxzs.fsf@riseup.net> (raw)
In-Reply-To: <20191121181101.401609-1-chris@chris-wilson.co.uk>


[-- Attachment #1.1.1: Type: text/plain, Size: 1913 bytes --]

Chris Wilson <chris@chris-wilson.co.uk> writes:

> Restore the DRI2/DRI3 uABI backchannel that was removed by ab016914984e
> ("drm/i915: disable set/get_tiling ioctl on gen12+") before the ABI
> change was agreed upon.
>
> Fixes: ab016914984e ("drm/i915: disable set/get_tiling ioctl on gen12+")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Thanks.  This makes things easier for userspace until the
modifiers-based alternative to this is in better shape.

Reviewed-by: Francisco Jerez <currojerez@riseup.net>

> ---
>  drivers/gpu/drm/i915/gem/i915_gem_tiling.c | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_tiling.c b/drivers/gpu/drm/i915/gem/i915_gem_tiling.c
> index 1fa592d82af5..39f3bd5defd6 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_tiling.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_tiling.c
> @@ -317,14 +317,10 @@ int
>  i915_gem_set_tiling_ioctl(struct drm_device *dev, void *data,
>  			  struct drm_file *file)
>  {
> -	struct drm_i915_private *dev_priv = to_i915(dev);
>  	struct drm_i915_gem_set_tiling *args = data;
>  	struct drm_i915_gem_object *obj;
>  	int err;
>  
> -	if (!dev_priv->ggtt.num_fences)
> -		return -EOPNOTSUPP;
> -
>  	obj = i915_gem_object_lookup(file, args->handle);
>  	if (!obj)
>  		return -ENOENT;
> @@ -405,9 +401,6 @@ i915_gem_get_tiling_ioctl(struct drm_device *dev, void *data,
>  	struct drm_i915_gem_object *obj;
>  	int err = -ENOENT;
>  
> -	if (!dev_priv->ggtt.num_fences)
> -		return -EOPNOTSUPP;
> -
>  	rcu_read_lock();
>  	obj = i915_gem_object_lookup_rcu(file, args->handle);
>  	if (obj) {
> -- 
> 2.24.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Francisco Jerez <currojerez@riseup.net>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] Revert "drm/i915: disable set/get_tiling ioctl on gen12+"
Date: Thu, 21 Nov 2019 11:19:03 -0800	[thread overview]
Message-ID: <87sgmhvxzs.fsf@riseup.net> (raw)
Message-ID: <20191121191903.4idw8ibtv1QLsEp2rlCstXKVBQeKE17ngSLLj_6RE00@z> (raw)
In-Reply-To: <20191121181101.401609-1-chris@chris-wilson.co.uk>


[-- Attachment #1.1.1: Type: text/plain, Size: 1913 bytes --]

Chris Wilson <chris@chris-wilson.co.uk> writes:

> Restore the DRI2/DRI3 uABI backchannel that was removed by ab016914984e
> ("drm/i915: disable set/get_tiling ioctl on gen12+") before the ABI
> change was agreed upon.
>
> Fixes: ab016914984e ("drm/i915: disable set/get_tiling ioctl on gen12+")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Thanks.  This makes things easier for userspace until the
modifiers-based alternative to this is in better shape.

Reviewed-by: Francisco Jerez <currojerez@riseup.net>

> ---
>  drivers/gpu/drm/i915/gem/i915_gem_tiling.c | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_tiling.c b/drivers/gpu/drm/i915/gem/i915_gem_tiling.c
> index 1fa592d82af5..39f3bd5defd6 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_tiling.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_tiling.c
> @@ -317,14 +317,10 @@ int
>  i915_gem_set_tiling_ioctl(struct drm_device *dev, void *data,
>  			  struct drm_file *file)
>  {
> -	struct drm_i915_private *dev_priv = to_i915(dev);
>  	struct drm_i915_gem_set_tiling *args = data;
>  	struct drm_i915_gem_object *obj;
>  	int err;
>  
> -	if (!dev_priv->ggtt.num_fences)
> -		return -EOPNOTSUPP;
> -
>  	obj = i915_gem_object_lookup(file, args->handle);
>  	if (!obj)
>  		return -ENOENT;
> @@ -405,9 +401,6 @@ i915_gem_get_tiling_ioctl(struct drm_device *dev, void *data,
>  	struct drm_i915_gem_object *obj;
>  	int err = -ENOENT;
>  
> -	if (!dev_priv->ggtt.num_fences)
> -		return -EOPNOTSUPP;
> -
>  	rcu_read_lock();
>  	obj = i915_gem_object_lookup_rcu(file, args->handle);
>  	if (obj) {
> -- 
> 2.24.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-11-21 19:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-21 18:11 [PATCH] Revert "drm/i915: disable set/get_tiling ioctl on gen12+" Chris Wilson
2019-11-21 18:11 ` [Intel-gfx] " Chris Wilson
2019-11-21 18:37 ` Vanshidhar Konda
2019-11-21 18:37   ` [Intel-gfx] " Vanshidhar Konda
2019-11-21 19:01 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-11-21 19:01   ` [Intel-gfx] " Patchwork
2019-11-21 19:19 ` Francisco Jerez [this message]
2019-11-21 19:19   ` [Intel-gfx] [PATCH] " Francisco Jerez
2019-11-21 19:22 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-11-21 19:22   ` [Intel-gfx] " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sgmhvxzs.fsf@riseup.net \
    --to=currojerez@riseup.net \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.