All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] pinctrl: Fix armada-37xx pmic pin group numbering
@ 2017-11-06 16:02 ` Henrik Juul Pedersen
  0 siblings, 0 replies; 4+ messages in thread
From: Henrik Juul Pedersen @ 2017-11-06 16:02 UTC (permalink / raw)
  To: Gregory Clement
  Cc: Jason Cooper, Andrew Lunn, Sebastian Hesselbarth,
	linux-arm-kernel, linux-gpio, Emil Vesterdahl

Fix pin numbering in Marvell ARMADA 37xx pincontroller.

The pmic0 and pmic1 pin groups start on pins 6 and 7 respectively.

Signed-off-by: Henrik Juul Pedersen <hjp@liab.dk>
---
 drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
index 71b94474..e223fac2 100644
--- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
+++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
@@ -157,8 +157,8 @@ static struct armada_37xx_pin_group
armada_37xx_nb_groups[] = {
  PIN_GRP_GPIO("pwm1", 12, 1, BIT(4), "pwm"),
  PIN_GRP_GPIO("pwm2", 13, 1, BIT(5), "pwm"),
  PIN_GRP_GPIO("pwm3", 14, 1, BIT(6), "pwm"),
- PIN_GRP_GPIO("pmic1", 17, 1, BIT(7), "pmic"),
- PIN_GRP_GPIO("pmic0", 16, 1, BIT(8), "pmic"),
+ PIN_GRP_GPIO("pmic1", 7, 1, BIT(7), "pmic"),
+ PIN_GRP_GPIO("pmic0", 6, 1, BIT(8), "pmic"),
  PIN_GRP_GPIO("i2c2", 2, 2, BIT(9), "i2c"),
  PIN_GRP_GPIO("i2c1", 0, 2, BIT(10), "i2c"),
  PIN_GRP_GPIO("spi_cs1", 17, 1, BIT(12), "spi"),
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] pinctrl: Fix armada-37xx pmic pin group numbering
@ 2017-11-06 16:02 ` Henrik Juul Pedersen
  0 siblings, 0 replies; 4+ messages in thread
From: Henrik Juul Pedersen @ 2017-11-06 16:02 UTC (permalink / raw)
  To: linux-arm-kernel

Fix pin numbering in Marvell ARMADA 37xx pincontroller.

The pmic0 and pmic1 pin groups start on pins 6 and 7 respectively.

Signed-off-by: Henrik Juul Pedersen <hjp@liab.dk>
---
 drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
index 71b94474..e223fac2 100644
--- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
+++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
@@ -157,8 +157,8 @@ static struct armada_37xx_pin_group
armada_37xx_nb_groups[] = {
  PIN_GRP_GPIO("pwm1", 12, 1, BIT(4), "pwm"),
  PIN_GRP_GPIO("pwm2", 13, 1, BIT(5), "pwm"),
  PIN_GRP_GPIO("pwm3", 14, 1, BIT(6), "pwm"),
- PIN_GRP_GPIO("pmic1", 17, 1, BIT(7), "pmic"),
- PIN_GRP_GPIO("pmic0", 16, 1, BIT(8), "pmic"),
+ PIN_GRP_GPIO("pmic1", 7, 1, BIT(7), "pmic"),
+ PIN_GRP_GPIO("pmic0", 6, 1, BIT(8), "pmic"),
  PIN_GRP_GPIO("i2c2", 2, 2, BIT(9), "i2c"),
  PIN_GRP_GPIO("i2c1", 0, 2, BIT(10), "i2c"),
  PIN_GRP_GPIO("spi_cs1", 17, 1, BIT(12), "spi"),
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] pinctrl: Fix armada-37xx pmic pin group numbering
  2017-11-06 16:02 ` Henrik Juul Pedersen
@ 2017-11-06 16:09   ` Gregory CLEMENT
  -1 siblings, 0 replies; 4+ messages in thread
From: Gregory CLEMENT @ 2017-11-06 16:09 UTC (permalink / raw)
  To: Henrik Juul Pedersen
  Cc: Andrew Lunn, Jason Cooper, Emil Vesterdahl, linux-gpio,
	linux-arm-kernel, Sebastian Hesselbarth

Hi Henrik,
 
 On lun., nov. 06 2017, Henrik Juul Pedersen <hjp@liab.dk> wrote:

> Fix pin numbering in Marvell ARMADA 37xx pincontroller.
>
> The pmic0 and pmic1 pin groups start on pins 6 and 7 respectively.
>
> Signed-off-by: Henrik Juul Pedersen <hjp@liab.dk>

Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

when applying the patch, we should also add:

Fixes: 87466ccd9401 ("pinctrl: armada-37xx: Add pin controller support
for Armada 37xx")
Cc: <stable@vger.kernel.org>

Thanks,

Gregory

> ---
>  drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
> b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
> index 71b94474..e223fac2 100644
> --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
> +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
> @@ -157,8 +157,8 @@ static struct armada_37xx_pin_group
> armada_37xx_nb_groups[] = {
>   PIN_GRP_GPIO("pwm1", 12, 1, BIT(4), "pwm"),
>   PIN_GRP_GPIO("pwm2", 13, 1, BIT(5), "pwm"),
>   PIN_GRP_GPIO("pwm3", 14, 1, BIT(6), "pwm"),
> - PIN_GRP_GPIO("pmic1", 17, 1, BIT(7), "pmic"),
> - PIN_GRP_GPIO("pmic0", 16, 1, BIT(8), "pmic"),
> + PIN_GRP_GPIO("pmic1", 7, 1, BIT(7), "pmic"),
> + PIN_GRP_GPIO("pmic0", 6, 1, BIT(8), "pmic"),
>   PIN_GRP_GPIO("i2c2", 2, 2, BIT(9), "i2c"),
>   PIN_GRP_GPIO("i2c1", 0, 2, BIT(10), "i2c"),
>   PIN_GRP_GPIO("spi_cs1", 17, 1, BIT(12), "spi"),
> -- 
> 2.14.1
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [PATCH] pinctrl: Fix armada-37xx pmic pin group numbering
@ 2017-11-06 16:09   ` Gregory CLEMENT
  0 siblings, 0 replies; 4+ messages in thread
From: Gregory CLEMENT @ 2017-11-06 16:09 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Henrik,
 
 On lun., nov. 06 2017, Henrik Juul Pedersen <hjp@liab.dk> wrote:

> Fix pin numbering in Marvell ARMADA 37xx pincontroller.
>
> The pmic0 and pmic1 pin groups start on pins 6 and 7 respectively.
>
> Signed-off-by: Henrik Juul Pedersen <hjp@liab.dk>

Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

when applying the patch, we should also add:

Fixes: 87466ccd9401 ("pinctrl: armada-37xx: Add pin controller support
for Armada 37xx")
Cc: <stable@vger.kernel.org>

Thanks,

Gregory

> ---
>  drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
> b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
> index 71b94474..e223fac2 100644
> --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
> +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
> @@ -157,8 +157,8 @@ static struct armada_37xx_pin_group
> armada_37xx_nb_groups[] = {
>   PIN_GRP_GPIO("pwm1", 12, 1, BIT(4), "pwm"),
>   PIN_GRP_GPIO("pwm2", 13, 1, BIT(5), "pwm"),
>   PIN_GRP_GPIO("pwm3", 14, 1, BIT(6), "pwm"),
> - PIN_GRP_GPIO("pmic1", 17, 1, BIT(7), "pmic"),
> - PIN_GRP_GPIO("pmic0", 16, 1, BIT(8), "pmic"),
> + PIN_GRP_GPIO("pmic1", 7, 1, BIT(7), "pmic"),
> + PIN_GRP_GPIO("pmic0", 6, 1, BIT(8), "pmic"),
>   PIN_GRP_GPIO("i2c2", 2, 2, BIT(9), "i2c"),
>   PIN_GRP_GPIO("i2c1", 0, 2, BIT(10), "i2c"),
>   PIN_GRP_GPIO("spi_cs1", 17, 1, BIT(12), "spi"),
> -- 
> 2.14.1
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-06 16:09 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-06 16:02 [PATCH] pinctrl: Fix armada-37xx pmic pin group numbering Henrik Juul Pedersen
2017-11-06 16:02 ` Henrik Juul Pedersen
2017-11-06 16:09 ` Gregory CLEMENT
2017-11-06 16:09   ` Gregory CLEMENT

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.