From: Florian Weimer <fw@deneb.enyo.de>
To: Matthew Wilcox <matthew@wil.cx>
Cc: torvalds@linux-foundation.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org,
Matthew Wilcox <willy@linux.intel.com>
Subject: Re: [PATCH 1/4] stringbuf: A string buffer implementation
Date: Wed, 24 Oct 2007 15:21:06 +0200 [thread overview]
Message-ID: <87sl401we5.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <1193173966-3550-1-git-send-email-matthew@wil.cx> (Matthew Wilcox's message of "Tue, 23 Oct 2007 17:12:43 -0400")
* Matthew Wilcox:
> +struct stringbuf {
> + char *s;
> + int alloc;
> + int len;
> +};
I think alloc and len should be unsigned (including some return values
in the remaining patch).
next prev parent reply other threads:[~2007-10-24 13:46 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-23 21:12 [PATCH 1/4] stringbuf: A string buffer implementation Matthew Wilcox
2007-10-23 21:12 ` [PATCH 2/4] isdn: Use stringbuf Matthew Wilcox
2007-10-23 21:12 ` [PATCH 3/4] sound: " Matthew Wilcox
2007-10-23 21:12 ` [PATCH 4/4] partitions: Fix non-atomic printk Matthew Wilcox
2007-10-24 14:18 ` [PATCH 3/4] sound: Use stringbuf Takashi Iwai
2007-10-24 16:01 ` Matthew Wilcox
2007-10-24 14:50 ` Takashi Iwai
2007-10-23 22:11 ` [PATCH 1/4] stringbuf: A string buffer implementation Matt Mackall
2007-10-24 1:49 ` Matthew Wilcox
2007-10-24 15:20 ` Matt Mackall
2007-10-24 15:30 ` Matthew Wilcox
2007-10-23 23:43 ` Linus Torvalds
2007-10-24 2:30 ` Matthew Wilcox
2007-10-24 2:45 ` Andrew Morton
2007-10-24 2:19 ` Eric St-Laurent
2007-10-24 2:35 ` Matthew Wilcox
2007-10-24 2:48 ` Eric St-Laurent
2007-10-24 13:21 ` Florian Weimer [this message]
2007-10-24 14:02 ` Matthew Wilcox
2007-10-26 12:05 ` Pekka Enberg
2007-10-27 7:31 ` Pavel Machek
2007-10-30 15:26 ` Denys Vlasenko
-- strict thread matches above, loose matches on Subject: below --
2007-10-24 19:58 Stringbuf, v2 Matthew Wilcox
2007-10-24 19:59 ` [PATCH 1/4] stringbuf: A string buffer implementation Matthew Wilcox
2007-10-24 20:59 ` Kyle Moffett
2007-10-24 21:21 ` Matthew Wilcox
2007-10-25 0:07 ` Kyle Moffett
2007-10-25 3:23 ` Matthew Wilcox
2007-10-26 2:11 ` Rusty Russell
2007-10-26 3:41 ` Joe Perches
2007-10-26 5:05 ` Joe Perches
2007-10-26 11:57 ` Matthew Wilcox
2007-10-26 20:57 ` Matt Mackall
2007-10-27 10:09 ` Rusty Russell
2007-10-29 3:03 ` Matt Mackall
2007-10-29 5:38 ` Rusty Russell
2007-10-27 11:47 ` Pekka Enberg
2007-10-27 12:50 ` Rusty Russell
2007-10-27 16:34 ` Pekka Enberg
2007-10-27 16:48 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sl401we5.fsf@mid.deneb.enyo.de \
--to=fw@deneb.enyo.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=torvalds@linux-foundation.org \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.