From: Fabiano Rosas <farosas@suse.de>
To: Peter Xu <peterx@redhat.com>, qemu-devel@nongnu.org
Cc: peterx@redhat.com, Juraj Marcin <jmarcin@redhat.com>,
qemu-stable <qemu-stable@nongnu.org>,
Yuan Liu <yuan1.liu@intel.com>,
Yichen Wang <yichen.wang@bytedance.com>
Subject: Re: [PATCH 3/5] migration/multifd: Replace assert() with error_setg() in recv paths
Date: Tue, 28 Jul 2026 16:51:07 -0300 [thread overview]
Message-ID: <87tspiopuc.fsf@suse.de> (raw)
In-Reply-To: <20260728155247.1894355-4-peterx@redhat.com>
Peter Xu <peterx@redhat.com> writes:
> QPL and UADK multifd backends use assert() to validate wire-controlled
> fields like per-page compressed lengths and packet size consistency. These
> asserts will stop working with released version of binaries, so may stop
> working.
This is not true, asserts are always on. Same for the similar comment in
the previous patch commit message.
>
> Replace all assert() calls in the receive path with proper error_setg() so
> validation failures are reported gracefully rather than crashing or
> silently ignored.
>
> While at it, touch up an assert() in qatzip recv path too.
>
> Cc: qemu-stable <qemu-stable@nongnu.org>
> Cc: Fabiano Rosas <farosas@suse.de>
> Cc: Yuan Liu <yuan1.liu@intel.com>
> Cc: Yichen Wang <yichen.wang@bytedance.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
next prev parent reply other threads:[~2026-07-28 19:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 15:52 [PATCH 0/5] migration: Hardening fixes for 11.2 Peter Xu
2026-07-28 15:52 ` [PATCH 1/5] migration: Fix possible overflow in vmstate_handle_alloc() Peter Xu
2026-07-28 19:19 ` Fabiano Rosas
2026-07-28 15:52 ` [PATCH 2/5] migration/multifd: Validate next_packet_size in zlib/zstd recv Peter Xu
2026-07-28 19:44 ` Fabiano Rosas
2026-07-28 15:52 ` [PATCH 3/5] migration/multifd: Replace assert() with error_setg() in recv paths Peter Xu
2026-07-28 19:51 ` Fabiano Rosas [this message]
2026-07-28 20:28 ` Peter Xu
2026-07-28 20:59 ` Fabiano Rosas
2026-07-28 21:07 ` Peter Xu
2026-07-28 15:52 ` [PATCH 4/5] migration: Fix rare hang of migration_channel_read_peek() Peter Xu
2026-07-28 16:24 ` Daniel P. Berrangé
2026-07-28 17:09 ` Peter Xu
2026-07-28 17:12 ` Daniel P. Berrangé
2026-07-28 19:59 ` Fabiano Rosas
2026-07-28 20:46 ` Peter Xu
2026-07-28 21:00 ` Fabiano Rosas
2026-07-28 21:31 ` Peter Xu
2026-07-28 15:52 ` [PATCH 5/5] migration/ram: Check for RAMBlock size mismatch when parsing Peter Xu
2026-07-28 19:54 ` Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tspiopuc.fsf@suse.de \
--to=farosas@suse.de \
--cc=jmarcin@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=yichen.wang@bytedance.com \
--cc=yuan1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.