From: Peter Xu <peterx@redhat.com>
To: Fabiano Rosas <farosas@suse.de>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
qemu-devel@nongnu.org, "Juraj Marcin" <jmarcin@redhat.com>,
"Feifan Qian" <bea1e@proton.me>
Subject: Re: [PATCH 4/5] migration: Fix rare hang of migration_channel_read_peek()
Date: Tue, 28 Jul 2026 17:31:45 -0400 [thread overview]
Message-ID: <amkfwdkkwBlt7hfA@x1.local> (raw)
In-Reply-To: <87ecgmomm5.fsf@suse.de>
On Tue, Jul 28, 2026 at 06:00:50PM -0300, Fabiano Rosas wrote:
> If I'm not mistaken the watch only dispatches when there's IO.
Listening sockets are registered with:
socket_connect_incoming ->
qio_net_listener_set_client_func_full ->
qio_net_listener_set_client_func_internal ->
qio_net_listener_watch
So the watcher is on the listening socket, not IO socket.
qio_net_listener_channel_func() will accept() and create the IO socket,
then it does the callback to socket_accept_incoming_migration() on the IO
socket just created.
--
Peter Xu
next prev parent reply other threads:[~2026-07-28 21:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 15:52 [PATCH 0/5] migration: Hardening fixes for 11.2 Peter Xu
2026-07-28 15:52 ` [PATCH 1/5] migration: Fix possible overflow in vmstate_handle_alloc() Peter Xu
2026-07-28 19:19 ` Fabiano Rosas
2026-07-28 15:52 ` [PATCH 2/5] migration/multifd: Validate next_packet_size in zlib/zstd recv Peter Xu
2026-07-28 19:44 ` Fabiano Rosas
2026-07-28 15:52 ` [PATCH 3/5] migration/multifd: Replace assert() with error_setg() in recv paths Peter Xu
2026-07-28 19:51 ` Fabiano Rosas
2026-07-28 20:28 ` Peter Xu
2026-07-28 20:59 ` Fabiano Rosas
2026-07-28 21:07 ` Peter Xu
2026-07-28 15:52 ` [PATCH 4/5] migration: Fix rare hang of migration_channel_read_peek() Peter Xu
2026-07-28 16:24 ` Daniel P. Berrangé
2026-07-28 17:09 ` Peter Xu
2026-07-28 17:12 ` Daniel P. Berrangé
2026-07-28 19:59 ` Fabiano Rosas
2026-07-28 20:46 ` Peter Xu
2026-07-28 21:00 ` Fabiano Rosas
2026-07-28 21:31 ` Peter Xu [this message]
2026-07-28 15:52 ` [PATCH 5/5] migration/ram: Check for RAMBlock size mismatch when parsing Peter Xu
2026-07-28 19:54 ` Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amkfwdkkwBlt7hfA@x1.local \
--to=peterx@redhat.com \
--cc=bea1e@proton.me \
--cc=berrange@redhat.com \
--cc=farosas@suse.de \
--cc=jmarcin@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.