[PATCH] migration: Remove unnecessary zlib include from qemu-file.h

[PATCH] migration: Remove unnecessary zlib include from qemu-file.h

[Chad Jablonski]

Commit 70eb5fde05 removed zlib from the libmigration dependencies but
missed removing the zlib include from the header file. zlib doesn't
appear to be used anywhere in qemu-file.h. This is fine in most
environments where zlib is nearly always in the default include path but
breaks the build when it isn't (NixOS for example).

Fixes: 70eb5fde05 ("migration: remove unnecessary zlib dependency")
Signed-off-by: Chad Jablonski <chad@jablonski.xyz>
---
 migration/qemu-file.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/migration/qemu-file.h b/migration/qemu-file.h
index c13c967167..c50a3fee53 100644
--- a/migration/qemu-file.h
+++ b/migration/qemu-file.h
@@ -25,7 +25,6 @@
 #ifndef MIGRATION_QEMU_FILE_H
 #define MIGRATION_QEMU_FILE_H
 
-#include <zlib.h>
 #include "exec/cpu-common.h"
 #include "io/channel.h"
 
-- 
2.51.2

Re: [PATCH] migration: Remove unnecessary zlib include from qemu-file.h

[Philippe Mathieu-Daudé]

On 19/12/25 02:45, Chad Jablonski wrote:
> Commit 70eb5fde05 removed zlib from the libmigration dependencies but
> missed removing the zlib include from the header file. zlib doesn't
> appear to be used anywhere in qemu-file.h. This is fine in most
> environments where zlib is nearly always in the default include path but
> breaks the build when it isn't (NixOS for example).
> 
> Fixes: 70eb5fde05 ("migration: remove unnecessary zlib dependency")
> Signed-off-by: Chad Jablonski <chad@jablonski.xyz>
> ---
>   migration/qemu-file.h | 1 -
>   1 file changed, 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH] migration: Remove unnecessary zlib include from qemu-file.h

[Chad Jablonski]

This patch receieved an R-b but hasn't been merged yet. Is there
anything else needed, or can it go into rc3?

Thanks

Re: [PATCH] migration: Remove unnecessary zlib include from qemu-file.h

[Philippe Mathieu-Daudé]

Cc'ing maintainers:

$ ./scripts/get_maintainer.pl -f migration/qemu-file.h
Peter Xu <peterx@redhat.com> (maintainer:Migration)
Fabiano Rosas <farosas@suse.de> (maintainer:Migration)

On 19/12/25 02:45, Chad Jablonski wrote:
> Commit 70eb5fde05 removed zlib from the libmigration dependencies but
> missed removing the zlib include from the header file. zlib doesn't
> appear to be used anywhere in qemu-file.h. This is fine in most
> environments where zlib is nearly always in the default include path but
> breaks the build when it isn't (NixOS for example).
> 
> Fixes: 70eb5fde05 ("migration: remove unnecessary zlib dependency")
> Signed-off-by: Chad Jablonski <chad@jablonski.xyz>
> ---
>   migration/qemu-file.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/migration/qemu-file.h b/migration/qemu-file.h
> index c13c967167..c50a3fee53 100644
> --- a/migration/qemu-file.h
> +++ b/migration/qemu-file.h
> @@ -25,7 +25,6 @@
>   #ifndef MIGRATION_QEMU_FILE_H
>   #define MIGRATION_QEMU_FILE_H
>   
> -#include <zlib.h>
>   #include "exec/cpu-common.h"
>   #include "io/channel.h"
>   

Re: [PATCH] migration: Remove unnecessary zlib include from qemu-file.h

[Fabiano Rosas]

Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> Cc'ing maintainers:
>
> $ ./scripts/get_maintainer.pl -f migration/qemu-file.h
> Peter Xu <peterx@redhat.com> (maintainer:Migration)
> Fabiano Rosas <farosas@suse.de> (maintainer:Migration)
>

Thank you, Philippe!

Queued.

Re: [PATCH] migration: Remove unnecessary zlib include from qemu-file.h

[Peter Maydell]

On Fri, 10 Apr 2026 at 14:52, Fabiano Rosas <farosas@suse.de> wrote:
>
> Philippe Mathieu-Daudé <philmd@linaro.org> writes:
>
> > Cc'ing maintainers:
> >
> > $ ./scripts/get_maintainer.pl -f migration/qemu-file.h
> > Peter Xu <peterx@redhat.com> (maintainer:Migration)
> > Fabiano Rosas <farosas@suse.de> (maintainer:Migration)
> >
>
> Thank you, Philippe!
>
> Queued.

Hi; I plan to apply this directly to git so we can get it into rc4.

thanks
-- PMM