* [PATCH] migration: Remove unnecessary zlib include from qemu-file.h
@ 2025-12-19 1:45 Chad Jablonski
2025-12-19 4:28 ` Philippe Mathieu-Daudé
2026-04-10 13:42 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 6+ messages in thread
From: Chad Jablonski @ 2025-12-19 1:45 UTC (permalink / raw)
To: qemu-devel; +Cc: pbonzini, Chad Jablonski
Commit 70eb5fde05 removed zlib from the libmigration dependencies but
missed removing the zlib include from the header file. zlib doesn't
appear to be used anywhere in qemu-file.h. This is fine in most
environments where zlib is nearly always in the default include path but
breaks the build when it isn't (NixOS for example).
Fixes: 70eb5fde05 ("migration: remove unnecessary zlib dependency")
Signed-off-by: Chad Jablonski <chad@jablonski.xyz>
---
migration/qemu-file.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/migration/qemu-file.h b/migration/qemu-file.h
index c13c967167..c50a3fee53 100644
--- a/migration/qemu-file.h
+++ b/migration/qemu-file.h
@@ -25,7 +25,6 @@
#ifndef MIGRATION_QEMU_FILE_H
#define MIGRATION_QEMU_FILE_H
-#include <zlib.h>
#include "exec/cpu-common.h"
#include "io/channel.h"
--
2.51.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] migration: Remove unnecessary zlib include from qemu-file.h
2025-12-19 1:45 [PATCH] migration: Remove unnecessary zlib include from qemu-file.h Chad Jablonski
@ 2025-12-19 4:28 ` Philippe Mathieu-Daudé
2026-04-06 13:59 ` Chad Jablonski
2026-04-10 13:42 ` Philippe Mathieu-Daudé
1 sibling, 1 reply; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-12-19 4:28 UTC (permalink / raw)
To: Chad Jablonski, qemu-devel; +Cc: pbonzini
On 19/12/25 02:45, Chad Jablonski wrote:
> Commit 70eb5fde05 removed zlib from the libmigration dependencies but
> missed removing the zlib include from the header file. zlib doesn't
> appear to be used anywhere in qemu-file.h. This is fine in most
> environments where zlib is nearly always in the default include path but
> breaks the build when it isn't (NixOS for example).
>
> Fixes: 70eb5fde05 ("migration: remove unnecessary zlib dependency")
> Signed-off-by: Chad Jablonski <chad@jablonski.xyz>
> ---
> migration/qemu-file.h | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] migration: Remove unnecessary zlib include from qemu-file.h
2025-12-19 1:45 [PATCH] migration: Remove unnecessary zlib include from qemu-file.h Chad Jablonski
2025-12-19 4:28 ` Philippe Mathieu-Daudé
@ 2026-04-10 13:42 ` Philippe Mathieu-Daudé
2026-04-10 13:51 ` Fabiano Rosas
1 sibling, 1 reply; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2026-04-10 13:42 UTC (permalink / raw)
To: Chad Jablonski, qemu-devel; +Cc: pbonzini, Fabiano Rosas, Peter Xu
Cc'ing maintainers:
$ ./scripts/get_maintainer.pl -f migration/qemu-file.h
Peter Xu <peterx@redhat.com> (maintainer:Migration)
Fabiano Rosas <farosas@suse.de> (maintainer:Migration)
On 19/12/25 02:45, Chad Jablonski wrote:
> Commit 70eb5fde05 removed zlib from the libmigration dependencies but
> missed removing the zlib include from the header file. zlib doesn't
> appear to be used anywhere in qemu-file.h. This is fine in most
> environments where zlib is nearly always in the default include path but
> breaks the build when it isn't (NixOS for example).
>
> Fixes: 70eb5fde05 ("migration: remove unnecessary zlib dependency")
> Signed-off-by: Chad Jablonski <chad@jablonski.xyz>
> ---
> migration/qemu-file.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/migration/qemu-file.h b/migration/qemu-file.h
> index c13c967167..c50a3fee53 100644
> --- a/migration/qemu-file.h
> +++ b/migration/qemu-file.h
> @@ -25,7 +25,6 @@
> #ifndef MIGRATION_QEMU_FILE_H
> #define MIGRATION_QEMU_FILE_H
>
> -#include <zlib.h>
> #include "exec/cpu-common.h"
> #include "io/channel.h"
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] migration: Remove unnecessary zlib include from qemu-file.h
2026-04-10 13:42 ` Philippe Mathieu-Daudé
@ 2026-04-10 13:51 ` Fabiano Rosas
2026-04-14 15:32 ` Peter Maydell
0 siblings, 1 reply; 6+ messages in thread
From: Fabiano Rosas @ 2026-04-10 13:51 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, Chad Jablonski, qemu-devel
Cc: pbonzini, Peter Xu
Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> Cc'ing maintainers:
>
> $ ./scripts/get_maintainer.pl -f migration/qemu-file.h
> Peter Xu <peterx@redhat.com> (maintainer:Migration)
> Fabiano Rosas <farosas@suse.de> (maintainer:Migration)
>
Thank you, Philippe!
Queued.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] migration: Remove unnecessary zlib include from qemu-file.h
2026-04-10 13:51 ` Fabiano Rosas
@ 2026-04-14 15:32 ` Peter Maydell
0 siblings, 0 replies; 6+ messages in thread
From: Peter Maydell @ 2026-04-14 15:32 UTC (permalink / raw)
To: Fabiano Rosas
Cc: Philippe Mathieu-Daudé, Chad Jablonski, qemu-devel, pbonzini,
Peter Xu
On Fri, 10 Apr 2026 at 14:52, Fabiano Rosas <farosas@suse.de> wrote:
>
> Philippe Mathieu-Daudé <philmd@linaro.org> writes:
>
> > Cc'ing maintainers:
> >
> > $ ./scripts/get_maintainer.pl -f migration/qemu-file.h
> > Peter Xu <peterx@redhat.com> (maintainer:Migration)
> > Fabiano Rosas <farosas@suse.de> (maintainer:Migration)
> >
>
> Thank you, Philippe!
>
> Queued.
Hi; I plan to apply this directly to git so we can get it into rc4.
thanks
-- PMM
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-04-14 15:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-19 1:45 [PATCH] migration: Remove unnecessary zlib include from qemu-file.h Chad Jablonski
2025-12-19 4:28 ` Philippe Mathieu-Daudé
2026-04-06 13:59 ` Chad Jablonski
2026-04-10 13:42 ` Philippe Mathieu-Daudé
2026-04-10 13:51 ` Fabiano Rosas
2026-04-14 15:32 ` Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.