All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Qin Jian <qinjian@cqplus1.com>
Cc: robh+dt@kernel.org, mturquette@baylibre.com, sboyd@kernel.org,
	tglx@linutronix.de, p.zabel@pengutronix.de,
	linux@armlinux.org.uk, broonie@kernel.org, arnd@arndb.de,
	stefan.wahren@i2se.com, linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org, wells.lu@sunplus.com
Subject: Re: [PATCH v6 08/10] irqchip: Add Sunplus SP7021 interrupt controller driver
Date: Thu, 16 Dec 2021 08:51:40 +0000	[thread overview]
Message-ID: <87tuf9vso3.wl-maz@kernel.org> (raw)
In-Reply-To: <677ce3dd9b4650521968d6cb50999608b5136ddd.1639560427.git.qinjian@cqplus1.com>

On Thu, 16 Dec 2021 07:08:10 +0000,
Qin Jian <qinjian@cqplus1.com> wrote:
> 
> Add interrupt controller driver for Sunplus SP7021 SoC.
> 
> This is the interrupt controller in P-chip which collects all interrupt
> sources in P-chip and routes them to parent interrupt controller in C-chip.
> 
> Signed-off-by: Qin Jian <qinjian@cqplus1.com>
> ---
> Fix the comments from Marc.

No, you didn't.

> +void sp_intc_set_ext(u32 hwirq, int ext_num)
> +{
> +	sp_intc_assign_bit(hwirq, REG_INTR_PRIORITY, !ext_num);
> +}
> +EXPORT_SYMBOL_GPL(sp_intc_set_ext);

I already commented on this. In case it wasn't clear, this is a strong
NAK to random low-level hacks like this.

	M.

-- 
Without deviation from the norm, progress is not possible.

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Qin Jian <qinjian@cqplus1.com>
Cc: robh+dt@kernel.org, mturquette@baylibre.com, sboyd@kernel.org,
	tglx@linutronix.de, p.zabel@pengutronix.de,
	linux@armlinux.org.uk, broonie@kernel.org, arnd@arndb.de,
	stefan.wahren@i2se.com, linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org, wells.lu@sunplus.com
Subject: Re: [PATCH v6 08/10] irqchip: Add Sunplus SP7021 interrupt controller driver
Date: Thu, 16 Dec 2021 08:51:40 +0000	[thread overview]
Message-ID: <87tuf9vso3.wl-maz@kernel.org> (raw)
In-Reply-To: <677ce3dd9b4650521968d6cb50999608b5136ddd.1639560427.git.qinjian@cqplus1.com>

On Thu, 16 Dec 2021 07:08:10 +0000,
Qin Jian <qinjian@cqplus1.com> wrote:
> 
> Add interrupt controller driver for Sunplus SP7021 SoC.
> 
> This is the interrupt controller in P-chip which collects all interrupt
> sources in P-chip and routes them to parent interrupt controller in C-chip.
> 
> Signed-off-by: Qin Jian <qinjian@cqplus1.com>
> ---
> Fix the comments from Marc.

No, you didn't.

> +void sp_intc_set_ext(u32 hwirq, int ext_num)
> +{
> +	sp_intc_assign_bit(hwirq, REG_INTR_PRIORITY, !ext_num);
> +}
> +EXPORT_SYMBOL_GPL(sp_intc_set_ext);

I already commented on this. In case it wasn't clear, this is a strong
NAK to random low-level hacks like this.

	M.

-- 
Without deviation from the norm, progress is not possible.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-12-16  8:51 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-16  7:08 [PATCH v6 00/10] Add Sunplus SP7021 SoC Support Qin Jian
2021-12-16  7:08 ` Qin Jian
2021-12-16  7:08 ` [PATCH v6 01/10] dt-bindings: vendor-prefixes: Add Sunplus Qin Jian
2021-12-16  7:08   ` Qin Jian
2021-12-16  7:08 ` [PATCH v6 02/10] dt-bindings: arm: sunplus: Add bindings for Sunplus SP7021 SoC boards Qin Jian
2021-12-16  7:08   ` Qin Jian
2021-12-16  7:08 ` [PATCH v6 03/10] dt-bindings: reset: Add bindings for SP7021 reset driver Qin Jian
2021-12-16  7:08   ` Qin Jian
2021-12-16  7:08 ` [PATCH v6 04/10] reset: Add Sunplus " Qin Jian
2021-12-16  7:08   ` Qin Jian
2021-12-16  9:52   ` Philipp Zabel
2021-12-16  9:52     ` Philipp Zabel
2021-12-16  7:08 ` [PATCH v6 05/10] dt-bindings: clock: Add bindings for SP7021 clock driver Qin Jian
2021-12-16  7:08   ` Qin Jian
2021-12-16  7:08 ` [PATCH v6 06/10] clk: Add Sunplus " Qin Jian
2021-12-16  7:08   ` Qin Jian
2021-12-16  7:08 ` [PATCH v6 07/10] dt-bindings: interrupt-controller: Add bindings for SP7021 interrupt controller Qin Jian
2021-12-16  7:08   ` Qin Jian
2021-12-16  7:08 ` [PATCH v6 08/10] irqchip: Add Sunplus SP7021 interrupt controller driver Qin Jian
2021-12-16  7:08   ` Qin Jian
2021-12-16  8:51   ` Marc Zyngier [this message]
2021-12-16  8:51     ` Marc Zyngier
2021-12-16 10:06     ` qinjian[覃健]
2021-12-16 10:06       ` qinjian[覃健]
2021-12-16  7:08 ` [PATCH v6 09/10] ARM: sunplus: Add initial support for Sunplus SP7021 SoC Qin Jian
2021-12-16  7:08   ` Qin Jian
2021-12-16  7:08 ` [PATCH v6 10/10] ARM: sp7021_defconfig: Add Sunplus SP7021 defconfig Qin Jian
2021-12-16  7:08   ` Qin Jian
2021-12-16  8:12 ` [PATCH v6 00/10] Add Sunplus SP7021 SoC Support Arnd Bergmann
2021-12-16  8:12   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tuf9vso3.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=arnd@arndb.de \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mturquette@baylibre.com \
    --cc=p.zabel@pengutronix.de \
    --cc=qinjian@cqplus1.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=stefan.wahren@i2se.com \
    --cc=tglx@linutronix.de \
    --cc=wells.lu@sunplus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.