All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Valo, Kalle" <kvalo@qca.qualcomm.com>
To: Erik Stromdahl <erik.stromdahl@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [RFC v3 0/8] ath10k sdio support
Date: Sun, 19 Feb 2017 16:33:55 +0000	[thread overview]
Message-ID: <87tw7q2l8v.fsf@qca.qualcomm.com> (raw)
In-Reply-To: <e8e1a379-129a-a8c3-9e1f-fb4c70fd0ab6@gmail.com> (Erik Stromdahl's message of "Sun, 19 Feb 2017 17:21:43 +0100")

Erik Stromdahl <erik.stromdahl@gmail.com> writes:

> Ok, I'll do another round of checkpatch before I submit anything.
> I couldn't find the script you mentioned though (ath10k-check).

Did you check the link I gave you:

https://wireless.wiki.kernel.org/en/users/drivers/ath10k/codingstyle#checking_code

> Is it some kind of checkpatch wrapper?

It runs various tests (gcc, sparse, checkpatch), sets some checkpatch
settings (like line length) and filters out warnings we don't care
about.

> Anyway, I have a few warnings related to 'line over 80 chars' that
> is really hard to get rid of (without breaking indentation etc.) so
> I won't do anything about those for now.
>
> Then there are some other warnings about the BIT macro being preferred
> over (1 << x). I have used (1 << x) in some files despite the checkpatch
> warning in order to keep the patches consistent with the existing code.
> I think the best approach is to have a separate round of cleanup-patches
> replacing all (1 << x) with BIT(x).

These are all disabled by ath10k-check. I think it's easiest that you
forget ath10k-check for now and let me fix those in the next round.

-- 
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: "Valo, Kalle" <kvalo@qca.qualcomm.com>
To: Erik Stromdahl <erik.stromdahl@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [RFC v3 0/8] ath10k sdio support
Date: Sun, 19 Feb 2017 16:33:55 +0000	[thread overview]
Message-ID: <87tw7q2l8v.fsf@qca.qualcomm.com> (raw)
In-Reply-To: <e8e1a379-129a-a8c3-9e1f-fb4c70fd0ab6@gmail.com> (Erik Stromdahl's message of "Sun, 19 Feb 2017 17:21:43 +0100")

Erik Stromdahl <erik.stromdahl@gmail.com> writes:

> Ok, I'll do another round of checkpatch before I submit anything.
> I couldn't find the script you mentioned though (ath10k-check).

Did you check the link I gave you:

https://wireless.wiki.kernel.org/en/users/drivers/ath10k/codingstyle#checki=
ng_code

> Is it some kind of checkpatch wrapper?

It runs various tests (gcc, sparse, checkpatch), sets some checkpatch
settings (like line length) and filters out warnings we don't care
about.

> Anyway, I have a few warnings related to 'line over 80 chars' that
> is really hard to get rid of (without breaking indentation etc.) so
> I won't do anything about those for now.
>
> Then there are some other warnings about the BIT macro being preferred
> over (1 << x). I have used (1 << x) in some files despite the checkpatch
> warning in order to keep the patches consistent with the existing code.
> I think the best approach is to have a separate round of cleanup-patches
> replacing all (1 << x) with BIT(x).

These are all disabled by ath10k-check. I think it's easiest that you
forget ath10k-check for now and let me fix those in the next round.

--=20
Kalle Valo=

  reply	other threads:[~2017-02-19 16:34 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-13 21:26 [RFC v3 0/8] ath10k sdio support Erik Stromdahl
2017-01-13 21:26 ` Erik Stromdahl
2017-01-13 21:26 ` [RFC v3 1/8] ath10k: htc: made static function public Erik Stromdahl
2017-01-13 21:26   ` Erik Stromdahl
2017-01-13 21:26 ` [RFC v3 2/8] ath10k: htc: rx trailer lookahead support Erik Stromdahl
2017-01-13 21:26   ` Erik Stromdahl
2017-01-13 21:26 ` [RFC v3 3/8] ath10k: htc: move htc ctrl ep connect to htc_init Erik Stromdahl
2017-01-13 21:26   ` Erik Stromdahl
2017-01-13 21:26 ` [RFC v3 4/8] ath10k: htc: refactorization Erik Stromdahl
2017-01-13 21:26   ` Erik Stromdahl
2017-01-13 21:26 ` [RFC v3 5/8] ath10k: various sdio related definitions Erik Stromdahl
2017-01-13 21:26   ` Erik Stromdahl
2017-01-13 21:26 ` [RFC v3 6/8] ath10k: sdio support Erik Stromdahl
2017-01-13 21:26   ` Erik Stromdahl
2017-01-13 21:26 ` [RFC v3 7/8] ath10k: sdio get target info Erik Stromdahl
2017-01-13 21:26   ` Erik Stromdahl
2017-01-13 21:26 ` [RFC v3 8/8] ath10k: htc: ready_ext msg support Erik Stromdahl
2017-01-13 21:26   ` Erik Stromdahl
2017-01-23 11:08 ` [RFC v3 0/8] ath10k sdio support Valo, Kalle
2017-01-23 11:08   ` Valo, Kalle
2017-02-18 13:40 ` Valo, Kalle
2017-02-18 13:40   ` Valo, Kalle
2017-02-18 22:05   ` Erik Stromdahl
2017-02-18 22:05     ` Erik Stromdahl
2017-02-18 23:57     ` Valo, Kalle
2017-02-18 23:57       ` Valo, Kalle
2017-02-19 13:19       ` Erik Stromdahl
2017-02-19 13:52         ` Erik Stromdahl
2017-02-19 13:52           ` Erik Stromdahl
2017-02-19 14:05           ` Valo, Kalle
2017-02-19 14:05             ` Valo, Kalle
2017-02-19 16:30             ` Erik Stromdahl
2017-02-19 16:30               ` Erik Stromdahl
2017-02-19 13:59       ` Valo, Kalle
2017-02-19 13:59         ` Valo, Kalle
2017-02-19 16:21         ` Erik Stromdahl
2017-02-19 16:21           ` Erik Stromdahl
2017-02-19 16:33           ` Valo, Kalle [this message]
2017-02-19 16:33             ` Valo, Kalle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tw7q2l8v.fsf@qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=erik.stromdahl@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.