From: Jani Nikula <jani.nikula@intel.com>
To: Michael Ellerman <mpe@ellerman.id.au>,
Randy Dunlap <rdunlap@infradead.org>
Cc: linux-fbdev@vger.kernel.org, linux-usb@vger.kernel.org,
Daniel Drake <dsd@laptop.org>,
Jens Frederich <jfrederich@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jon Nettleton <jon.nettleton@gmail.com>,
Jingoo Han <jg1.han@samsung.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
platform-driver-x86@vger.kernel.org,
Bryan Wu <cooloney@gmail.com>,
linuxppc-dev@lists.ozlabs.org,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Daniel Vetter <daniel.vetter@intel.com>,
Darren Hart <dvhart@infradead.org>,
Lee Jones <lee.jones@linaro.org>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Subject: Re: [PATCH] drivers: depend on instead of select BACKLIGHT_CLASS_DEVICE and ACPI_VIDEO
Date: Wed, 29 Oct 2014 07:54:36 +0000 [thread overview]
Message-ID: <87tx2njooz.fsf@intel.com> (raw)
In-Reply-To: <1414551853.7417.1.camel@concordia>
On Wed, 29 Oct 2014, Michael Ellerman <mpe@ellerman.id.au> wrote:
> On Tue, 2014-10-28 at 13:29 -0700, Randy Dunlap wrote:
>> On 10/27/14 06:13, Tomi Valkeinen wrote:
>> > I also think the 'depends on BACKLIGHT_CLASS_DEVICE ||
>> > BACKLIGHT_CLASS_DEVICE=n' pattern is quite... interesting (i.e. sounds
>> > like a hack to me =).
>>
>> It does exactly what is needed and it is used in many places in kernel
>> Kconfig files.
>
> Is there any reason you can't do:
>
> depends on BACKLIGHT_CLASS_DEVICE != m
That's not the same thing. The FOO || FOO=n allows for all options, but
forbids it being a module when the option depending on it is
built-in. Obviously something that's built-in can't depend on something
built as a module.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@intel.com>
To: Michael Ellerman <mpe@ellerman.id.au>,
Randy Dunlap <rdunlap@infradead.org>
Cc: linux-fbdev@vger.kernel.org, linux-usb@vger.kernel.org,
Daniel Drake <dsd@laptop.org>,
Jens Frederich <jfrederich@gmail.com>,
David Airlie <airlied@linux.ie>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jon Nettleton <jon.nettleton@gmail.com>,
Jingoo Han <jg1.han@samsung.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
platform-driver-x86@vger.kernel.org,
Bryan Wu <cooloney@gmail.com>,
linuxppc-dev@lists.ozlabs.org,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Daniel Vetter <daniel.vetter@intel.com>,
Darren Hart <dvhart@infradead.org>,
Lee Jones <lee.jones@linaro.org>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Subject: Re: [PATCH] drivers: depend on instead of select BACKLIGHT_CLASS_DEVICE and ACPI_VIDEO
Date: Wed, 29 Oct 2014 09:54:36 +0200 [thread overview]
Message-ID: <87tx2njooz.fsf@intel.com> (raw)
In-Reply-To: <1414551853.7417.1.camel@concordia>
On Wed, 29 Oct 2014, Michael Ellerman <mpe@ellerman.id.au> wrote:
> On Tue, 2014-10-28 at 13:29 -0700, Randy Dunlap wrote:
>> On 10/27/14 06:13, Tomi Valkeinen wrote:
>> > I also think the 'depends on BACKLIGHT_CLASS_DEVICE ||
>> > BACKLIGHT_CLASS_DEVICE=n' pattern is quite... interesting (i.e. sounds
>> > like a hack to me =).
>>
>> It does exactly what is needed and it is used in many places in kernel
>> Kconfig files.
>
> Is there any reason you can't do:
>
> depends on BACKLIGHT_CLASS_DEVICE != m
That's not the same thing. The FOO || FOO=n allows for all options, but
forbids it being a module when the option depending on it is
built-in. Obviously something that's built-in can't depend on something
built as a module.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@intel.com>
To: Michael Ellerman <mpe@ellerman.id.au>,
Randy Dunlap <rdunlap@infradead.org>
Cc: linux-fbdev@vger.kernel.org, linux-usb@vger.kernel.org,
Daniel Drake <dsd@laptop.org>,
Jens Frederich <jfrederich@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jon Nettleton <jon.nettleton@gmail.com>,
Jingoo Han <jg1.han@samsung.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
platform-driver-x86@vger.kernel.org,
Bryan Wu <cooloney@gmail.com>,
linuxppc-dev@lists.ozlabs.org,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Daniel Vetter <daniel.vetter@intel.com>,
Darren Hart <dvhart@infradead.org>,
Lee Jones <lee.jones@linaro.org>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Subject: Re: [PATCH] drivers: depend on instead of select BACKLIGHT_CLASS_DEVICE and ACPI_VIDEO
Date: Wed, 29 Oct 2014 09:54:36 +0200 [thread overview]
Message-ID: <87tx2njooz.fsf@intel.com> (raw)
In-Reply-To: <1414551853.7417.1.camel@concordia>
On Wed, 29 Oct 2014, Michael Ellerman <mpe@ellerman.id.au> wrote:
> On Tue, 2014-10-28 at 13:29 -0700, Randy Dunlap wrote:
>> On 10/27/14 06:13, Tomi Valkeinen wrote:
>> > I also think the 'depends on BACKLIGHT_CLASS_DEVICE ||
>> > BACKLIGHT_CLASS_DEVICE=n' pattern is quite... interesting (i.e. sounds
>> > like a hack to me =).
>>
>> It does exactly what is needed and it is used in many places in kernel
>> Kconfig files.
>
> Is there any reason you can't do:
>
> depends on BACKLIGHT_CLASS_DEVICE != m
That's not the same thing. The FOO || FOO=n allows for all options, but
forbids it being a module when the option depending on it is
built-in. Obviously something that's built-in can't depend on something
built as a module.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@intel.com>
To: Michael Ellerman <mpe@ellerman.id.au>,
Randy Dunlap <rdunlap@infradead.org>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
linux-fbdev@vger.kernel.org, Jingoo Han <jg1.han@samsung.com>,
Daniel Drake <dsd@laptop.org>,
Jens Frederich <jfrederich@gmail.com>,
David Airlie <airlied@linux.ie>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jon Nettleton <jon.nettleton@gmail.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
platform-driver-x86@vger.kernel.org,
Lee Jones <lee.jones@linaro.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Darren Hart <dvhart@infradead.org>,
Daniel Vetter <daniel.vetter@intel.com>,
Bryan Wu <cooloney@gmail.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] drivers: depend on instead of select BACKLIGHT_CLASS_DEVICE and ACPI_VIDEO
Date: Wed, 29 Oct 2014 09:54:36 +0200 [thread overview]
Message-ID: <87tx2njooz.fsf@intel.com> (raw)
In-Reply-To: <1414551853.7417.1.camel@concordia>
On Wed, 29 Oct 2014, Michael Ellerman <mpe@ellerman.id.au> wrote:
> On Tue, 2014-10-28 at 13:29 -0700, Randy Dunlap wrote:
>> On 10/27/14 06:13, Tomi Valkeinen wrote:
>> > I also think the 'depends on BACKLIGHT_CLASS_DEVICE ||
>> > BACKLIGHT_CLASS_DEVICE=n' pattern is quite... interesting (i.e. sounds
>> > like a hack to me =).
>>
>> It does exactly what is needed and it is used in many places in kernel
>> Kconfig files.
>
> Is there any reason you can't do:
>
> depends on BACKLIGHT_CLASS_DEVICE != m
That's not the same thing. The FOO || FOO=n allows for all options, but
forbids it being a module when the option depending on it is
built-in. Obviously something that's built-in can't depend on something
built as a module.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-10-29 7:54 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-17 21:13 [PATCH] drivers: depend on instead of select BACKLIGHT_CLASS_DEVICE and ACPI_VIDEO Jani Nikula
2014-10-17 21:13 ` Jani Nikula
2014-10-17 21:13 ` Jani Nikula
2014-10-17 21:13 ` Jani Nikula
2014-10-21 20:50 ` Darren Hart
2014-10-21 20:50 ` Darren Hart
2014-10-21 20:50 ` Darren Hart
2014-10-22 8:02 ` Tomi Valkeinen
2014-10-22 8:02 ` Tomi Valkeinen
2014-10-22 8:02 ` Tomi Valkeinen
2014-10-22 8:02 ` Tomi Valkeinen
2014-10-23 8:10 ` Daniel Vetter
2014-10-23 8:10 ` Daniel Vetter
2014-10-23 8:10 ` Daniel Vetter
2014-10-23 8:10 ` Daniel Vetter
2014-10-23 11:38 ` Tomi Valkeinen
2014-10-23 11:38 ` Tomi Valkeinen
2014-10-23 11:38 ` Tomi Valkeinen
2014-10-23 11:38 ` Tomi Valkeinen
2014-10-27 11:59 ` Jani Nikula
2014-10-27 11:59 ` Jani Nikula
2014-10-27 11:59 ` Jani Nikula
2014-10-27 13:13 ` Tomi Valkeinen
2014-10-27 13:13 ` Tomi Valkeinen
2014-10-27 13:13 ` Tomi Valkeinen
2014-10-27 13:13 ` Tomi Valkeinen
2014-10-28 20:29 ` Randy Dunlap
2014-10-28 20:29 ` Randy Dunlap
2014-10-28 20:29 ` Randy Dunlap
2014-10-29 3:04 ` Michael Ellerman
2014-10-29 3:04 ` Michael Ellerman
2014-10-29 3:04 ` Michael Ellerman
2014-10-29 7:54 ` Jani Nikula [this message]
2014-10-29 7:54 ` Jani Nikula
2014-10-29 7:54 ` Jani Nikula
2014-10-29 7:54 ` Jani Nikula
2014-10-29 8:27 ` Michael Ellerman
2014-10-29 8:27 ` Michael Ellerman
2014-10-29 8:27 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tx2njooz.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=cooloney@gmail.com \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=dsd@laptop.org \
--cc=dvhart@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=jfrederich@gmail.com \
--cc=jg1.han@samsung.com \
--cc=jon.nettleton@gmail.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=plagnioj@jcrosoft.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.