* [PATCH 1/5 v2] drivers/gpio/gpio-omap.c: convert comma to semicolon
@ 2013-08-13 7:16 ` Julia Lawall
0 siblings, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2013-08-13 7:16 UTC (permalink / raw)
To: Santosh Shilimkar
Cc: kernel-janitors, Kevin Hilman, Linus Walleij, linux-omap,
linux-gpio, linux-kernel
From: Julia Lawall <Julia.Lawall@lip6.fr>
Replace a comma between expression statements by a semicolon. This changes
the semantics of the code, but given the current indentation appears to be
what is intended.
A simplified version of the semantic patch that performs this
transformation is as follows: (http://coccinelle.lip6.fr/)
// <smpl>
@r@
expression e1,e2,e;
type T;
identifier i;
@@
e1
-,
+;
e2;
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
Not tested. The first version did a different transformation to avoid
changing the semantics. This one leaves the layout as it is, but changes
the semantics.
drivers/gpio/gpio-omap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index dfeb3a3..9f19ec9 100644
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -1030,7 +1030,7 @@ omap_mpuio_alloc_gc(struct gpio_bank *bank, unsigned int irq_start,
ct->chip.irq_set_type = gpio_irq_type;
if (bank->regs->wkup_en)
- ct->chip.irq_set_wake = gpio_wake_enable,
+ ct->chip.irq_set_wake = gpio_wake_enable;
ct->regs.mask = OMAP_MPUIO_GPIO_INT / bank->stride;
irq_setup_generic_chip(gc, IRQ_MSK(num), IRQ_GC_INIT_MASK_CACHE,
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 1/5 v2] drivers/gpio/gpio-omap.c: convert comma to semicolon
@ 2013-08-13 7:16 ` Julia Lawall
0 siblings, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2013-08-13 7:16 UTC (permalink / raw)
To: Santosh Shilimkar
Cc: kernel-janitors, Kevin Hilman, Linus Walleij, linux-omap,
linux-gpio, linux-kernel
From: Julia Lawall <Julia.Lawall@lip6.fr>
Replace a comma between expression statements by a semicolon. This changes
the semantics of the code, but given the current indentation appears to be
what is intended.
A simplified version of the semantic patch that performs this
transformation is as follows: (http://coccinelle.lip6.fr/)
// <smpl>
@r@
expression e1,e2,e;
type T;
identifier i;
@@
e1
-,
+;
e2;
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
Not tested. The first version did a different transformation to avoid
changing the semantics. This one leaves the layout as it is, but changes
the semantics.
drivers/gpio/gpio-omap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index dfeb3a3..9f19ec9 100644
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -1030,7 +1030,7 @@ omap_mpuio_alloc_gc(struct gpio_bank *bank, unsigned int irq_start,
ct->chip.irq_set_type = gpio_irq_type;
if (bank->regs->wkup_en)
- ct->chip.irq_set_wake = gpio_wake_enable,
+ ct->chip.irq_set_wake = gpio_wake_enable;
ct->regs.mask = OMAP_MPUIO_GPIO_INT / bank->stride;
irq_setup_generic_chip(gc, IRQ_MSK(num), IRQ_GC_INIT_MASK_CACHE,
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/5 v2] drivers/gpio/gpio-omap.c: convert comma to semicolon
2013-08-13 7:16 ` Julia Lawall
@ 2013-08-13 15:07 ` Kevin Hilman
-1 siblings, 0 replies; 6+ messages in thread
From: Kevin Hilman @ 2013-08-13 15:07 UTC (permalink / raw)
To: Julia Lawall
Cc: Santosh Shilimkar, kernel-janitors, Linus Walleij, linux-omap,
linux-gpio, linux-kernel
Julia Lawall <Julia.Lawall@lip6.fr> writes:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Replace a comma between expression statements by a semicolon. This changes
> the semantics of the code, but given the current indentation appears to be
> what is intended.
>
> A simplified version of the semantic patch that performs this
> transformation is as follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> expression e1,e2,e;
> type T;
> identifier i;
> @@
>
> e1
> -,
> +;
> e2;
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> Not tested. The first version did a different transformation to avoid
> changing the semantics. This one leaves the layout as it is, but changes
> the semantics.
This is the right one, the previous semantics were wrong due to a
copy/paste error.
Acked-by: Kevin Hilman <khilman@linaro.org>
> drivers/gpio/gpio-omap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
> index dfeb3a3..9f19ec9 100644
> --- a/drivers/gpio/gpio-omap.c
> +++ b/drivers/gpio/gpio-omap.c
> @@ -1030,7 +1030,7 @@ omap_mpuio_alloc_gc(struct gpio_bank *bank, unsigned int irq_start,
> ct->chip.irq_set_type = gpio_irq_type;
>
> if (bank->regs->wkup_en)
> - ct->chip.irq_set_wake = gpio_wake_enable,
> + ct->chip.irq_set_wake = gpio_wake_enable;
>
> ct->regs.mask = OMAP_MPUIO_GPIO_INT / bank->stride;
> irq_setup_generic_chip(gc, IRQ_MSK(num), IRQ_GC_INIT_MASK_CACHE,
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/5 v2] drivers/gpio/gpio-omap.c: convert comma to semicolon
@ 2013-08-13 15:07 ` Kevin Hilman
0 siblings, 0 replies; 6+ messages in thread
From: Kevin Hilman @ 2013-08-13 15:07 UTC (permalink / raw)
To: Julia Lawall
Cc: Santosh Shilimkar, kernel-janitors, Linus Walleij, linux-omap,
linux-gpio, linux-kernel
Julia Lawall <Julia.Lawall@lip6.fr> writes:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Replace a comma between expression statements by a semicolon. This changes
> the semantics of the code, but given the current indentation appears to be
> what is intended.
>
> A simplified version of the semantic patch that performs this
> transformation is as follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> expression e1,e2,e;
> type T;
> identifier i;
> @@
>
> e1
> -,
> +;
> e2;
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> Not tested. The first version did a different transformation to avoid
> changing the semantics. This one leaves the layout as it is, but changes
> the semantics.
This is the right one, the previous semantics were wrong due to a
copy/paste error.
Acked-by: Kevin Hilman <khilman@linaro.org>
> drivers/gpio/gpio-omap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
> index dfeb3a3..9f19ec9 100644
> --- a/drivers/gpio/gpio-omap.c
> +++ b/drivers/gpio/gpio-omap.c
> @@ -1030,7 +1030,7 @@ omap_mpuio_alloc_gc(struct gpio_bank *bank, unsigned int irq_start,
> ct->chip.irq_set_type = gpio_irq_type;
>
> if (bank->regs->wkup_en)
> - ct->chip.irq_set_wake = gpio_wake_enable,
> + ct->chip.irq_set_wake = gpio_wake_enable;
>
> ct->regs.mask = OMAP_MPUIO_GPIO_INT / bank->stride;
> irq_setup_generic_chip(gc, IRQ_MSK(num), IRQ_GC_INIT_MASK_CACHE,
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/5 v2] drivers/gpio/gpio-omap.c: convert comma to semicolon
2013-08-13 7:16 ` Julia Lawall
@ 2013-08-16 15:15 ` Linus Walleij
-1 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2013-08-16 15:15 UTC (permalink / raw)
To: Julia Lawall
Cc: Santosh Shilimkar, kernel-janitors, Kevin Hilman, Linux-OMAP,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
On Tue, Aug 13, 2013 at 9:16 AM, Julia Lawall <Julia.Lawall@lip6.fr> wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Replace a comma between expression statements by a semicolon. This changes
> the semantics of the code, but given the current indentation appears to be
> what is intended.
Aha there is the right patch, sorry for the noise.
Patch applied with Kevin's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/5 v2] drivers/gpio/gpio-omap.c: convert comma to semicolon
@ 2013-08-16 15:15 ` Linus Walleij
0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2013-08-16 15:15 UTC (permalink / raw)
To: Julia Lawall
Cc: Santosh Shilimkar, kernel-janitors, Kevin Hilman, Linux-OMAP,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
On Tue, Aug 13, 2013 at 9:16 AM, Julia Lawall <Julia.Lawall@lip6.fr> wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Replace a comma between expression statements by a semicolon. This changes
> the semantics of the code, but given the current indentation appears to be
> what is intended.
Aha there is the right patch, sorry for the noise.
Patch applied with Kevin's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-08-16 15:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-13 7:16 [PATCH 1/5 v2] drivers/gpio/gpio-omap.c: convert comma to semicolon Julia Lawall
2013-08-13 7:16 ` Julia Lawall
2013-08-13 15:07 ` Kevin Hilman
2013-08-13 15:07 ` Kevin Hilman
2013-08-16 15:15 ` Linus Walleij
2013-08-16 15:15 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.