From: ebiederm@xmission.com (Eric W. Biederman)
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Vlad Yasevich <vyasevich@gmail.com>,
Sridhar Samudrala <sri@us.ibm.com>,
"David S. Miller" <davem@davemloft.net>,
linux-sctp@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] sctp: fix bogus if statement in sctp_auth_recv_cid()
Date: Thu, 16 Aug 2012 18:23:35 +0000 [thread overview]
Message-ID: <87txw266hk.fsf@xmission.com> (raw)
In-Reply-To: <20120816131618.GA23279@elgon.mountain> (Dan Carpenter's message of "Thu, 16 Aug 2012 16:16:19 +0300")
Dan Carpenter <dan.carpenter@oracle.com> writes:
> There is an extra semi-colon here, so we always return 0 instead of
> calling __sctp_auth_cid().
Doh.
Reviewed-by: "Eric W. Biederman" <ebiederm@xmission.com>
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Only needed for linux-next.
>
> diff --git a/net/sctp/auth.c b/net/sctp/auth.c
> index aaa6c12..159b9bc 100644
> --- a/net/sctp/auth.c
> +++ b/net/sctp/auth.c
> @@ -695,7 +695,7 @@ int sctp_auth_recv_cid(sctp_cid_t chunk, const struct sctp_association *asoc)
> return 0;
>
> net = sock_net(asoc->base.sk);
> - if (!net->sctp.auth_enable);
> + if (!net->sctp.auth_enable)
> return 0;
>
> return __sctp_auth_cid(chunk,
WARNING: multiple messages have this Message-ID (diff)
From: ebiederm@xmission.com (Eric W. Biederman)
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Vlad Yasevich <vyasevich@gmail.com>,
Sridhar Samudrala <sri@us.ibm.com>,
"David S. Miller" <davem@davemloft.net>,
linux-sctp@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] sctp: fix bogus if statement in sctp_auth_recv_cid()
Date: Thu, 16 Aug 2012 11:23:35 -0700 [thread overview]
Message-ID: <87txw266hk.fsf@xmission.com> (raw)
In-Reply-To: <20120816131618.GA23279@elgon.mountain> (Dan Carpenter's message of "Thu, 16 Aug 2012 16:16:19 +0300")
Dan Carpenter <dan.carpenter@oracle.com> writes:
> There is an extra semi-colon here, so we always return 0 instead of
> calling __sctp_auth_cid().
Doh.
Reviewed-by: "Eric W. Biederman" <ebiederm@xmission.com>
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Only needed for linux-next.
>
> diff --git a/net/sctp/auth.c b/net/sctp/auth.c
> index aaa6c12..159b9bc 100644
> --- a/net/sctp/auth.c
> +++ b/net/sctp/auth.c
> @@ -695,7 +695,7 @@ int sctp_auth_recv_cid(sctp_cid_t chunk, const struct sctp_association *asoc)
> return 0;
>
> net = sock_net(asoc->base.sk);
> - if (!net->sctp.auth_enable);
> + if (!net->sctp.auth_enable)
> return 0;
>
> return __sctp_auth_cid(chunk,
next prev parent reply other threads:[~2012-08-16 18:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 13:16 [patch] sctp: fix bogus if statement in sctp_auth_recv_cid() Dan Carpenter
2012-08-16 13:16 ` Dan Carpenter
2012-08-16 18:23 ` Eric W. Biederman [this message]
2012-08-16 18:23 ` Eric W. Biederman
2012-08-16 20:37 ` David Miller
2012-08-16 20:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txw266hk.fsf@xmission.com \
--to=ebiederm@xmission.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sri@us.ibm.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.