* [patch] sctp: fix bogus if statement in sctp_auth_recv_cid()
@ 2012-08-16 13:16 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2012-08-16 13:16 UTC (permalink / raw)
To: Eric W. Biederman
Cc: Vlad Yasevich, Sridhar Samudrala, David S. Miller, linux-sctp,
netdev, kernel-janitors
There is an extra semi-colon here, so we always return 0 instead of
calling __sctp_auth_cid().
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Only needed for linux-next.
diff --git a/net/sctp/auth.c b/net/sctp/auth.c
index aaa6c12..159b9bc 100644
--- a/net/sctp/auth.c
+++ b/net/sctp/auth.c
@@ -695,7 +695,7 @@ int sctp_auth_recv_cid(sctp_cid_t chunk, const struct sctp_association *asoc)
return 0;
net = sock_net(asoc->base.sk);
- if (!net->sctp.auth_enable);
+ if (!net->sctp.auth_enable)
return 0;
return __sctp_auth_cid(chunk,
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [patch] sctp: fix bogus if statement in sctp_auth_recv_cid()
@ 2012-08-16 13:16 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2012-08-16 13:16 UTC (permalink / raw)
To: Eric W. Biederman
Cc: Vlad Yasevich, Sridhar Samudrala, David S. Miller, linux-sctp,
netdev, kernel-janitors
There is an extra semi-colon here, so we always return 0 instead of
calling __sctp_auth_cid().
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Only needed for linux-next.
diff --git a/net/sctp/auth.c b/net/sctp/auth.c
index aaa6c12..159b9bc 100644
--- a/net/sctp/auth.c
+++ b/net/sctp/auth.c
@@ -695,7 +695,7 @@ int sctp_auth_recv_cid(sctp_cid_t chunk, const struct sctp_association *asoc)
return 0;
net = sock_net(asoc->base.sk);
- if (!net->sctp.auth_enable);
+ if (!net->sctp.auth_enable)
return 0;
return __sctp_auth_cid(chunk,
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [patch] sctp: fix bogus if statement in sctp_auth_recv_cid()
2012-08-16 13:16 ` Dan Carpenter
@ 2012-08-16 18:23 ` Eric W. Biederman
-1 siblings, 0 replies; 6+ messages in thread
From: Eric W. Biederman @ 2012-08-16 18:23 UTC (permalink / raw)
To: Dan Carpenter
Cc: Vlad Yasevich, Sridhar Samudrala, David S. Miller, linux-sctp,
netdev, kernel-janitors
Dan Carpenter <dan.carpenter@oracle.com> writes:
> There is an extra semi-colon here, so we always return 0 instead of
> calling __sctp_auth_cid().
Doh.
Reviewed-by: "Eric W. Biederman" <ebiederm@xmission.com>
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Only needed for linux-next.
>
> diff --git a/net/sctp/auth.c b/net/sctp/auth.c
> index aaa6c12..159b9bc 100644
> --- a/net/sctp/auth.c
> +++ b/net/sctp/auth.c
> @@ -695,7 +695,7 @@ int sctp_auth_recv_cid(sctp_cid_t chunk, const struct sctp_association *asoc)
> return 0;
>
> net = sock_net(asoc->base.sk);
> - if (!net->sctp.auth_enable);
> + if (!net->sctp.auth_enable)
> return 0;
>
> return __sctp_auth_cid(chunk,
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] sctp: fix bogus if statement in sctp_auth_recv_cid()
@ 2012-08-16 18:23 ` Eric W. Biederman
0 siblings, 0 replies; 6+ messages in thread
From: Eric W. Biederman @ 2012-08-16 18:23 UTC (permalink / raw)
To: Dan Carpenter
Cc: Vlad Yasevich, Sridhar Samudrala, David S. Miller, linux-sctp,
netdev, kernel-janitors
Dan Carpenter <dan.carpenter@oracle.com> writes:
> There is an extra semi-colon here, so we always return 0 instead of
> calling __sctp_auth_cid().
Doh.
Reviewed-by: "Eric W. Biederman" <ebiederm@xmission.com>
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Only needed for linux-next.
>
> diff --git a/net/sctp/auth.c b/net/sctp/auth.c
> index aaa6c12..159b9bc 100644
> --- a/net/sctp/auth.c
> +++ b/net/sctp/auth.c
> @@ -695,7 +695,7 @@ int sctp_auth_recv_cid(sctp_cid_t chunk, const struct sctp_association *asoc)
> return 0;
>
> net = sock_net(asoc->base.sk);
> - if (!net->sctp.auth_enable);
> + if (!net->sctp.auth_enable)
> return 0;
>
> return __sctp_auth_cid(chunk,
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] sctp: fix bogus if statement in sctp_auth_recv_cid()
2012-08-16 18:23 ` Eric W. Biederman
@ 2012-08-16 20:37 ` David Miller
-1 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2012-08-16 20:37 UTC (permalink / raw)
To: ebiederm; +Cc: dan.carpenter, vyasevich, sri, linux-sctp, netdev,
kernel-janitors
From: ebiederm@xmission.com (Eric W. Biederman)
Date: Thu, 16 Aug 2012 11:23:35 -0700
> Dan Carpenter <dan.carpenter@oracle.com> writes:
>
>> There is an extra semi-colon here, so we always return 0 instead of
>> calling __sctp_auth_cid().
>
> Doh.
>
> Reviewed-by: "Eric W. Biederman" <ebiederm@xmission.com>
Applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] sctp: fix bogus if statement in sctp_auth_recv_cid()
@ 2012-08-16 20:37 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2012-08-16 20:37 UTC (permalink / raw)
To: ebiederm; +Cc: dan.carpenter, vyasevich, sri, linux-sctp, netdev,
kernel-janitors
From: ebiederm@xmission.com (Eric W. Biederman)
Date: Thu, 16 Aug 2012 11:23:35 -0700
> Dan Carpenter <dan.carpenter@oracle.com> writes:
>
>> There is an extra semi-colon here, so we always return 0 instead of
>> calling __sctp_auth_cid().
>
> Doh.
>
> Reviewed-by: "Eric W. Biederman" <ebiederm@xmission.com>
Applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-08-16 20:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-16 13:16 [patch] sctp: fix bogus if statement in sctp_auth_recv_cid() Dan Carpenter
2012-08-16 13:16 ` Dan Carpenter
2012-08-16 18:23 ` Eric W. Biederman
2012-08-16 18:23 ` Eric W. Biederman
2012-08-16 20:37 ` David Miller
2012-08-16 20:37 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.