Re: [PATCH v3 01/17] riscv: Introduce instruction table generation

[Nam Cao <namcao@linutronix.de>]

Charlie Jenkins <thecharlesjenkins@gmail.com> writes:
> +        # Replace all . with _
> +        formatted_inst_name=$name
> +        while [ ! ${formatted_inst_name##*.*} ]; do
> +            prefix=${formatted_inst_name%.*}
> +            suffix=${formatted_inst_name##*.}
> +            contains_dot=${formatted_inst_name##*.*}

Isn't contains_dot always empty, because we only get here if
formatted_inst_name has a dot?

> +        # Instruction only appears in one base
> +        only_base=
> +        if [ "${base}" != "${base%32}" ]; then

Does
           if [ "${base}" = "32" ]; then

work?

Nam