From: Li Chen <me@linux.beauty>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Li Chen" <lchen@ambarella.com>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Christian König" <christian.koenig@amd.com>,
"open list" <linux-kernel@vger.kernel.org>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
"moderated list:ARM/Ambarella SoC support"
<linux-arm-kernel@lists.infradead.org>,
"open list:DMA BUFFER SHARING FRAMEWORK"
<linux-media@vger.kernel.org>,
"open list:DMA BUFFER SHARING FRAMEWORK"
<dri-devel@lists.freedesktop.org>,
"moderated list:DMA BUFFER SHARING FRAMEWORK"
<linaro-mm-sig@lists.linaro.org>
Subject: Re: [PATCH 10/15] serial: ambarella: add support for Ambarella uart_port
Date: Wed, 25 Jan 2023 18:01:25 +0800 [thread overview]
Message-ID: <87v8kvgcga.wl-me@linux.beauty> (raw)
In-Reply-To: <Y85YncUCtRyVnpvt@kroah.com>
On Mon, 23 Jan 2023 17:51:25 +0800,
Hi Greg,
Sorry for my late reply.
Greg Kroah-Hartman wrote:
>
> On Mon, Jan 23, 2023 at 03:32:25PM +0800, Li Chen wrote:
> > This driver add support for Ambarella's uart, which
> > can be used for console and etc.
> >
> > Signed-off-by: Li Chen <lchen@ambarella.com>
> > Change-Id: Ie68af7ad2187e21853e58d52cd97fd7145303730
> > ---
> > MAINTAINERS | 1 +
> > drivers/tty/serial/Kconfig | 16 +
> > drivers/tty/serial/Makefile | 1 +
> > drivers/tty/serial/ambarella_uart.c | 1581 +++++++++++++++++++++++++++
> > drivers/tty/serial/ambarella_uart.h | 120 ++
>
> Why do you need a .h file for a single .c file? They should all be in
> one file please.
Ok, I will combine them into single source file.
> Also, no change-id, you know this...
>
> thanks,
>
> greg k-h
Regards,
Li
WARNING: multiple messages have this Message-ID (diff)
From: Li Chen <me@linux.beauty>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Li Chen" <lchen@ambarella.com>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Christian König" <christian.koenig@amd.com>,
"open list" <linux-kernel@vger.kernel.org>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
"moderated list:ARM/Ambarella SoC support"
<linux-arm-kernel@lists.infradead.org>,
"open list:DMA BUFFER SHARING FRAMEWORK"
<linux-media@vger.kernel.org>,
"open list:DMA BUFFER SHARING FRAMEWORK"
<dri-devel@lists.freedesktop.org>,
"moderated list:DMA BUFFER SHARING FRAMEWORK"
<linaro-mm-sig@lists.linaro.org>
Subject: Re: [PATCH 10/15] serial: ambarella: add support for Ambarella uart_port
Date: Wed, 25 Jan 2023 18:01:25 +0800 [thread overview]
Message-ID: <87v8kvgcga.wl-me@linux.beauty> (raw)
In-Reply-To: <Y85YncUCtRyVnpvt@kroah.com>
On Mon, 23 Jan 2023 17:51:25 +0800,
Hi Greg,
Sorry for my late reply.
Greg Kroah-Hartman wrote:
>
> On Mon, Jan 23, 2023 at 03:32:25PM +0800, Li Chen wrote:
> > This driver add support for Ambarella's uart, which
> > can be used for console and etc.
> >
> > Signed-off-by: Li Chen <lchen@ambarella.com>
> > Change-Id: Ie68af7ad2187e21853e58d52cd97fd7145303730
> > ---
> > MAINTAINERS | 1 +
> > drivers/tty/serial/Kconfig | 16 +
> > drivers/tty/serial/Makefile | 1 +
> > drivers/tty/serial/ambarella_uart.c | 1581 +++++++++++++++++++++++++++
> > drivers/tty/serial/ambarella_uart.h | 120 ++
>
> Why do you need a .h file for a single .c file? They should all be in
> one file please.
Ok, I will combine them into single source file.
> Also, no change-id, you know this...
>
> thanks,
>
> greg k-h
Regards,
Li
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Li Chen <me@linux.beauty>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "open list" <linux-kernel@vger.kernel.org>,
"open list:DMA BUFFER SHARING FRAMEWORK"
<dri-devel@lists.freedesktop.org>,
"Christian König" <christian.koenig@amd.com>,
"moderated list:DMA BUFFER SHARING FRAMEWORK"
<linaro-mm-sig@lists.linaro.org>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
"Li Chen" <lchen@ambarella.com>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"moderated list:ARM/Ambarella SoC support"
<linux-arm-kernel@lists.infradead.org>,
"open list:DMA BUFFER SHARING FRAMEWORK"
<linux-media@vger.kernel.org>
Subject: Re: [PATCH 10/15] serial: ambarella: add support for Ambarella uart_port
Date: Wed, 25 Jan 2023 18:01:25 +0800 [thread overview]
Message-ID: <87v8kvgcga.wl-me@linux.beauty> (raw)
In-Reply-To: <Y85YncUCtRyVnpvt@kroah.com>
On Mon, 23 Jan 2023 17:51:25 +0800,
Hi Greg,
Sorry for my late reply.
Greg Kroah-Hartman wrote:
>
> On Mon, Jan 23, 2023 at 03:32:25PM +0800, Li Chen wrote:
> > This driver add support for Ambarella's uart, which
> > can be used for console and etc.
> >
> > Signed-off-by: Li Chen <lchen@ambarella.com>
> > Change-Id: Ie68af7ad2187e21853e58d52cd97fd7145303730
> > ---
> > MAINTAINERS | 1 +
> > drivers/tty/serial/Kconfig | 16 +
> > drivers/tty/serial/Makefile | 1 +
> > drivers/tty/serial/ambarella_uart.c | 1581 +++++++++++++++++++++++++++
> > drivers/tty/serial/ambarella_uart.h | 120 ++
>
> Why do you need a .h file for a single .c file? They should all be in
> one file please.
Ok, I will combine them into single source file.
> Also, no change-id, you know this...
>
> thanks,
>
> greg k-h
Regards,
Li
next prev parent reply other threads:[~2023-01-25 10:02 UTC|newest]
Thread overview: 113+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 7:32 [PATCH 00/15] Ambarella S6LM SoC bring-up Li Chen
2023-01-23 7:32 ` Li Chen
2023-01-23 7:32 ` Li Chen
2023-01-23 7:32 ` [PATCH 02/15] dt-bindings: vendor-prefixes: add Ambarella prefix Li Chen
2023-01-23 8:02 ` Krzysztof Kozlowski
2023-01-23 7:32 ` [PATCH 05/15] arm64: Kconfig: Introduce CONFIG_ARCH_AMBARELLA Li Chen
2023-01-23 7:32 ` Li Chen
2023-01-23 8:32 ` Arnd Bergmann
2023-01-23 8:32 ` Arnd Bergmann
2023-01-23 7:32 ` [PATCH 10/15] serial: ambarella: add support for Ambarella uart_port Li Chen
2023-01-23 9:50 ` Greg Kroah-Hartman
2023-01-23 9:50 ` Greg Kroah-Hartman
2023-01-23 9:50 ` Greg Kroah-Hartman
2023-01-23 9:51 ` Greg Kroah-Hartman
2023-01-23 9:51 ` Greg Kroah-Hartman
2023-01-23 9:51 ` Greg Kroah-Hartman
2023-01-25 10:01 ` Li Chen [this message]
2023-01-25 10:01 ` Li Chen
2023-01-25 10:01 ` Li Chen
[not found] ` <20230123073305.149940-4-lchen@ambarella.com>
2023-01-23 8:03 ` [PATCH 03/15] dt-bindings: arm: ambarella: Add binding for Ambarella ARM platforms Krzysztof Kozlowski
2023-01-23 8:03 ` Krzysztof Kozlowski
2023-01-23 13:58 ` Li Chen
2023-01-23 13:58 ` Li Chen
[not found] ` <20230123073305.149940-5-lchen@ambarella.com>
2023-01-23 8:07 ` [PATCH 04/15] dt-bindings: arm: add support for Ambarella SoC Krzysztof Kozlowski
2023-01-23 8:07 ` Krzysztof Kozlowski
2023-01-23 15:09 ` Li Chen
2023-01-23 15:09 ` Li Chen
2023-01-23 15:52 ` Krzysztof Kozlowski
2023-01-23 15:52 ` Krzysztof Kozlowski
[not found] ` <20230123073305.149940-8-lchen@ambarella.com>
2023-01-23 8:11 ` [PATCH 07/15] dt-bindings: clock: Add Ambarella clock bindings Krzysztof Kozlowski
2023-01-23 8:11 ` Krzysztof Kozlowski
2023-01-25 9:28 ` Li Chen
2023-01-25 9:28 ` Li Chen
2023-01-25 9:55 ` Krzysztof Kozlowski
2023-01-25 9:55 ` Krzysztof Kozlowski
2023-01-25 12:06 ` Li Chen
2023-01-25 12:06 ` Li Chen
2023-01-25 12:14 ` Krzysztof Kozlowski
2023-01-25 12:14 ` Krzysztof Kozlowski
2023-01-25 13:40 ` Li Chen
2023-01-25 13:40 ` Li Chen
2023-01-26 11:29 ` Krzysztof Kozlowski
2023-01-26 11:29 ` Krzysztof Kozlowski
2023-01-27 14:48 ` Li Chen
2023-01-27 14:48 ` Li Chen
2023-01-27 15:08 ` Krzysztof Kozlowski
2023-01-27 15:08 ` Krzysztof Kozlowski
2023-01-28 9:42 ` Li Chen
2023-01-28 9:42 ` Li Chen
2023-01-28 10:08 ` Krzysztof Kozlowski
2023-01-28 10:08 ` Krzysztof Kozlowski
2023-01-28 10:11 ` Li Chen
2023-01-28 10:11 ` Li Chen
2023-02-06 11:28 ` Li Chen
2023-02-06 11:28 ` Li Chen
2023-02-06 13:41 ` Krzysztof Kozlowski
2023-02-06 13:41 ` Krzysztof Kozlowski
2023-02-06 14:57 ` Li Chen
2023-02-06 14:57 ` Li Chen
2023-02-08 10:27 ` Krzysztof Kozlowski
2023-02-08 10:27 ` Krzysztof Kozlowski
2023-01-27 15:11 ` Krzysztof Kozlowski
2023-01-27 15:11 ` Krzysztof Kozlowski
2023-01-28 9:45 ` Li Chen
2023-01-28 9:45 ` Li Chen
[not found] ` <20230123073305.149940-10-lchen@ambarella.com>
2023-01-23 8:11 ` [PATCH 09/15] dt-bindings: serial: add support for Ambarella Krzysztof Kozlowski
2023-01-23 8:11 ` Krzysztof Kozlowski
2023-01-25 9:54 ` Li Chen
2023-01-25 9:54 ` Li Chen
2023-01-25 9:56 ` Krzysztof Kozlowski
2023-01-25 9:56 ` Krzysztof Kozlowski
2023-01-28 9:22 ` Li Chen
2023-01-28 9:22 ` Li Chen
[not found] ` <20230123073305.149940-12-lchen@ambarella.com>
2023-01-23 8:13 ` [PATCH 11/15] dt-bindings: mtd: Add binding " Krzysztof Kozlowski
2023-01-23 8:13 ` Krzysztof Kozlowski
2023-01-23 8:13 ` Krzysztof Kozlowski
[not found] ` <20230123073305.149940-16-lchen@ambarella.com>
2023-01-23 8:20 ` [PATCH 15/15] arm64: dts: ambarella: introduce Ambarella s6lm SoC Krzysztof Kozlowski
2023-01-23 8:20 ` Krzysztof Kozlowski
[not found] ` <20230123073305.149940-13-lchen@ambarella.com>
2023-01-23 8:32 ` [PATCH 12/15] mtd: nand: add Ambarella nand support Miquel Raynal
2023-01-23 8:32 ` Miquel Raynal
2023-01-23 8:32 ` Miquel Raynal
2023-01-23 8:39 ` [PATCH 00/15] Ambarella S6LM SoC bring-up Arnd Bergmann
2023-01-23 8:39 ` Arnd Bergmann
2023-01-23 8:39 ` Arnd Bergmann
2023-01-24 2:08 ` Bagas Sanjaya
2023-01-24 2:08 ` Bagas Sanjaya
2023-01-24 2:08 ` Bagas Sanjaya
2023-01-25 2:24 ` Li Chen
2023-01-25 2:24 ` Li Chen
[not found] ` <20230123073305.149940-7-lchen@ambarella.com>
2023-01-23 8:29 ` [PATCH 06/15] soc: add Ambarella driver Arnd Bergmann
2023-01-23 8:29 ` Arnd Bergmann
2023-01-24 7:58 ` Li Chen
2023-01-24 7:58 ` Li Chen
2023-01-24 15:46 ` Arnd Bergmann
2023-01-24 15:46 ` Arnd Bergmann
2023-01-29 7:21 ` Li Chen
2023-01-29 7:21 ` Li Chen
2023-01-23 11:48 ` Conor.Dooley
2023-01-23 11:48 ` Conor.Dooley
2023-01-24 8:27 ` Li Chen
2023-01-24 8:27 ` Li Chen
2023-01-24 8:46 ` Conor.Dooley
2023-01-24 8:46 ` Conor.Dooley
2023-01-24 14:24 ` Li Chen
2023-01-24 14:24 ` Li Chen
[not found] ` <20230123073305.149940-2-lchen@ambarella.com>
2023-01-23 11:52 ` [PATCH 01/15] debugfs: allow to use regmap for print regs Greg Kroah-Hartman
2023-01-23 13:47 ` Li Chen
[not found] ` <20230123073305.149940-14-lchen@ambarella.com>
2023-01-23 8:13 ` [PATCH 13/15] dt-bindings: pinctrl: add support for Ambarella Krzysztof Kozlowski
2023-01-23 8:13 ` Krzysztof Kozlowski
2023-01-23 12:32 ` Linus Walleij
2023-01-23 12:32 ` Linus Walleij
2023-01-28 10:05 ` Li Chen
2023-01-28 10:05 ` Li Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8kvgcga.wl-me@linux.beauty \
--to=me@linux.beauty \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=lchen@ambarella.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.