From: Michael Ellerman <mpe@ellerman.id.au>
To: Masahiro Yamada <masahiroy@kernel.org>,
Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
linux-kernel@vger.kernel.org
Cc: Masahiro Yamada <masahiroy@kernel.org>,
Will Deacon <will@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Palmer Dabbelt <palmer@dabbelt.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Guo Ren <guoren@kernel.org>,
linux-mips@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org,
Albert Ou <aou@eecs.berkeley.edu>,
linuxppc-dev@lists.ozlabs.org,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
Paul Walmsley <paul.walmsley@sifive.com>
Subject: Re: [PATCH v2] arch: vdso: remove if-conditionals of $(c-gettimeofday-y)
Date: Mon, 02 Aug 2021 12:36:08 +1000 [thread overview]
Message-ID: <87v94ozi7b.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <20210731060020.12913-1-masahiroy@kernel.org>
Masahiro Yamada <masahiroy@kernel.org> writes:
> arm, arm64, csky, mips, powerpc always select GENERIC_GETTIMEOFDAY,
> hence $(gettimeofday-y) never becomes empty.
>
> riscv conditionally selects GENERIC_GETTIMEOFDAY when MMU=y && 64BIT=y,
> but arch/riscv/kernel/vdso/vgettimeofday.o is built only under that
> condition. So, you can always define CFLAGS_vgettimeofday.o
>
> Remove all the meaningless conditionals.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> Changes in v2:
> - Fix csky as well
>
> arch/arm/vdso/Makefile | 4 ----
> arch/arm64/kernel/vdso/Makefile | 5 +----
> arch/arm64/kernel/vdso32/Makefile | 3 ---
> arch/csky/kernel/vdso/Makefile | 4 +---
> arch/mips/vdso/Makefile | 2 --
> arch/powerpc/kernel/vdso32/Makefile | 14 ++++++--------
> arch/powerpc/kernel/vdso64/Makefile | 14 ++++++--------
I noticed this the other day and was puzzled why we still needed
the conditional, thanks for cleaning it up.
Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
cheers
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: Masahiro Yamada <masahiroy@kernel.org>,
Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
linux-kernel@vger.kernel.org
Cc: Masahiro Yamada <masahiroy@kernel.org>,
Will Deacon <will@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Palmer Dabbelt <palmer@dabbelt.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Guo Ren <guoren@kernel.org>,
linux-mips@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org,
Albert Ou <aou@eecs.berkeley.edu>,
linuxppc-dev@lists.ozlabs.org,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
Paul Walmsley <paul.walmsley@sifive.com>
Subject: Re: [PATCH v2] arch: vdso: remove if-conditionals of $(c-gettimeofday-y)
Date: Mon, 02 Aug 2021 12:36:08 +1000 [thread overview]
Message-ID: <87v94ozi7b.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <20210731060020.12913-1-masahiroy@kernel.org>
Masahiro Yamada <masahiroy@kernel.org> writes:
> arm, arm64, csky, mips, powerpc always select GENERIC_GETTIMEOFDAY,
> hence $(gettimeofday-y) never becomes empty.
>
> riscv conditionally selects GENERIC_GETTIMEOFDAY when MMU=y && 64BIT=y,
> but arch/riscv/kernel/vdso/vgettimeofday.o is built only under that
> condition. So, you can always define CFLAGS_vgettimeofday.o
>
> Remove all the meaningless conditionals.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> Changes in v2:
> - Fix csky as well
>
> arch/arm/vdso/Makefile | 4 ----
> arch/arm64/kernel/vdso/Makefile | 5 +----
> arch/arm64/kernel/vdso32/Makefile | 3 ---
> arch/csky/kernel/vdso/Makefile | 4 +---
> arch/mips/vdso/Makefile | 2 --
> arch/powerpc/kernel/vdso32/Makefile | 14 ++++++--------
> arch/powerpc/kernel/vdso64/Makefile | 14 ++++++--------
I noticed this the other day and was puzzled why we still needed
the conditional, thanks for cleaning it up.
Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
cheers
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: Masahiro Yamada <masahiroy@kernel.org>,
Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
linux-kernel@vger.kernel.org
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Masahiro Yamada <masahiroy@kernel.org>,
linuxppc-dev@lists.ozlabs.org, linux-mips@vger.kernel.org,
linux-csky@vger.kernel.org, Russell King <linux@armlinux.org.uk>,
Albert Ou <aou@eecs.berkeley.edu>,
Palmer Dabbelt <palmer@dabbelt.com>,
linux-arm-kernel@lists.infradead.org,
Paul Walmsley <paul.walmsley@sifive.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Guo Ren <guoren@kernel.org>,
linux-riscv@lists.infradead.org, Will Deacon <will@kernel.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH v2] arch: vdso: remove if-conditionals of $(c-gettimeofday-y)
Date: Mon, 02 Aug 2021 12:36:08 +1000 [thread overview]
Message-ID: <87v94ozi7b.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <20210731060020.12913-1-masahiroy@kernel.org>
Masahiro Yamada <masahiroy@kernel.org> writes:
> arm, arm64, csky, mips, powerpc always select GENERIC_GETTIMEOFDAY,
> hence $(gettimeofday-y) never becomes empty.
>
> riscv conditionally selects GENERIC_GETTIMEOFDAY when MMU=y && 64BIT=y,
> but arch/riscv/kernel/vdso/vgettimeofday.o is built only under that
> condition. So, you can always define CFLAGS_vgettimeofday.o
>
> Remove all the meaningless conditionals.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> Changes in v2:
> - Fix csky as well
>
> arch/arm/vdso/Makefile | 4 ----
> arch/arm64/kernel/vdso/Makefile | 5 +----
> arch/arm64/kernel/vdso32/Makefile | 3 ---
> arch/csky/kernel/vdso/Makefile | 4 +---
> arch/mips/vdso/Makefile | 2 --
> arch/powerpc/kernel/vdso32/Makefile | 14 ++++++--------
> arch/powerpc/kernel/vdso64/Makefile | 14 ++++++--------
I noticed this the other day and was puzzled why we still needed
the conditional, thanks for cleaning it up.
Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
cheers
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: Masahiro Yamada <masahiroy@kernel.org>,
Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
linux-kernel@vger.kernel.org
Cc: Masahiro Yamada <masahiroy@kernel.org>,
Will Deacon <will@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Palmer Dabbelt <palmer@dabbelt.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Guo Ren <guoren@kernel.org>,
linux-mips@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org,
Albert Ou <aou@eecs.berkeley.edu>,
linuxppc-dev@lists.ozlabs.org,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
Paul Walmsley <paul.walmsley@sifive.com>
Subject: Re: [PATCH v2] arch: vdso: remove if-conditionals of $(c-gettimeofday-y)
Date: Mon, 02 Aug 2021 12:36:08 +1000 [thread overview]
Message-ID: <87v94ozi7b.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <20210731060020.12913-1-masahiroy@kernel.org>
Masahiro Yamada <masahiroy@kernel.org> writes:
> arm, arm64, csky, mips, powerpc always select GENERIC_GETTIMEOFDAY,
> hence $(gettimeofday-y) never becomes empty.
>
> riscv conditionally selects GENERIC_GETTIMEOFDAY when MMU=y && 64BIT=y,
> but arch/riscv/kernel/vdso/vgettimeofday.o is built only under that
> condition. So, you can always define CFLAGS_vgettimeofday.o
>
> Remove all the meaningless conditionals.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> Changes in v2:
> - Fix csky as well
>
> arch/arm/vdso/Makefile | 4 ----
> arch/arm64/kernel/vdso/Makefile | 5 +----
> arch/arm64/kernel/vdso32/Makefile | 3 ---
> arch/csky/kernel/vdso/Makefile | 4 +---
> arch/mips/vdso/Makefile | 2 --
> arch/powerpc/kernel/vdso32/Makefile | 14 ++++++--------
> arch/powerpc/kernel/vdso64/Makefile | 14 ++++++--------
I noticed this the other day and was puzzled why we still needed
the conditional, thanks for cleaning it up.
Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
cheers
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-02 2:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-31 6:00 [PATCH v2] arch: vdso: remove if-conditionals of $(c-gettimeofday-y) Masahiro Yamada
2021-07-31 6:00 ` Masahiro Yamada
2021-07-31 6:00 ` Masahiro Yamada
2021-07-31 6:00 ` Masahiro Yamada
2021-08-02 2:36 ` Michael Ellerman [this message]
2021-08-02 2:36 ` Michael Ellerman
2021-08-02 2:36 ` Michael Ellerman
2021-08-02 2:36 ` Michael Ellerman
2021-08-03 16:19 ` Catalin Marinas
2021-08-03 16:19 ` Catalin Marinas
2021-08-03 16:19 ` Catalin Marinas
2021-08-03 16:19 ` Catalin Marinas
2021-08-05 9:12 ` Thomas Bogendoerfer
2021-08-05 9:12 ` Thomas Bogendoerfer
2021-08-05 9:12 ` Thomas Bogendoerfer
2021-08-05 9:12 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v94ozi7b.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=aou@eecs.berkeley.edu \
--cc=benh@kernel.crashing.org \
--cc=catalin.marinas@arm.com \
--cc=guoren@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=luto@kernel.org \
--cc=masahiroy@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=vincenzo.frascino@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.