From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
linux-kernel@vger.kernel.org, Will Deacon <will@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Catalin Marinas <catalin.marinas@arm.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Guo Ren <guoren@kernel.org>,
linux-mips@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org,
Albert Ou <aou@eecs.berkeley.edu>,
linuxppc-dev@lists.ozlabs.org,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
Paul Walmsley <paul.walmsley@sifive.com>
Subject: Re: [PATCH v2] arch: vdso: remove if-conditionals of $(c-gettimeofday-y)
Date: Thu, 5 Aug 2021 11:12:18 +0200 [thread overview]
Message-ID: <20210805091218.GD5979@alpha.franken.de> (raw)
In-Reply-To: <20210731060020.12913-1-masahiroy@kernel.org>
On Sat, Jul 31, 2021 at 03:00:20PM +0900, Masahiro Yamada wrote:
> arm, arm64, csky, mips, powerpc always select GENERIC_GETTIMEOFDAY,
> hence $(gettimeofday-y) never becomes empty.
>
> riscv conditionally selects GENERIC_GETTIMEOFDAY when MMU=y && 64BIT=y,
> but arch/riscv/kernel/vdso/vgettimeofday.o is built only under that
> condition. So, you can always define CFLAGS_vgettimeofday.o
>
> Remove all the meaningless conditionals.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> Changes in v2:
> - Fix csky as well
>
> [..]
> arch/mips/vdso/Makefile | 2 --
Acked-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
linux-kernel@vger.kernel.org, Will Deacon <will@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Catalin Marinas <catalin.marinas@arm.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Guo Ren <guoren@kernel.org>,
linux-mips@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org,
Albert Ou <aou@eecs.berkeley.edu>,
linuxppc-dev@lists.ozlabs.org,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
Paul Walmsley <paul.walmsley@sifive.com>
Subject: Re: [PATCH v2] arch: vdso: remove if-conditionals of $(c-gettimeofday-y)
Date: Thu, 5 Aug 2021 11:12:18 +0200 [thread overview]
Message-ID: <20210805091218.GD5979@alpha.franken.de> (raw)
In-Reply-To: <20210731060020.12913-1-masahiroy@kernel.org>
On Sat, Jul 31, 2021 at 03:00:20PM +0900, Masahiro Yamada wrote:
> arm, arm64, csky, mips, powerpc always select GENERIC_GETTIMEOFDAY,
> hence $(gettimeofday-y) never becomes empty.
>
> riscv conditionally selects GENERIC_GETTIMEOFDAY when MMU=y && 64BIT=y,
> but arch/riscv/kernel/vdso/vgettimeofday.o is built only under that
> condition. So, you can always define CFLAGS_vgettimeofday.o
>
> Remove all the meaningless conditionals.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> Changes in v2:
> - Fix csky as well
>
> [..]
> arch/mips/vdso/Makefile | 2 --
Acked-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Albert Ou <aou@eecs.berkeley.edu>,
Russell King <linux@armlinux.org.uk>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-csky@vger.kernel.org, linux-mips@vger.kernel.org,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
linux-arm-kernel@lists.infradead.org,
Andy Lutomirski <luto@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Guo Ren <guoren@kernel.org>, Thomas Gleixner <tglx@linutronix.de>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Will Deacon <will@kernel.org>,
linux-riscv@lists.infradead.org,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH v2] arch: vdso: remove if-conditionals of $(c-gettimeofday-y)
Date: Thu, 5 Aug 2021 11:12:18 +0200 [thread overview]
Message-ID: <20210805091218.GD5979@alpha.franken.de> (raw)
In-Reply-To: <20210731060020.12913-1-masahiroy@kernel.org>
On Sat, Jul 31, 2021 at 03:00:20PM +0900, Masahiro Yamada wrote:
> arm, arm64, csky, mips, powerpc always select GENERIC_GETTIMEOFDAY,
> hence $(gettimeofday-y) never becomes empty.
>
> riscv conditionally selects GENERIC_GETTIMEOFDAY when MMU=y && 64BIT=y,
> but arch/riscv/kernel/vdso/vgettimeofday.o is built only under that
> condition. So, you can always define CFLAGS_vgettimeofday.o
>
> Remove all the meaningless conditionals.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> Changes in v2:
> - Fix csky as well
>
> [..]
> arch/mips/vdso/Makefile | 2 --
Acked-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
linux-kernel@vger.kernel.org, Will Deacon <will@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Catalin Marinas <catalin.marinas@arm.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Guo Ren <guoren@kernel.org>,
linux-mips@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org,
Albert Ou <aou@eecs.berkeley.edu>,
linuxppc-dev@lists.ozlabs.org,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
Paul Walmsley <paul.walmsley@sifive.com>
Subject: Re: [PATCH v2] arch: vdso: remove if-conditionals of $(c-gettimeofday-y)
Date: Thu, 5 Aug 2021 11:12:18 +0200 [thread overview]
Message-ID: <20210805091218.GD5979@alpha.franken.de> (raw)
In-Reply-To: <20210731060020.12913-1-masahiroy@kernel.org>
On Sat, Jul 31, 2021 at 03:00:20PM +0900, Masahiro Yamada wrote:
> arm, arm64, csky, mips, powerpc always select GENERIC_GETTIMEOFDAY,
> hence $(gettimeofday-y) never becomes empty.
>
> riscv conditionally selects GENERIC_GETTIMEOFDAY when MMU=y && 64BIT=y,
> but arch/riscv/kernel/vdso/vgettimeofday.o is built only under that
> condition. So, you can always define CFLAGS_vgettimeofday.o
>
> Remove all the meaningless conditionals.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> Changes in v2:
> - Fix csky as well
>
> [..]
> arch/mips/vdso/Makefile | 2 --
Acked-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-05 9:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-31 6:00 [PATCH v2] arch: vdso: remove if-conditionals of $(c-gettimeofday-y) Masahiro Yamada
2021-07-31 6:00 ` Masahiro Yamada
2021-07-31 6:00 ` Masahiro Yamada
2021-07-31 6:00 ` Masahiro Yamada
2021-08-02 2:36 ` Michael Ellerman
2021-08-02 2:36 ` Michael Ellerman
2021-08-02 2:36 ` Michael Ellerman
2021-08-02 2:36 ` Michael Ellerman
2021-08-03 16:19 ` Catalin Marinas
2021-08-03 16:19 ` Catalin Marinas
2021-08-03 16:19 ` Catalin Marinas
2021-08-03 16:19 ` Catalin Marinas
2021-08-05 9:12 ` Thomas Bogendoerfer [this message]
2021-08-05 9:12 ` Thomas Bogendoerfer
2021-08-05 9:12 ` Thomas Bogendoerfer
2021-08-05 9:12 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210805091218.GD5979@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=aou@eecs.berkeley.edu \
--cc=benh@kernel.crashing.org \
--cc=catalin.marinas@arm.com \
--cc=guoren@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=luto@kernel.org \
--cc=masahiroy@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
--cc=vincenzo.frascino@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.