All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: David Airlie <airlied@linux.ie>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Mika Kahola <mika.kahola@intel.com>, Lyude <cpaul@redhat.com>
Subject: Re: [PATCH] drm: include linux/seq_file.h as needed
Date: Mon, 19 Sep 2016 16:27:41 +0300	[thread overview]
Message-ID: <87vaxsm33m.fsf@intel.com> (raw)
In-Reply-To: <20160919125218.1565529-1-arnd@arndb.de>

On Mon, 19 Sep 2016, Arnd Bergmann <arnd@arndb.de> wrote:
> The addition of the debugfs info created references to seq_puts() and
> seq_printf(), but relied on the debugfs header to be included implicitly,
> which apparently doesn't happen all the time, as seen from this randconfig
> build output:
>
> drivers/gpu/drm/drm_dp_helper.c: In function 'drm_dp_downstream_debug':
> drivers/gpu/drm/drm_dp_helper.c:552:2: error: implicit declaration of function 'seq_printf' [-Werror=implicit-function-declaration]
> drivers/gpu/drm/drm_dp_helper.c:560:3: error: implicit declaration of function 'seq_puts' [-Werror=implicit-function-declaration]
>
> Adding the extra include brings back a clean build.

Beat you to it, but no review/acks...

http://patchwork.freedesktop.org/patch/msgid/1474020396-14875-1-git-send-email-jani.nikula@intel.com

BR,
Jani.


>
> Fixes: 80209e5f2c42 ("drm: Add DP branch device info on debugfs")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/gpu/drm/drm_dp_helper.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
> index a07adf0a07db..3e6fe82c6d64 100644
> --- a/drivers/gpu/drm/drm_dp_helper.c
> +++ b/drivers/gpu/drm/drm_dp_helper.c
> @@ -27,6 +27,7 @@
>  #include <linux/errno.h>
>  #include <linux/sched.h>
>  #include <linux/i2c.h>
> +#include <linux/seq_file.h>
>  #include <drm/drm_dp_helper.h>
>  #include <drm/drmP.h>

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@intel.com>
To: Arnd Bergmann <arnd@arndb.de>, David Airlie <airlied@linux.ie>
Cc: "Arnd Bergmann" <arnd@arndb.de>,
	"Daniel Vetter" <daniel.vetter@ffwll.ch>,
	"Dave Airlie" <airlied@gmail.com>,
	"Mika Kahola" <mika.kahola@intel.com>,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	Lyude <cpaul@redhat.com>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm: include linux/seq_file.h as needed
Date: Mon, 19 Sep 2016 16:27:41 +0300	[thread overview]
Message-ID: <87vaxsm33m.fsf@intel.com> (raw)
In-Reply-To: <20160919125218.1565529-1-arnd@arndb.de>

On Mon, 19 Sep 2016, Arnd Bergmann <arnd@arndb.de> wrote:
> The addition of the debugfs info created references to seq_puts() and
> seq_printf(), but relied on the debugfs header to be included implicitly,
> which apparently doesn't happen all the time, as seen from this randconfig
> build output:
>
> drivers/gpu/drm/drm_dp_helper.c: In function 'drm_dp_downstream_debug':
> drivers/gpu/drm/drm_dp_helper.c:552:2: error: implicit declaration of function 'seq_printf' [-Werror=implicit-function-declaration]
> drivers/gpu/drm/drm_dp_helper.c:560:3: error: implicit declaration of function 'seq_puts' [-Werror=implicit-function-declaration]
>
> Adding the extra include brings back a clean build.

Beat you to it, but no review/acks...

http://patchwork.freedesktop.org/patch/msgid/1474020396-14875-1-git-send-email-jani.nikula@intel.com

BR,
Jani.


>
> Fixes: 80209e5f2c42 ("drm: Add DP branch device info on debugfs")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/gpu/drm/drm_dp_helper.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
> index a07adf0a07db..3e6fe82c6d64 100644
> --- a/drivers/gpu/drm/drm_dp_helper.c
> +++ b/drivers/gpu/drm/drm_dp_helper.c
> @@ -27,6 +27,7 @@
>  #include <linux/errno.h>
>  #include <linux/sched.h>
>  #include <linux/i2c.h>
> +#include <linux/seq_file.h>
>  #include <drm/drm_dp_helper.h>
>  #include <drm/drmP.h>

-- 
Jani Nikula, Intel Open Source Technology Center

  reply	other threads:[~2016-09-19 13:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-19 12:51 [PATCH] drm: include linux/seq_file.h as needed Arnd Bergmann
2016-09-19 12:51 ` Arnd Bergmann
2016-09-19 13:27 ` Jani Nikula [this message]
2016-09-19 13:27   ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vaxsm33m.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=airlied@linux.ie \
    --cc=arnd@arndb.de \
    --cc=cpaul@redhat.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.kahola@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.