From: "Alex Bennée" <alex.bennee@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
kvm-devel <kvm@vger.kernel.org>,
arm-mail-list <linux-arm-kernel@lists.infradead.org>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
Christoffer Dall <christoffer.dall@linaro.org>,
Marc Zyngier <marc.zyngier@arm.com>
Subject: Re: [PATCH v2 6/6] target-arm: cpu.h document why env->spsr exists
Date: Wed, 04 Mar 2015 16:27:29 +0000 [thread overview]
Message-ID: <87vbig683y.fsf@linaro.org> (raw)
In-Reply-To: <CAFEAcA9x_6jGfNTpMLYYbmEp19U7sOVjcgzCggwkwZiyCM5yug@mail.gmail.com>
Peter Maydell <peter.maydell@linaro.org> writes:
> On 4 March 2015 at 23:35, Alex Bennée <alex.bennee@linaro.org> wrote:
>> I was getting very confused about the duplication of state. Perhaps we
>> should just get rid of env->spsr and use helpers that understand the
>> banking?
>
> Doesn't seem worth changing the current working code to something
> else that's strictly less efficient... spsr is by no means the
> only banked-by-mode register, and it works just like all the others.
Fair enough. I just wanted to make it clear it was a cached value for
the benefit of TCG.
>
> -- PMM
--
Alex Bennée
WARNING: multiple messages have this Message-ID (diff)
From: alex.bennee@linaro.org (Alex Bennée)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 6/6] target-arm: cpu.h document why env->spsr exists
Date: Wed, 04 Mar 2015 16:27:29 +0000 [thread overview]
Message-ID: <87vbig683y.fsf@linaro.org> (raw)
In-Reply-To: <CAFEAcA9x_6jGfNTpMLYYbmEp19U7sOVjcgzCggwkwZiyCM5yug@mail.gmail.com>
Peter Maydell <peter.maydell@linaro.org> writes:
> On 4 March 2015 at 23:35, Alex Benn?e <alex.bennee@linaro.org> wrote:
>> I was getting very confused about the duplication of state. Perhaps we
>> should just get rid of env->spsr and use helpers that understand the
>> banking?
>
> Doesn't seem worth changing the current working code to something
> else that's strictly less efficient... spsr is by no means the
> only banked-by-mode register, and it works just like all the others.
Fair enough. I just wanted to make it clear it was a cached value for
the benefit of TCG.
>
> -- PMM
--
Alex Benn?e
WARNING: multiple messages have this Message-ID (diff)
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
kvm-devel <kvm@vger.kernel.org>,
arm-mail-list <linux-arm-kernel@lists.infradead.org>,
"kvmarm\@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
Christoffer Dall <christoffer.dall@linaro.org>,
Marc Zyngier <marc.zyngier@arm.com>
Subject: Re: [PATCH v2 6/6] target-arm: cpu.h document why env->spsr exists
Date: Wed, 04 Mar 2015 16:27:29 +0000 [thread overview]
Message-ID: <87vbig683y.fsf@linaro.org> (raw)
In-Reply-To: <CAFEAcA9x_6jGfNTpMLYYbmEp19U7sOVjcgzCggwkwZiyCM5yug@mail.gmail.com>
Peter Maydell <peter.maydell@linaro.org> writes:
> On 4 March 2015 at 23:35, Alex Bennée <alex.bennee@linaro.org> wrote:
>> I was getting very confused about the duplication of state. Perhaps we
>> should just get rid of env->spsr and use helpers that understand the
>> banking?
>
> Doesn't seem worth changing the current working code to something
> else that's strictly less efficient... spsr is by no means the
> only banked-by-mode register, and it works just like all the others.
Fair enough. I just wanted to make it clear it was a cached value for
the benefit of TCG.
>
> -- PMM
--
Alex Bennée
WARNING: multiple messages have this Message-ID (diff)
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: kvm-devel <kvm@vger.kernel.org>,
Marc Zyngier <marc.zyngier@arm.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Christoffer Dall <christoffer.dall@linaro.org>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
arm-mail-list <linux-arm-kernel@lists.infradead.org>
Subject: Re: [Qemu-devel] [PATCH v2 6/6] target-arm: cpu.h document why env->spsr exists
Date: Wed, 04 Mar 2015 16:27:29 +0000 [thread overview]
Message-ID: <87vbig683y.fsf@linaro.org> (raw)
In-Reply-To: <CAFEAcA9x_6jGfNTpMLYYbmEp19U7sOVjcgzCggwkwZiyCM5yug@mail.gmail.com>
Peter Maydell <peter.maydell@linaro.org> writes:
> On 4 March 2015 at 23:35, Alex Bennée <alex.bennee@linaro.org> wrote:
>> I was getting very confused about the duplication of state. Perhaps we
>> should just get rid of env->spsr and use helpers that understand the
>> banking?
>
> Doesn't seem worth changing the current working code to something
> else that's strictly less efficient... spsr is by no means the
> only banked-by-mode register, and it works just like all the others.
Fair enough. I just wanted to make it clear it was a cached value for
the benefit of TCG.
>
> -- PMM
--
Alex Bennée
next prev parent reply other threads:[~2015-03-04 16:27 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 14:35 [PATCH v2 0/6] QEMU ARM64 Migration Fixes Alex Bennée
2015-03-04 14:35 ` [Qemu-devel] " Alex Bennée
2015-03-04 14:35 ` Alex Bennée
2015-03-04 14:35 ` [PATCH v2 1/6] target-arm: kvm: save/restore mp state Alex Bennée
2015-03-04 14:35 ` [Qemu-devel] " Alex Bennée
2015-03-04 14:35 ` Alex Bennée
2015-03-11 13:42 ` Greg Bellows
2015-03-11 13:42 ` [Qemu-devel] " Greg Bellows
2015-03-12 15:43 ` Peter Maydell
2015-03-12 15:43 ` [Qemu-devel] " Peter Maydell
2015-03-12 15:43 ` Peter Maydell
2015-03-13 10:40 ` Alex Bennée
2015-03-13 10:40 ` [Qemu-devel] " Alex Bennée
2015-03-13 10:40 ` Alex Bennée
2015-03-04 14:35 ` [PATCH v2 2/6] hw/intc: arm_gic_kvm.c restore config first Alex Bennée
2015-03-04 14:35 ` [Qemu-devel] " Alex Bennée
2015-03-04 14:35 ` Alex Bennée
2015-03-11 13:59 ` [Qemu-devel] " Greg Bellows
2015-03-11 13:59 ` Greg Bellows
2015-03-11 13:59 ` Greg Bellows
2015-03-04 14:35 ` [PATCH v2 3/6] hw/char: pl011 don't keep setting the IRQ if nothing changed Alex Bennée
2015-03-04 14:35 ` [Qemu-devel] " Alex Bennée
2015-03-04 14:35 ` Alex Bennée
2015-03-11 14:44 ` [Qemu-devel] " Greg Bellows
2015-03-11 14:44 ` Greg Bellows
2015-03-11 14:44 ` Greg Bellows
2015-03-12 15:51 ` Peter Maydell
2015-03-12 15:51 ` [Qemu-devel] " Peter Maydell
2015-03-12 15:51 ` Peter Maydell
2015-03-12 20:27 ` Peter Maydell
2015-03-12 20:27 ` [Qemu-devel] " Peter Maydell
2015-03-12 20:27 ` Peter Maydell
2015-03-13 10:38 ` Alex Bennée
2015-03-13 10:38 ` [Qemu-devel] " Alex Bennée
2015-03-13 10:38 ` Alex Bennée
2015-03-13 10:38 ` Alex Bennée
2015-03-04 14:35 ` [PATCH v2 4/6] target-arm: kvm64 sync FP register state Alex Bennée
2015-03-04 14:35 ` [Qemu-devel] " Alex Bennée
2015-03-04 14:35 ` Alex Bennée
2015-03-11 15:17 ` [Qemu-devel] " Greg Bellows
2015-03-11 15:17 ` Greg Bellows
2015-03-11 15:17 ` Greg Bellows
2015-03-04 14:35 ` [PATCH v2 5/6] target-arm: kvm64 fix save/restore of SPSR regs Alex Bennée
2015-03-04 14:35 ` [Qemu-devel] " Alex Bennée
2015-03-04 14:35 ` Alex Bennée
2015-03-09 13:26 ` Christoffer Dall
2015-03-09 13:26 ` [Qemu-devel] " Christoffer Dall
2015-03-09 13:26 ` Christoffer Dall
2015-03-11 19:41 ` [Qemu-devel] " Greg Bellows
2015-03-11 19:41 ` Greg Bellows
2015-03-11 19:41 ` Greg Bellows
2015-03-04 14:35 ` [PATCH v2 6/6] target-arm: cpu.h document why env->spsr exists Alex Bennée
2015-03-04 14:35 ` [Qemu-devel] " Alex Bennée
2015-03-04 14:35 ` Alex Bennée
2015-03-04 14:46 ` Peter Maydell
2015-03-04 14:46 ` [Qemu-devel] " Peter Maydell
2015-03-04 14:46 ` Peter Maydell
2015-03-04 16:27 ` Alex Bennée [this message]
2015-03-04 16:27 ` [Qemu-devel] " Alex Bennée
2015-03-04 16:27 ` Alex Bennée
2015-03-04 16:27 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vbig683y.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=christoffer.dall@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marc.zyngier@arm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.