From: Rusty Russell <rusty@rustcorp.com.au>
To: "Michael S. Tsirkin" <mst@redhat.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] virtio-spec: tweak wording for console control vq
Date: Tue, 21 May 2013 16:18:11 +0930 [thread overview]
Message-ID: <87vc6cygk4.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20130520122051.GA11581@redhat.com>
"Michael S. Tsirkin" <mst@redhat.com> writes:
> control vq is only used if feature bit is
> negotiated - it's not enough that device supports
> it. Clarify this in the spec.
Thanks, applied.
Cheers,
Rusty.
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> virtio-spec.lyx | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/virtio-spec.lyx b/virtio-spec.lyx
> index 921388b..3ef96a9 100644
> --- a/virtio-spec.lyx
> +++ b/virtio-spec.lyx
> @@ -6833,8 +6833,13 @@ VIRTIO_CONSOLE_F_SIZE
>
> \begin_layout Description
> VIRTIO_CONSOLE_F_MULTIPORT(1) Device has support for multiple ports; configurati
> -on fields nr_ports and max_nr_ports are valid and control virtqueues will
> - be used.
> +on fields nr_ports and max_nr_ports are valid
> +\change_inserted 1986246365 1347188404
> +; if this bit is negotiated,
> +\change_deleted 1986246365 1347188406
> + and
> +\change_unchanged
> + control virtqueues will be used.
> \change_inserted 1112500848 1368412890
>
> \end_layout
> --
> MST
prev parent reply other threads:[~2013-05-21 6:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-20 12:20 [PATCH] virtio-spec: tweak wording for console control vq Michael S. Tsirkin
2013-05-21 6:48 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vc6cygk4.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.