* [PATCH] virtio-spec: tweak wording for console control vq
@ 2013-05-20 12:20 Michael S. Tsirkin
2013-05-21 6:48 ` Rusty Russell
0 siblings, 1 reply; 2+ messages in thread
From: Michael S. Tsirkin @ 2013-05-20 12:20 UTC (permalink / raw)
To: virtualization
control vq is only used if feature bit is
negotiated - it's not enough that device supports
it. Clarify this in the spec.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
virtio-spec.lyx | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/virtio-spec.lyx b/virtio-spec.lyx
index 921388b..3ef96a9 100644
--- a/virtio-spec.lyx
+++ b/virtio-spec.lyx
@@ -6833,8 +6833,13 @@ VIRTIO_CONSOLE_F_SIZE
\begin_layout Description
VIRTIO_CONSOLE_F_MULTIPORT(1) Device has support for multiple ports; configurati
-on fields nr_ports and max_nr_ports are valid and control virtqueues will
- be used.
+on fields nr_ports and max_nr_ports are valid
+\change_inserted 1986246365 1347188404
+; if this bit is negotiated,
+\change_deleted 1986246365 1347188406
+ and
+\change_unchanged
+ control virtqueues will be used.
\change_inserted 1112500848 1368412890
\end_layout
--
MST
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] virtio-spec: tweak wording for console control vq
2013-05-20 12:20 [PATCH] virtio-spec: tweak wording for console control vq Michael S. Tsirkin
@ 2013-05-21 6:48 ` Rusty Russell
0 siblings, 0 replies; 2+ messages in thread
From: Rusty Russell @ 2013-05-21 6:48 UTC (permalink / raw)
To: Michael S. Tsirkin, virtualization
"Michael S. Tsirkin" <mst@redhat.com> writes:
> control vq is only used if feature bit is
> negotiated - it's not enough that device supports
> it. Clarify this in the spec.
Thanks, applied.
Cheers,
Rusty.
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> virtio-spec.lyx | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/virtio-spec.lyx b/virtio-spec.lyx
> index 921388b..3ef96a9 100644
> --- a/virtio-spec.lyx
> +++ b/virtio-spec.lyx
> @@ -6833,8 +6833,13 @@ VIRTIO_CONSOLE_F_SIZE
>
> \begin_layout Description
> VIRTIO_CONSOLE_F_MULTIPORT(1) Device has support for multiple ports; configurati
> -on fields nr_ports and max_nr_ports are valid and control virtqueues will
> - be used.
> +on fields nr_ports and max_nr_ports are valid
> +\change_inserted 1986246365 1347188404
> +; if this bit is negotiated,
> +\change_deleted 1986246365 1347188406
> + and
> +\change_unchanged
> + control virtqueues will be used.
> \change_inserted 1112500848 1368412890
>
> \end_layout
> --
> MST
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-21 6:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-20 12:20 [PATCH] virtio-spec: tweak wording for console control vq Michael S. Tsirkin
2013-05-21 6:48 ` Rusty Russell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.