symbol.h fix for ARM

symbol.h fix for ARM

[Timothy Baldwin]

[-- Attachment #1: Type: text/plain, Size: 1286 bytes --]

In ARM GAS syntax "@" marks the start of comment, which breaks symbol.h. I choose
double quotes as a replacement as they can't be used to start comments.

2005-11-13  Timothy Baldwin  <T.E.Baldwin99@members.leeds.ac.uk>

        Fix symbol.h for ARM.

        * include/grub/symbol.h: (FUNCTION): Use double quotes
	instead of "@" which marks the start of a comment on ARM.
	(VARIABLE): Likewise.



diff -purN -x '*.mk' -x '*~' -x autom4te.cache -x configure -x '.#*' -x '*.orig' -x '*.rej' -x CVS grub2-split1/include/grub/symbol.h grub2-split2/include/grub/symbol.h
--- grub2-split1/include/grub/symbol.h	2004-04-04 14:46:00.000000000 +0100
+++ grub2-split2/include/grub/symbol.h	2005-10-22 20:25:44.000000000 +0100
@@ -29,8 +29,8 @@
 # define EXT_C(sym)	sym
 #endif
 
-#define FUNCTION(x)	.globl EXT_C(x) ; .type EXT_C(x), @function ; EXT_C(x):
-#define VARIABLE(x)	.globl EXT_C(x) ; .type EXT_C(x), @object ; EXT_C(x):
+#define FUNCTION(x)	.globl EXT_C(x) ; .type EXT_C(x), "function" ; EXT_C(x):
+#define VARIABLE(x)	.globl EXT_C(x) ; .type EXT_C(x), "object" ; EXT_C(x):
 
 /* Mark an exported symbol.  */
 #define EXPORT_FUNC(x)	x


-- 
Member AFFS, WYLUG, SWP (UK), UAF, RESPECT, StWC
No to software patents!    Victory to the iraqi resistance!

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: symbol.h fix for ARM

[Marco Gerards]

Timothy Baldwin <tim.lists@majoroak.f2s.com> writes:

> In ARM GAS syntax "@" marks the start of comment, which breaks symbol.h. I choose
> double quotes as a replacement as they can't be used to start comments.
>
> 2005-11-13  Timothy Baldwin  <T.E.Baldwin99@members.leeds.ac.uk>
>
>         Fix symbol.h for ARM.
>
>         * include/grub/symbol.h: (FUNCTION): Use double quotes
> 	instead of "@" which marks the start of a comment on ARM.
> 	(VARIABLE): Likewise.

Have you tested if other archs keep working with this patch applied?

--
Marco

Re: symbol.h fix for ARM

[Timothy Baldwin]

[-- Attachment #1: Type: text/plain, Size: 955 bytes --]

On Sunday 13 Nov 2005 21:04, Marco Gerards wrote:
> Timothy Baldwin <tim.lists@majoroak.f2s.com> writes:
> > In ARM GAS syntax "@" marks the start of comment, which breaks symbol.h.
> > I choose double quotes as a replacement as they can't be used to start
> > comments.
> >
> > 2005-11-13  Timothy Baldwin  <T.E.Baldwin99@members.leeds.ac.uk>
> >
> >         Fix symbol.h for ARM.
> >
> >         * include/grub/symbol.h: (FUNCTION): Use double quotes
> > 	instead of "@" which marks the start of a comment on ARM.
> > 	(VARIABLE): Likewise.
>
> Have you tested if other archs keep working with this patch applied?

Tested both i386 and PowerPC. I don't see why it should break elsewhere as 
giving double quotes a conflicting meaning would break .string etc. The GAS 
manual does not mention any system dependences.

-- 
Member AFFS, WYLUG, SWP (UK), UAF, RESPECT, StWC
No to software patents!    Victory to the iraqi resistance!

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: symbol.h fix for ARM

[Marco Gerards]

Timothy Baldwin <tim.lists@majoroak.f2s.com> writes:

> On Sunday 13 Nov 2005 21:04, Marco Gerards wrote:
>> Timothy Baldwin <tim.lists@majoroak.f2s.com> writes:
>> > In ARM GAS syntax "@" marks the start of comment, which breaks symbol.h.
>> > I choose double quotes as a replacement as they can't be used to start
>> > comments.
>> >
>> > 2005-11-13  Timothy Baldwin  <T.E.Baldwin99@members.leeds.ac.uk>
>> >
>> >         Fix symbol.h for ARM.
>> >
>> >         * include/grub/symbol.h: (FUNCTION): Use double quotes
>> > 	instead of "@" which marks the start of a comment on ARM.
>> > 	(VARIABLE): Likewise.
>>
>> Have you tested if other archs keep working with this patch applied?
>
> Tested both i386 and PowerPC. I don't see why it should break elsewhere as 
> giving double quotes a conflicting meaning would break .string etc. The GAS 
> manual does not mention any system dependences.

Cool.  I'll apply this patch right away.

--
Marco