All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Tianling Shen <cnsztl@gmail.com>
Cc: Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 Tudor Ambarus <tudor.ambarus@linaro.org>,
	 Mark Brown <broonie@kernel.org>,
	 linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: spinand: add support for FudanMicro FM25S01A
Date: Sun, 24 Aug 2025 17:46:18 +0200	[thread overview]
Message-ID: <87wm6sk9it.fsf@bootlin.com> (raw)
In-Reply-To: <20250810133852.52389-1-cnsztl@gmail.com> (Tianling Shen's message of "Sun, 10 Aug 2025 21:38:52 +0800")

Hello Tianling,

On 10/08/2025 at 21:38:52 +08, Tianling Shen <cnsztl@gmail.com> wrote:

> Add support for FudanMicro FM25S01A SPI NAND.
> Datasheet: http://eng.fmsh.com/nvm/FM25S01A_ds_eng.pdf
>
> Signed-off-by: Tianling Shen <cnsztl@gmail.com>
> ---
>  drivers/mtd/nand/spi/Makefile |  2 +-
>  drivers/mtd/nand/spi/core.c   |  1 +
>  drivers/mtd/nand/spi/fmsh.c   | 74 +++++++++++++++++++++++++++++++++++
>  include/linux/mtd/spinand.h   |  1 +
>  4 files changed, 77 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/mtd/nand/spi/fmsh.c
>
> diff --git a/drivers/mtd/nand/spi/Makefile b/drivers/mtd/nand/spi/Makefile
> index 258da42451a4..e288742ea8f0 100644
> --- a/drivers/mtd/nand/spi/Makefile
> +++ b/drivers/mtd/nand/spi/Makefile
> @@ -1,5 +1,5 @@
>  # SPDX-License-Identifier: GPL-2.0
> -spinand-objs := core.o otp.o
> +spinand-objs := core.o fmsh.o otp.o

You're adding a manufacturer driver in the middle of the core files. For
now we kind of inforce an alphabetical order, so please move it below.

>  spinand-objs += alliancememory.o ato.o esmt.o foresee.o gigadevice.o
>  macronix.o

                                                ^
Here

>  spinand-objs += micron.o paragon.o skyhigh.o toshiba.o winbond.o xtx.o
>  obj-$(CONFIG_MTD_SPI_NAND) += spinand.o
> diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c
> index b0898990b2a5..ea47028d021a 100644
> --- a/drivers/mtd/nand/spi/core.c
> +++ b/drivers/mtd/nand/spi/core.c
> @@ -1184,6 +1184,7 @@ static const struct spinand_manufacturer *spinand_manufacturers[] = {
>  	&alliancememory_spinand_manufacturer,
>  	&ato_spinand_manufacturer,
>  	&esmt_c8_spinand_manufacturer,
> +	&fmsh_spinand_manufacturer,
>  	&foresee_spinand_manufacturer,
>  	&gigadevice_spinand_manufacturer,
>  	&macronix_spinand_manufacturer,
> diff --git a/drivers/mtd/nand/spi/fmsh.c b/drivers/mtd/nand/spi/fmsh.c
> new file mode 100644
> index 000000000000..8b2097bfc771
> --- /dev/null
> +++ b/drivers/mtd/nand/spi/fmsh.c

Otherise the driver is simple enough, so v2 should make it :)

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Tianling Shen <cnsztl@gmail.com>
Cc: Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 Tudor Ambarus <tudor.ambarus@linaro.org>,
	 Mark Brown <broonie@kernel.org>,
	 linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: spinand: add support for FudanMicro FM25S01A
Date: Sun, 24 Aug 2025 17:46:18 +0200	[thread overview]
Message-ID: <87wm6sk9it.fsf@bootlin.com> (raw)
In-Reply-To: <20250810133852.52389-1-cnsztl@gmail.com> (Tianling Shen's message of "Sun, 10 Aug 2025 21:38:52 +0800")

Hello Tianling,

On 10/08/2025 at 21:38:52 +08, Tianling Shen <cnsztl@gmail.com> wrote:

> Add support for FudanMicro FM25S01A SPI NAND.
> Datasheet: http://eng.fmsh.com/nvm/FM25S01A_ds_eng.pdf
>
> Signed-off-by: Tianling Shen <cnsztl@gmail.com>
> ---
>  drivers/mtd/nand/spi/Makefile |  2 +-
>  drivers/mtd/nand/spi/core.c   |  1 +
>  drivers/mtd/nand/spi/fmsh.c   | 74 +++++++++++++++++++++++++++++++++++
>  include/linux/mtd/spinand.h   |  1 +
>  4 files changed, 77 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/mtd/nand/spi/fmsh.c
>
> diff --git a/drivers/mtd/nand/spi/Makefile b/drivers/mtd/nand/spi/Makefile
> index 258da42451a4..e288742ea8f0 100644
> --- a/drivers/mtd/nand/spi/Makefile
> +++ b/drivers/mtd/nand/spi/Makefile
> @@ -1,5 +1,5 @@
>  # SPDX-License-Identifier: GPL-2.0
> -spinand-objs := core.o otp.o
> +spinand-objs := core.o fmsh.o otp.o

You're adding a manufacturer driver in the middle of the core files. For
now we kind of inforce an alphabetical order, so please move it below.

>  spinand-objs += alliancememory.o ato.o esmt.o foresee.o gigadevice.o
>  macronix.o

                                                ^
Here

>  spinand-objs += micron.o paragon.o skyhigh.o toshiba.o winbond.o xtx.o
>  obj-$(CONFIG_MTD_SPI_NAND) += spinand.o
> diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c
> index b0898990b2a5..ea47028d021a 100644
> --- a/drivers/mtd/nand/spi/core.c
> +++ b/drivers/mtd/nand/spi/core.c
> @@ -1184,6 +1184,7 @@ static const struct spinand_manufacturer *spinand_manufacturers[] = {
>  	&alliancememory_spinand_manufacturer,
>  	&ato_spinand_manufacturer,
>  	&esmt_c8_spinand_manufacturer,
> +	&fmsh_spinand_manufacturer,
>  	&foresee_spinand_manufacturer,
>  	&gigadevice_spinand_manufacturer,
>  	&macronix_spinand_manufacturer,
> diff --git a/drivers/mtd/nand/spi/fmsh.c b/drivers/mtd/nand/spi/fmsh.c
> new file mode 100644
> index 000000000000..8b2097bfc771
> --- /dev/null
> +++ b/drivers/mtd/nand/spi/fmsh.c

Otherise the driver is simple enough, so v2 should make it :)

Thanks,
Miquèl

  reply	other threads:[~2025-08-24 15:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-10 13:38 [PATCH] mtd: spinand: add support for FudanMicro FM25S01A Tianling Shen
2025-08-10 13:38 ` Tianling Shen
2025-08-24 15:46 ` Miquel Raynal [this message]
2025-08-24 15:46   ` Miquel Raynal
2025-08-24 17:04   ` Tianling Shen
2025-08-24 17:04     ` Tianling Shen
  -- strict thread matches above, loose matches on Subject: below --
2025-10-30 19:07 Tianling Shen
2025-11-01  4:20 ` Mikhail Kshevetskiy
2025-11-01  5:17   ` Tianling Shen
2025-11-01  4:24 ` Mikhail Kshevetskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wm6sk9it.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=broonie@kernel.org \
    --cc=cnsztl@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=tudor.ambarus@linaro.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.