All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mtd: spinand: add support for FudanMicro FM25S01A
@ 2025-08-10 13:38 ` Tianling Shen
  0 siblings, 0 replies; 10+ messages in thread
From: Tianling Shen @ 2025-08-10 13:38 UTC (permalink / raw)
  To: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
	Tudor Ambarus, Mark Brown, Tianling Shen
  Cc: linux-kernel, linux-mtd

Add support for FudanMicro FM25S01A SPI NAND.
Datasheet: http://eng.fmsh.com/nvm/FM25S01A_ds_eng.pdf

Signed-off-by: Tianling Shen <cnsztl@gmail.com>
---
 drivers/mtd/nand/spi/Makefile |  2 +-
 drivers/mtd/nand/spi/core.c   |  1 +
 drivers/mtd/nand/spi/fmsh.c   | 74 +++++++++++++++++++++++++++++++++++
 include/linux/mtd/spinand.h   |  1 +
 4 files changed, 77 insertions(+), 1 deletion(-)
 create mode 100644 drivers/mtd/nand/spi/fmsh.c

diff --git a/drivers/mtd/nand/spi/Makefile b/drivers/mtd/nand/spi/Makefile
index 258da42451a4..e288742ea8f0 100644
--- a/drivers/mtd/nand/spi/Makefile
+++ b/drivers/mtd/nand/spi/Makefile
@@ -1,5 +1,5 @@
 # SPDX-License-Identifier: GPL-2.0
-spinand-objs := core.o otp.o
+spinand-objs := core.o fmsh.o otp.o
 spinand-objs += alliancememory.o ato.o esmt.o foresee.o gigadevice.o macronix.o
 spinand-objs += micron.o paragon.o skyhigh.o toshiba.o winbond.o xtx.o
 obj-$(CONFIG_MTD_SPI_NAND) += spinand.o
diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c
index b0898990b2a5..ea47028d021a 100644
--- a/drivers/mtd/nand/spi/core.c
+++ b/drivers/mtd/nand/spi/core.c
@@ -1184,6 +1184,7 @@ static const struct spinand_manufacturer *spinand_manufacturers[] = {
 	&alliancememory_spinand_manufacturer,
 	&ato_spinand_manufacturer,
 	&esmt_c8_spinand_manufacturer,
+	&fmsh_spinand_manufacturer,
 	&foresee_spinand_manufacturer,
 	&gigadevice_spinand_manufacturer,
 	&macronix_spinand_manufacturer,
diff --git a/drivers/mtd/nand/spi/fmsh.c b/drivers/mtd/nand/spi/fmsh.c
new file mode 100644
index 000000000000..8b2097bfc771
--- /dev/null
+++ b/drivers/mtd/nand/spi/fmsh.c
@@ -0,0 +1,74 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (c) 2020-2021 Rockchip Electronics Co., Ltd.
+ *
+ * Author: Dingqiang Lin <jon.lin@rock-chips.com>
+ */
+
+#include <linux/device.h>
+#include <linux/kernel.h>
+#include <linux/mtd/spinand.h>
+
+#define SPINAND_MFR_FMSH		0xA1
+
+static SPINAND_OP_VARIANTS(read_cache_variants,
+		SPINAND_PAGE_READ_FROM_CACHE_1S_4S_4S_OP(0, 2, NULL, 0, 0),
+		SPINAND_PAGE_READ_FROM_CACHE_1S_1S_4S_OP(0, 1, NULL, 0, 0),
+		SPINAND_PAGE_READ_FROM_CACHE_1S_2S_2S_OP(0, 1, NULL, 0, 0),
+		SPINAND_PAGE_READ_FROM_CACHE_1S_1S_2S_OP(0, 1, NULL, 0, 0),
+		SPINAND_PAGE_READ_FROM_CACHE_FAST_1S_1S_1S_OP(0, 1, NULL, 0, 0),
+		SPINAND_PAGE_READ_FROM_CACHE_1S_1S_1S_OP(0, 1, NULL, 0, 0));
+
+static SPINAND_OP_VARIANTS(write_cache_variants,
+		SPINAND_PROG_LOAD_1S_1S_4S_OP(true, 0, NULL, 0),
+		SPINAND_PROG_LOAD_1S_1S_1S_OP(true, 0, NULL, 0));
+
+static SPINAND_OP_VARIANTS(update_cache_variants,
+		SPINAND_PROG_LOAD_1S_1S_4S_OP(false, 0, NULL, 0),
+		SPINAND_PROG_LOAD_1S_1S_1S_OP(false, 0, NULL, 0));
+
+static int fm25s01a_ooblayout_ecc(struct mtd_info *mtd, int section,
+				  struct mtd_oob_region *region)
+{
+	return -ERANGE;
+}
+
+static int fm25s01a_ooblayout_free(struct mtd_info *mtd, int section,
+				   struct mtd_oob_region *region)
+{
+	if (section)
+		return -ERANGE;
+
+	region->offset = 2;
+	region->length = 62;
+
+	return 0;
+}
+
+static const struct mtd_ooblayout_ops fm25s01a_ooblayout = {
+	.ecc = fm25s01a_ooblayout_ecc,
+	.free = fm25s01a_ooblayout_free,
+};
+
+static const struct spinand_info fmsh_spinand_table[] = {
+	SPINAND_INFO("FM25S01A",
+		     SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0xE4),
+		     NAND_MEMORG(1, 2048, 64, 64, 1024, 20, 1, 1, 1),
+		     NAND_ECCREQ(1, 512),
+		     SPINAND_INFO_OP_VARIANTS(&read_cache_variants,
+					      &write_cache_variants,
+					      &update_cache_variants),
+		     SPINAND_HAS_QE_BIT,
+		     SPINAND_ECCINFO(&fm25s01a_ooblayout, NULL)),
+};
+
+static const struct spinand_manufacturer_ops fmsh_spinand_manuf_ops = {
+};
+
+const struct spinand_manufacturer fmsh_spinand_manufacturer = {
+	.id = SPINAND_MFR_FMSH,
+	.name = "Fudan Micro",
+	.chips = fmsh_spinand_table,
+	.nchips = ARRAY_SIZE(fmsh_spinand_table),
+	.ops = &fmsh_spinand_manuf_ops,
+};
diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h
index 27a45bdab7ec..927c10d78769 100644
--- a/include/linux/mtd/spinand.h
+++ b/include/linux/mtd/spinand.h
@@ -355,6 +355,7 @@ struct spinand_manufacturer {
 extern const struct spinand_manufacturer alliancememory_spinand_manufacturer;
 extern const struct spinand_manufacturer ato_spinand_manufacturer;
 extern const struct spinand_manufacturer esmt_c8_spinand_manufacturer;
+extern const struct spinand_manufacturer fmsh_spinand_manufacturer;
 extern const struct spinand_manufacturer foresee_spinand_manufacturer;
 extern const struct spinand_manufacturer gigadevice_spinand_manufacturer;
 extern const struct spinand_manufacturer macronix_spinand_manufacturer;
-- 
2.50.1


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH] mtd: spinand: add support for FudanMicro FM25S01A
@ 2025-08-10 13:38 ` Tianling Shen
  0 siblings, 0 replies; 10+ messages in thread
From: Tianling Shen @ 2025-08-10 13:38 UTC (permalink / raw)
  To: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
	Tudor Ambarus, Mark Brown, Tianling Shen
  Cc: linux-kernel, linux-mtd

Add support for FudanMicro FM25S01A SPI NAND.
Datasheet: http://eng.fmsh.com/nvm/FM25S01A_ds_eng.pdf

Signed-off-by: Tianling Shen <cnsztl@gmail.com>
---
 drivers/mtd/nand/spi/Makefile |  2 +-
 drivers/mtd/nand/spi/core.c   |  1 +
 drivers/mtd/nand/spi/fmsh.c   | 74 +++++++++++++++++++++++++++++++++++
 include/linux/mtd/spinand.h   |  1 +
 4 files changed, 77 insertions(+), 1 deletion(-)
 create mode 100644 drivers/mtd/nand/spi/fmsh.c

diff --git a/drivers/mtd/nand/spi/Makefile b/drivers/mtd/nand/spi/Makefile
index 258da42451a4..e288742ea8f0 100644
--- a/drivers/mtd/nand/spi/Makefile
+++ b/drivers/mtd/nand/spi/Makefile
@@ -1,5 +1,5 @@
 # SPDX-License-Identifier: GPL-2.0
-spinand-objs := core.o otp.o
+spinand-objs := core.o fmsh.o otp.o
 spinand-objs += alliancememory.o ato.o esmt.o foresee.o gigadevice.o macronix.o
 spinand-objs += micron.o paragon.o skyhigh.o toshiba.o winbond.o xtx.o
 obj-$(CONFIG_MTD_SPI_NAND) += spinand.o
diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c
index b0898990b2a5..ea47028d021a 100644
--- a/drivers/mtd/nand/spi/core.c
+++ b/drivers/mtd/nand/spi/core.c
@@ -1184,6 +1184,7 @@ static const struct spinand_manufacturer *spinand_manufacturers[] = {
 	&alliancememory_spinand_manufacturer,
 	&ato_spinand_manufacturer,
 	&esmt_c8_spinand_manufacturer,
+	&fmsh_spinand_manufacturer,
 	&foresee_spinand_manufacturer,
 	&gigadevice_spinand_manufacturer,
 	&macronix_spinand_manufacturer,
diff --git a/drivers/mtd/nand/spi/fmsh.c b/drivers/mtd/nand/spi/fmsh.c
new file mode 100644
index 000000000000..8b2097bfc771
--- /dev/null
+++ b/drivers/mtd/nand/spi/fmsh.c
@@ -0,0 +1,74 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (c) 2020-2021 Rockchip Electronics Co., Ltd.
+ *
+ * Author: Dingqiang Lin <jon.lin@rock-chips.com>
+ */
+
+#include <linux/device.h>
+#include <linux/kernel.h>
+#include <linux/mtd/spinand.h>
+
+#define SPINAND_MFR_FMSH		0xA1
+
+static SPINAND_OP_VARIANTS(read_cache_variants,
+		SPINAND_PAGE_READ_FROM_CACHE_1S_4S_4S_OP(0, 2, NULL, 0, 0),
+		SPINAND_PAGE_READ_FROM_CACHE_1S_1S_4S_OP(0, 1, NULL, 0, 0),
+		SPINAND_PAGE_READ_FROM_CACHE_1S_2S_2S_OP(0, 1, NULL, 0, 0),
+		SPINAND_PAGE_READ_FROM_CACHE_1S_1S_2S_OP(0, 1, NULL, 0, 0),
+		SPINAND_PAGE_READ_FROM_CACHE_FAST_1S_1S_1S_OP(0, 1, NULL, 0, 0),
+		SPINAND_PAGE_READ_FROM_CACHE_1S_1S_1S_OP(0, 1, NULL, 0, 0));
+
+static SPINAND_OP_VARIANTS(write_cache_variants,
+		SPINAND_PROG_LOAD_1S_1S_4S_OP(true, 0, NULL, 0),
+		SPINAND_PROG_LOAD_1S_1S_1S_OP(true, 0, NULL, 0));
+
+static SPINAND_OP_VARIANTS(update_cache_variants,
+		SPINAND_PROG_LOAD_1S_1S_4S_OP(false, 0, NULL, 0),
+		SPINAND_PROG_LOAD_1S_1S_1S_OP(false, 0, NULL, 0));
+
+static int fm25s01a_ooblayout_ecc(struct mtd_info *mtd, int section,
+				  struct mtd_oob_region *region)
+{
+	return -ERANGE;
+}
+
+static int fm25s01a_ooblayout_free(struct mtd_info *mtd, int section,
+				   struct mtd_oob_region *region)
+{
+	if (section)
+		return -ERANGE;
+
+	region->offset = 2;
+	region->length = 62;
+
+	return 0;
+}
+
+static const struct mtd_ooblayout_ops fm25s01a_ooblayout = {
+	.ecc = fm25s01a_ooblayout_ecc,
+	.free = fm25s01a_ooblayout_free,
+};
+
+static const struct spinand_info fmsh_spinand_table[] = {
+	SPINAND_INFO("FM25S01A",
+		     SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0xE4),
+		     NAND_MEMORG(1, 2048, 64, 64, 1024, 20, 1, 1, 1),
+		     NAND_ECCREQ(1, 512),
+		     SPINAND_INFO_OP_VARIANTS(&read_cache_variants,
+					      &write_cache_variants,
+					      &update_cache_variants),
+		     SPINAND_HAS_QE_BIT,
+		     SPINAND_ECCINFO(&fm25s01a_ooblayout, NULL)),
+};
+
+static const struct spinand_manufacturer_ops fmsh_spinand_manuf_ops = {
+};
+
+const struct spinand_manufacturer fmsh_spinand_manufacturer = {
+	.id = SPINAND_MFR_FMSH,
+	.name = "Fudan Micro",
+	.chips = fmsh_spinand_table,
+	.nchips = ARRAY_SIZE(fmsh_spinand_table),
+	.ops = &fmsh_spinand_manuf_ops,
+};
diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h
index 27a45bdab7ec..927c10d78769 100644
--- a/include/linux/mtd/spinand.h
+++ b/include/linux/mtd/spinand.h
@@ -355,6 +355,7 @@ struct spinand_manufacturer {
 extern const struct spinand_manufacturer alliancememory_spinand_manufacturer;
 extern const struct spinand_manufacturer ato_spinand_manufacturer;
 extern const struct spinand_manufacturer esmt_c8_spinand_manufacturer;
+extern const struct spinand_manufacturer fmsh_spinand_manufacturer;
 extern const struct spinand_manufacturer foresee_spinand_manufacturer;
 extern const struct spinand_manufacturer gigadevice_spinand_manufacturer;
 extern const struct spinand_manufacturer macronix_spinand_manufacturer;
-- 
2.50.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread
* Re: [PATCH] mtd: spinand: add support for FudanMicro FM25S01A
  2025-08-10 13:38 ` Tianling Shen
@ 2025-08-24 15:46   ` Miquel Raynal
  -1 siblings, 0 replies; 10+ messages in thread
From: Miquel Raynal @ 2025-08-24 15:46 UTC (permalink / raw)
  To: Tianling Shen
  Cc: Richard Weinberger, Vignesh Raghavendra, Tudor Ambarus,
	Mark Brown, linux-kernel, linux-mtd

Hello Tianling,

On 10/08/2025 at 21:38:52 +08, Tianling Shen <cnsztl@gmail.com> wrote:

> Add support for FudanMicro FM25S01A SPI NAND.
> Datasheet: http://eng.fmsh.com/nvm/FM25S01A_ds_eng.pdf
>
> Signed-off-by: Tianling Shen <cnsztl@gmail.com>
> ---
>  drivers/mtd/nand/spi/Makefile |  2 +-
>  drivers/mtd/nand/spi/core.c   |  1 +
>  drivers/mtd/nand/spi/fmsh.c   | 74 +++++++++++++++++++++++++++++++++++
>  include/linux/mtd/spinand.h   |  1 +
>  4 files changed, 77 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/mtd/nand/spi/fmsh.c
>
> diff --git a/drivers/mtd/nand/spi/Makefile b/drivers/mtd/nand/spi/Makefile
> index 258da42451a4..e288742ea8f0 100644
> --- a/drivers/mtd/nand/spi/Makefile
> +++ b/drivers/mtd/nand/spi/Makefile
> @@ -1,5 +1,5 @@
>  # SPDX-License-Identifier: GPL-2.0
> -spinand-objs := core.o otp.o
> +spinand-objs := core.o fmsh.o otp.o

You're adding a manufacturer driver in the middle of the core files. For
now we kind of inforce an alphabetical order, so please move it below.

>  spinand-objs += alliancememory.o ato.o esmt.o foresee.o gigadevice.o
>  macronix.o

                                                ^
Here

>  spinand-objs += micron.o paragon.o skyhigh.o toshiba.o winbond.o xtx.o
>  obj-$(CONFIG_MTD_SPI_NAND) += spinand.o
> diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c
> index b0898990b2a5..ea47028d021a 100644
> --- a/drivers/mtd/nand/spi/core.c
> +++ b/drivers/mtd/nand/spi/core.c
> @@ -1184,6 +1184,7 @@ static const struct spinand_manufacturer *spinand_manufacturers[] = {
>  	&alliancememory_spinand_manufacturer,
>  	&ato_spinand_manufacturer,
>  	&esmt_c8_spinand_manufacturer,
> +	&fmsh_spinand_manufacturer,
>  	&foresee_spinand_manufacturer,
>  	&gigadevice_spinand_manufacturer,
>  	&macronix_spinand_manufacturer,
> diff --git a/drivers/mtd/nand/spi/fmsh.c b/drivers/mtd/nand/spi/fmsh.c
> new file mode 100644
> index 000000000000..8b2097bfc771
> --- /dev/null
> +++ b/drivers/mtd/nand/spi/fmsh.c

Otherise the driver is simple enough, so v2 should make it :)

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH] mtd: spinand: add support for FudanMicro FM25S01A
@ 2025-08-24 15:46   ` Miquel Raynal
  0 siblings, 0 replies; 10+ messages in thread
From: Miquel Raynal @ 2025-08-24 15:46 UTC (permalink / raw)
  To: Tianling Shen
  Cc: Richard Weinberger, Vignesh Raghavendra, Tudor Ambarus,
	Mark Brown, linux-kernel, linux-mtd

Hello Tianling,

On 10/08/2025 at 21:38:52 +08, Tianling Shen <cnsztl@gmail.com> wrote:

> Add support for FudanMicro FM25S01A SPI NAND.
> Datasheet: http://eng.fmsh.com/nvm/FM25S01A_ds_eng.pdf
>
> Signed-off-by: Tianling Shen <cnsztl@gmail.com>
> ---
>  drivers/mtd/nand/spi/Makefile |  2 +-
>  drivers/mtd/nand/spi/core.c   |  1 +
>  drivers/mtd/nand/spi/fmsh.c   | 74 +++++++++++++++++++++++++++++++++++
>  include/linux/mtd/spinand.h   |  1 +
>  4 files changed, 77 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/mtd/nand/spi/fmsh.c
>
> diff --git a/drivers/mtd/nand/spi/Makefile b/drivers/mtd/nand/spi/Makefile
> index 258da42451a4..e288742ea8f0 100644
> --- a/drivers/mtd/nand/spi/Makefile
> +++ b/drivers/mtd/nand/spi/Makefile
> @@ -1,5 +1,5 @@
>  # SPDX-License-Identifier: GPL-2.0
> -spinand-objs := core.o otp.o
> +spinand-objs := core.o fmsh.o otp.o

You're adding a manufacturer driver in the middle of the core files. For
now we kind of inforce an alphabetical order, so please move it below.

>  spinand-objs += alliancememory.o ato.o esmt.o foresee.o gigadevice.o
>  macronix.o

                                                ^
Here

>  spinand-objs += micron.o paragon.o skyhigh.o toshiba.o winbond.o xtx.o
>  obj-$(CONFIG_MTD_SPI_NAND) += spinand.o
> diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c
> index b0898990b2a5..ea47028d021a 100644
> --- a/drivers/mtd/nand/spi/core.c
> +++ b/drivers/mtd/nand/spi/core.c
> @@ -1184,6 +1184,7 @@ static const struct spinand_manufacturer *spinand_manufacturers[] = {
>  	&alliancememory_spinand_manufacturer,
>  	&ato_spinand_manufacturer,
>  	&esmt_c8_spinand_manufacturer,
> +	&fmsh_spinand_manufacturer,
>  	&foresee_spinand_manufacturer,
>  	&gigadevice_spinand_manufacturer,
>  	&macronix_spinand_manufacturer,
> diff --git a/drivers/mtd/nand/spi/fmsh.c b/drivers/mtd/nand/spi/fmsh.c
> new file mode 100644
> index 000000000000..8b2097bfc771
> --- /dev/null
> +++ b/drivers/mtd/nand/spi/fmsh.c

Otherise the driver is simple enough, so v2 should make it :)

Thanks,
Miquèl

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH] mtd: spinand: add support for FudanMicro FM25S01A
  2025-08-24 15:46   ` Miquel Raynal
@ 2025-08-24 17:04     ` Tianling Shen
  -1 siblings, 0 replies; 10+ messages in thread
From: Tianling Shen @ 2025-08-24 17:04 UTC (permalink / raw)
  To: Miquel Raynal
  Cc: Richard Weinberger, Vignesh Raghavendra, Tudor Ambarus,
	Mark Brown, linux-kernel, linux-mtd

Hello Miquel,

On 2025/8/24 23:46, Miquel Raynal wrote:
> Hello Tianling,
> 
> On 10/08/2025 at 21:38:52 +08, Tianling Shen <cnsztl@gmail.com> wrote:
> 
>> Add support for FudanMicro FM25S01A SPI NAND.
>> Datasheet: http://eng.fmsh.com/nvm/FM25S01A_ds_eng.pdf
>>
>> Signed-off-by: Tianling Shen <cnsztl@gmail.com>
>> ---
>>   drivers/mtd/nand/spi/Makefile |  2 +-
>>   drivers/mtd/nand/spi/core.c   |  1 +
>>   drivers/mtd/nand/spi/fmsh.c   | 74 +++++++++++++++++++++++++++++++++++
>>   include/linux/mtd/spinand.h   |  1 +
>>   4 files changed, 77 insertions(+), 1 deletion(-)
>>   create mode 100644 drivers/mtd/nand/spi/fmsh.c
>>
>> diff --git a/drivers/mtd/nand/spi/Makefile b/drivers/mtd/nand/spi/Makefile
>> index 258da42451a4..e288742ea8f0 100644
>> --- a/drivers/mtd/nand/spi/Makefile
>> +++ b/drivers/mtd/nand/spi/Makefile
>> @@ -1,5 +1,5 @@
>>   # SPDX-License-Identifier: GPL-2.0
>> -spinand-objs := core.o otp.o
>> +spinand-objs := core.o fmsh.o otp.o
> 
> You're adding a manufacturer driver in the middle of the core files. For
> now we kind of inforce an alphabetical order, so please move it below.

oops, sorry for that, I've sent v2 for it. Thank you!

Regards,
Tianling.

> 
>>   spinand-objs += alliancememory.o ato.o esmt.o foresee.o gigadevice.o
>>   macronix.o
> 
>                                                  ^
> Here
> 
>>   spinand-objs += micron.o paragon.o skyhigh.o toshiba.o winbond.o xtx.o
>>   obj-$(CONFIG_MTD_SPI_NAND) += spinand.o
>> diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c
>> index b0898990b2a5..ea47028d021a 100644
>> --- a/drivers/mtd/nand/spi/core.c
>> +++ b/drivers/mtd/nand/spi/core.c
>> @@ -1184,6 +1184,7 @@ static const struct spinand_manufacturer *spinand_manufacturers[] = {
>>   	&alliancememory_spinand_manufacturer,
>>   	&ato_spinand_manufacturer,
>>   	&esmt_c8_spinand_manufacturer,
>> +	&fmsh_spinand_manufacturer,
>>   	&foresee_spinand_manufacturer,
>>   	&gigadevice_spinand_manufacturer,
>>   	&macronix_spinand_manufacturer,
>> diff --git a/drivers/mtd/nand/spi/fmsh.c b/drivers/mtd/nand/spi/fmsh.c
>> new file mode 100644
>> index 000000000000..8b2097bfc771
>> --- /dev/null
>> +++ b/drivers/mtd/nand/spi/fmsh.c
> 
> Otherise the driver is simple enough, so v2 should make it :)
> 
> Thanks,
> Miquèl


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH] mtd: spinand: add support for FudanMicro FM25S01A
@ 2025-08-24 17:04     ` Tianling Shen
  0 siblings, 0 replies; 10+ messages in thread
From: Tianling Shen @ 2025-08-24 17:04 UTC (permalink / raw)
  To: Miquel Raynal
  Cc: Richard Weinberger, Vignesh Raghavendra, Tudor Ambarus,
	Mark Brown, linux-kernel, linux-mtd

Hello Miquel,

On 2025/8/24 23:46, Miquel Raynal wrote:
> Hello Tianling,
> 
> On 10/08/2025 at 21:38:52 +08, Tianling Shen <cnsztl@gmail.com> wrote:
> 
>> Add support for FudanMicro FM25S01A SPI NAND.
>> Datasheet: http://eng.fmsh.com/nvm/FM25S01A_ds_eng.pdf
>>
>> Signed-off-by: Tianling Shen <cnsztl@gmail.com>
>> ---
>>   drivers/mtd/nand/spi/Makefile |  2 +-
>>   drivers/mtd/nand/spi/core.c   |  1 +
>>   drivers/mtd/nand/spi/fmsh.c   | 74 +++++++++++++++++++++++++++++++++++
>>   include/linux/mtd/spinand.h   |  1 +
>>   4 files changed, 77 insertions(+), 1 deletion(-)
>>   create mode 100644 drivers/mtd/nand/spi/fmsh.c
>>
>> diff --git a/drivers/mtd/nand/spi/Makefile b/drivers/mtd/nand/spi/Makefile
>> index 258da42451a4..e288742ea8f0 100644
>> --- a/drivers/mtd/nand/spi/Makefile
>> +++ b/drivers/mtd/nand/spi/Makefile
>> @@ -1,5 +1,5 @@
>>   # SPDX-License-Identifier: GPL-2.0
>> -spinand-objs := core.o otp.o
>> +spinand-objs := core.o fmsh.o otp.o
> 
> You're adding a manufacturer driver in the middle of the core files. For
> now we kind of inforce an alphabetical order, so please move it below.

oops, sorry for that, I've sent v2 for it. Thank you!

Regards,
Tianling.

> 
>>   spinand-objs += alliancememory.o ato.o esmt.o foresee.o gigadevice.o
>>   macronix.o
> 
>                                                  ^
> Here
> 
>>   spinand-objs += micron.o paragon.o skyhigh.o toshiba.o winbond.o xtx.o
>>   obj-$(CONFIG_MTD_SPI_NAND) += spinand.o
>> diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c
>> index b0898990b2a5..ea47028d021a 100644
>> --- a/drivers/mtd/nand/spi/core.c
>> +++ b/drivers/mtd/nand/spi/core.c
>> @@ -1184,6 +1184,7 @@ static const struct spinand_manufacturer *spinand_manufacturers[] = {
>>   	&alliancememory_spinand_manufacturer,
>>   	&ato_spinand_manufacturer,
>>   	&esmt_c8_spinand_manufacturer,
>> +	&fmsh_spinand_manufacturer,
>>   	&foresee_spinand_manufacturer,
>>   	&gigadevice_spinand_manufacturer,
>>   	&macronix_spinand_manufacturer,
>> diff --git a/drivers/mtd/nand/spi/fmsh.c b/drivers/mtd/nand/spi/fmsh.c
>> new file mode 100644
>> index 000000000000..8b2097bfc771
>> --- /dev/null
>> +++ b/drivers/mtd/nand/spi/fmsh.c
> 
> Otherise the driver is simple enough, so v2 should make it :)
> 
> Thanks,
> Miquèl


^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH] mtd: spinand: add support for FudanMicro FM25S01A
@ 2025-10-30 19:07 Tianling Shen
  2025-11-01  4:20 ` Mikhail Kshevetskiy
  2025-11-01  4:24 ` Mikhail Kshevetskiy
  0 siblings, 2 replies; 10+ messages in thread
From: Tianling Shen @ 2025-10-30 19:07 UTC (permalink / raw)
  To: Tom Rini, Dario Binacchi, Michael Trimarchi, Frieder Schrempf,
	Mikhail Kshevetskiy, Tianling Shen
  Cc: u-boot

Add support for FudanMicro FM25S01A SPI NAND.

This driver is ported from linux v6.18 and tested on a MT7981 board.

Link: https://lore.kernel.org/linux-mtd/20250824170013.3328777-1-cnsztl@gmail.com/
Signed-off-by: Tianling Shen <cnsztl@gmail.com>
---
 drivers/mtd/nand/spi/Makefile |  2 +-
 drivers/mtd/nand/spi/fmsh.c   | 76 +++++++++++++++++++++++++++++++++++
 2 files changed, 77 insertions(+), 1 deletion(-)
 create mode 100644 drivers/mtd/nand/spi/fmsh.c

diff --git a/drivers/mtd/nand/spi/Makefile b/drivers/mtd/nand/spi/Makefile
index 152aa1a3783c..a7a0b2cb4b9e 100644
--- a/drivers/mtd/nand/spi/Makefile
+++ b/drivers/mtd/nand/spi/Makefile
@@ -1,6 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0
 
 spinand-objs := core.o otp.o
-spinand-objs += alliancememory.o ato.o esmt.o foresee.o gigadevice.o macronix.o
+spinand-objs += alliancememory.o ato.o esmt.o fmsh.o foresee.o gigadevice.o macronix.o
 spinand-objs += micron.o paragon.o skyhigh.o toshiba.o winbond.o xtx.o
 obj-$(CONFIG_MTD_SPI_NAND) += spinand.o
diff --git a/drivers/mtd/nand/spi/fmsh.c b/drivers/mtd/nand/spi/fmsh.c
new file mode 100644
index 000000000000..84a567919ebb
--- /dev/null
+++ b/drivers/mtd/nand/spi/fmsh.c
@@ -0,0 +1,76 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (c) 2020-2021 Rockchip Electronics Co., Ltd.
+ *
+ * Author: Dingqiang Lin <jon.lin@rock-chips.com>
+ */
+
+#ifndef __UBOOT__
+#include <linux/device.h>
+#include <linux/kernel.h>
+#endif
+#include <linux/mtd/spinand.h>
+
+#define SPINAND_MFR_FMSH		0xA1
+
+static SPINAND_OP_VARIANTS(read_cache_variants,
+		SPINAND_PAGE_READ_FROM_CACHE_1S_4S_4S_OP(0, 2, NULL, 0, 0),
+		SPINAND_PAGE_READ_FROM_CACHE_1S_1S_4S_OP(0, 1, NULL, 0, 0),
+		SPINAND_PAGE_READ_FROM_CACHE_1S_2S_2S_OP(0, 1, NULL, 0, 0),
+		SPINAND_PAGE_READ_FROM_CACHE_1S_1S_2S_OP(0, 1, NULL, 0, 0),
+		SPINAND_PAGE_READ_FROM_CACHE_FAST_1S_1S_1S_OP(0, 1, NULL, 0, 0),
+		SPINAND_PAGE_READ_FROM_CACHE_1S_1S_1S_OP(0, 1, NULL, 0, 0));
+
+static SPINAND_OP_VARIANTS(write_cache_variants,
+		SPINAND_PROG_LOAD_1S_1S_4S_OP(true, 0, NULL, 0),
+		SPINAND_PROG_LOAD_1S_1S_1S_OP(true, 0, NULL, 0));
+
+static SPINAND_OP_VARIANTS(update_cache_variants,
+		SPINAND_PROG_LOAD_1S_1S_4S_OP(false, 0, NULL, 0),
+		SPINAND_PROG_LOAD_1S_1S_1S_OP(false, 0, NULL, 0));
+
+static int fm25s01a_ooblayout_ecc(struct mtd_info *mtd, int section,
+				  struct mtd_oob_region *region)
+{
+	return -ERANGE;
+}
+
+static int fm25s01a_ooblayout_free(struct mtd_info *mtd, int section,
+				   struct mtd_oob_region *region)
+{
+	if (section)
+		return -ERANGE;
+
+	region->offset = 2;
+	region->length = 62;
+
+	return 0;
+}
+
+static const struct mtd_ooblayout_ops fm25s01a_ooblayout = {
+	.ecc = fm25s01a_ooblayout_ecc,
+	.rfree = fm25s01a_ooblayout_free,
+};
+
+static const struct spinand_info fmsh_spinand_table[] = {
+	SPINAND_INFO("FM25S01A",
+		     SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0xE4),
+		     NAND_MEMORG(1, 2048, 64, 64, 1024, 20, 1, 1, 1),
+		     NAND_ECCREQ(1, 512),
+		     SPINAND_INFO_OP_VARIANTS(&read_cache_variants,
+					      &write_cache_variants,
+					      &update_cache_variants),
+		     SPINAND_HAS_QE_BIT,
+		     SPINAND_ECCINFO(&fm25s01a_ooblayout, NULL)),
+};
+
+static const struct spinand_manufacturer_ops fmsh_spinand_manuf_ops = {
+};
+
+const struct spinand_manufacturer fmsh_spinand_manufacturer = {
+	.id = SPINAND_MFR_FMSH,
+	.name = "Fudan Micro",
+	.chips = fmsh_spinand_table,
+	.nchips = ARRAY_SIZE(fmsh_spinand_table),
+	.ops = &fmsh_spinand_manuf_ops,
+};
-- 
2.51.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread
* Re: [PATCH] mtd: spinand: add support for FudanMicro FM25S01A
  2025-10-30 19:07 Tianling Shen
@ 2025-11-01  4:20 ` Mikhail Kshevetskiy
  2025-11-01  5:17   ` Tianling Shen
  2025-11-01  4:24 ` Mikhail Kshevetskiy
  1 sibling, 1 reply; 10+ messages in thread
From: Mikhail Kshevetskiy @ 2025-11-01  4:20 UTC (permalink / raw)
  To: Tianling Shen, Tom Rini, Dario Binacchi, Michael Trimarchi,
	Frieder Schrempf
  Cc: u-boot

Hello Tianling, You forget to add fmsh manufacturer to
drivers/mtd/nand/spi/core.c and include/linux/mtd/spinand.h files.
Without these changes your code should not be used. Regards, Mikhail
Kshevetskiy

On 10/30/25 22:07, Tianling Shen wrote:
> [You don't often get email from cnsztl@gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> Add support for FudanMicro FM25S01A SPI NAND.
>
> This driver is ported from linux v6.18 and tested on a MT7981 board.
>
> Link: https://lore.kernel.org/linux-mtd/20250824170013.3328777-1-cnsztl@gmail.com/
> Signed-off-by: Tianling Shen <cnsztl@gmail.com>
> ---
>  drivers/mtd/nand/spi/Makefile |  2 +-
>  drivers/mtd/nand/spi/fmsh.c   | 76 +++++++++++++++++++++++++++++++++++
>  2 files changed, 77 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/mtd/nand/spi/fmsh.c
>
> diff --git a/drivers/mtd/nand/spi/Makefile b/drivers/mtd/nand/spi/Makefile
> index 152aa1a3783c..a7a0b2cb4b9e 100644
> --- a/drivers/mtd/nand/spi/Makefile
> +++ b/drivers/mtd/nand/spi/Makefile
> @@ -1,6 +1,6 @@
>  # SPDX-License-Identifier: GPL-2.0
>
>  spinand-objs := core.o otp.o
> -spinand-objs += alliancememory.o ato.o esmt.o foresee.o gigadevice.o macronix.o
> +spinand-objs += alliancememory.o ato.o esmt.o fmsh.o foresee.o gigadevice.o macronix.o
>  spinand-objs += micron.o paragon.o skyhigh.o toshiba.o winbond.o xtx.o
>  obj-$(CONFIG_MTD_SPI_NAND) += spinand.o
> diff --git a/drivers/mtd/nand/spi/fmsh.c b/drivers/mtd/nand/spi/fmsh.c
> new file mode 100644
> index 000000000000..84a567919ebb
> --- /dev/null
> +++ b/drivers/mtd/nand/spi/fmsh.c
> @@ -0,0 +1,76 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2020-2021 Rockchip Electronics Co., Ltd.
> + *
> + * Author: Dingqiang Lin <jon.lin@rock-chips.com>
> + */
> +
> +#ifndef __UBOOT__
> +#include <linux/device.h>
> +#include <linux/kernel.h>
> +#endif
> +#include <linux/mtd/spinand.h>
> +
> +#define SPINAND_MFR_FMSH               0xA1
> +
> +static SPINAND_OP_VARIANTS(read_cache_variants,
> +               SPINAND_PAGE_READ_FROM_CACHE_1S_4S_4S_OP(0, 2, NULL, 0, 0),
> +               SPINAND_PAGE_READ_FROM_CACHE_1S_1S_4S_OP(0, 1, NULL, 0, 0),
> +               SPINAND_PAGE_READ_FROM_CACHE_1S_2S_2S_OP(0, 1, NULL, 0, 0),
> +               SPINAND_PAGE_READ_FROM_CACHE_1S_1S_2S_OP(0, 1, NULL, 0, 0),
> +               SPINAND_PAGE_READ_FROM_CACHE_FAST_1S_1S_1S_OP(0, 1, NULL, 0, 0),
> +               SPINAND_PAGE_READ_FROM_CACHE_1S_1S_1S_OP(0, 1, NULL, 0, 0));
> +
> +static SPINAND_OP_VARIANTS(write_cache_variants,
> +               SPINAND_PROG_LOAD_1S_1S_4S_OP(true, 0, NULL, 0),
> +               SPINAND_PROG_LOAD_1S_1S_1S_OP(true, 0, NULL, 0));
> +
> +static SPINAND_OP_VARIANTS(update_cache_variants,
> +               SPINAND_PROG_LOAD_1S_1S_4S_OP(false, 0, NULL, 0),
> +               SPINAND_PROG_LOAD_1S_1S_1S_OP(false, 0, NULL, 0));
> +
> +static int fm25s01a_ooblayout_ecc(struct mtd_info *mtd, int section,
> +                                 struct mtd_oob_region *region)
> +{
> +       return -ERANGE;
> +}
> +
> +static int fm25s01a_ooblayout_free(struct mtd_info *mtd, int section,
> +                                  struct mtd_oob_region *region)
> +{
> +       if (section)
> +               return -ERANGE;
> +
> +       region->offset = 2;
> +       region->length = 62;
> +
> +       return 0;
> +}
> +
> +static const struct mtd_ooblayout_ops fm25s01a_ooblayout = {
> +       .ecc = fm25s01a_ooblayout_ecc,
> +       .rfree = fm25s01a_ooblayout_free,
> +};
> +
> +static const struct spinand_info fmsh_spinand_table[] = {
> +       SPINAND_INFO("FM25S01A",
> +                    SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0xE4),
> +                    NAND_MEMORG(1, 2048, 64, 64, 1024, 20, 1, 1, 1),
> +                    NAND_ECCREQ(1, 512),
> +                    SPINAND_INFO_OP_VARIANTS(&read_cache_variants,
> +                                             &write_cache_variants,
> +                                             &update_cache_variants),
> +                    SPINAND_HAS_QE_BIT,
> +                    SPINAND_ECCINFO(&fm25s01a_ooblayout, NULL)),
> +};
> +
> +static const struct spinand_manufacturer_ops fmsh_spinand_manuf_ops = {
> +};
> +
> +const struct spinand_manufacturer fmsh_spinand_manufacturer = {
> +       .id = SPINAND_MFR_FMSH,
> +       .name = "Fudan Micro",
> +       .chips = fmsh_spinand_table,
> +       .nchips = ARRAY_SIZE(fmsh_spinand_table),
> +       .ops = &fmsh_spinand_manuf_ops,
> +};
> --
> 2.51.1
>

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH] mtd: spinand: add support for FudanMicro FM25S01A
  2025-10-30 19:07 Tianling Shen
  2025-11-01  4:20 ` Mikhail Kshevetskiy
@ 2025-11-01  4:24 ` Mikhail Kshevetskiy
  1 sibling, 0 replies; 10+ messages in thread
From: Mikhail Kshevetskiy @ 2025-11-01  4:24 UTC (permalink / raw)
  To: Tianling Shen, Tom Rini, Dario Binacchi, Michael Trimarchi,
	Frieder Schrempf
  Cc: u-boot

Please also replace spaces with tab where possible

On 10/30/25 22:07, Tianling Shen wrote:
> [You don't often get email from cnsztl@gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> Add support for FudanMicro FM25S01A SPI NAND.
>
> This driver is ported from linux v6.18 and tested on a MT7981 board.
>
> Link: https://lore.kernel.org/linux-mtd/20250824170013.3328777-1-cnsztl@gmail.com/
> Signed-off-by: Tianling Shen <cnsztl@gmail.com>
> ---
>  drivers/mtd/nand/spi/Makefile |  2 +-
>  drivers/mtd/nand/spi/fmsh.c   | 76 +++++++++++++++++++++++++++++++++++
>  2 files changed, 77 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/mtd/nand/spi/fmsh.c
>
> diff --git a/drivers/mtd/nand/spi/Makefile b/drivers/mtd/nand/spi/Makefile
> index 152aa1a3783c..a7a0b2cb4b9e 100644
> --- a/drivers/mtd/nand/spi/Makefile
> +++ b/drivers/mtd/nand/spi/Makefile
> @@ -1,6 +1,6 @@
>  # SPDX-License-Identifier: GPL-2.0
>
>  spinand-objs := core.o otp.o
> -spinand-objs += alliancememory.o ato.o esmt.o foresee.o gigadevice.o macronix.o
> +spinand-objs += alliancememory.o ato.o esmt.o fmsh.o foresee.o gigadevice.o macronix.o
>  spinand-objs += micron.o paragon.o skyhigh.o toshiba.o winbond.o xtx.o
>  obj-$(CONFIG_MTD_SPI_NAND) += spinand.o
> diff --git a/drivers/mtd/nand/spi/fmsh.c b/drivers/mtd/nand/spi/fmsh.c
> new file mode 100644
> index 000000000000..84a567919ebb
> --- /dev/null
> +++ b/drivers/mtd/nand/spi/fmsh.c
> @@ -0,0 +1,76 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2020-2021 Rockchip Electronics Co., Ltd.
> + *
> + * Author: Dingqiang Lin <jon.lin@rock-chips.com>
> + */
> +
> +#ifndef __UBOOT__
> +#include <linux/device.h>
> +#include <linux/kernel.h>
> +#endif
> +#include <linux/mtd/spinand.h>
> +
> +#define SPINAND_MFR_FMSH               0xA1
> +
> +static SPINAND_OP_VARIANTS(read_cache_variants,
> +               SPINAND_PAGE_READ_FROM_CACHE_1S_4S_4S_OP(0, 2, NULL, 0, 0),
> +               SPINAND_PAGE_READ_FROM_CACHE_1S_1S_4S_OP(0, 1, NULL, 0, 0),
> +               SPINAND_PAGE_READ_FROM_CACHE_1S_2S_2S_OP(0, 1, NULL, 0, 0),
> +               SPINAND_PAGE_READ_FROM_CACHE_1S_1S_2S_OP(0, 1, NULL, 0, 0),
> +               SPINAND_PAGE_READ_FROM_CACHE_FAST_1S_1S_1S_OP(0, 1, NULL, 0, 0),
> +               SPINAND_PAGE_READ_FROM_CACHE_1S_1S_1S_OP(0, 1, NULL, 0, 0));
> +
> +static SPINAND_OP_VARIANTS(write_cache_variants,
> +               SPINAND_PROG_LOAD_1S_1S_4S_OP(true, 0, NULL, 0),
> +               SPINAND_PROG_LOAD_1S_1S_1S_OP(true, 0, NULL, 0));
> +
> +static SPINAND_OP_VARIANTS(update_cache_variants,
> +               SPINAND_PROG_LOAD_1S_1S_4S_OP(false, 0, NULL, 0),
> +               SPINAND_PROG_LOAD_1S_1S_1S_OP(false, 0, NULL, 0));
> +
> +static int fm25s01a_ooblayout_ecc(struct mtd_info *mtd, int section,
> +                                 struct mtd_oob_region *region)
> +{
> +       return -ERANGE;
> +}
> +
> +static int fm25s01a_ooblayout_free(struct mtd_info *mtd, int section,
> +                                  struct mtd_oob_region *region)
> +{
> +       if (section)
> +               return -ERANGE;
> +
> +       region->offset = 2;
> +       region->length = 62;
> +
> +       return 0;
> +}
> +
> +static const struct mtd_ooblayout_ops fm25s01a_ooblayout = {
> +       .ecc = fm25s01a_ooblayout_ecc,
> +       .rfree = fm25s01a_ooblayout_free,
> +};
> +
> +static const struct spinand_info fmsh_spinand_table[] = {
> +       SPINAND_INFO("FM25S01A",
> +                    SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0xE4),
> +                    NAND_MEMORG(1, 2048, 64, 64, 1024, 20, 1, 1, 1),
> +                    NAND_ECCREQ(1, 512),
> +                    SPINAND_INFO_OP_VARIANTS(&read_cache_variants,
> +                                             &write_cache_variants,
> +                                             &update_cache_variants),
> +                    SPINAND_HAS_QE_BIT,
> +                    SPINAND_ECCINFO(&fm25s01a_ooblayout, NULL)),
> +};
> +
> +static const struct spinand_manufacturer_ops fmsh_spinand_manuf_ops = {
> +};
> +
> +const struct spinand_manufacturer fmsh_spinand_manufacturer = {
> +       .id = SPINAND_MFR_FMSH,
> +       .name = "Fudan Micro",
> +       .chips = fmsh_spinand_table,
> +       .nchips = ARRAY_SIZE(fmsh_spinand_table),
> +       .ops = &fmsh_spinand_manuf_ops,
> +};
> --
> 2.51.1
>

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH] mtd: spinand: add support for FudanMicro FM25S01A
  2025-11-01  4:20 ` Mikhail Kshevetskiy
@ 2025-11-01  5:17   ` Tianling Shen
  0 siblings, 0 replies; 10+ messages in thread
From: Tianling Shen @ 2025-11-01  5:17 UTC (permalink / raw)
  To: Mikhail Kshevetskiy, Tom Rini, Dario Binacchi, Michael Trimarchi,
	Frieder Schrempf
  Cc: u-boot

Hi Mikhail,

On 2025/11/1 12:20, Mikhail Kshevetskiy wrote:
> Hello Tianling, You forget to add fmsh manufacturer to
> drivers/mtd/nand/spi/core.c and include/linux/mtd/spinand.h files.
> Without these changes your code should not be used. Regards, Mikhail
> Kshevetskiy

Oops sorry for the mistake! I forgot to do that when rebasing the patch.
Will send v2 soon, thank you!

 > Please also replace spaces with tab where possible

I already used tab for indentation, and the patchwork[1] does show it in 
tab format.

Thanks,
Tianling.

1. 
https://patchwork.ozlabs.org/project/uboot/patch/20251030190710.18848-1-cnsztl@gmail.com/

> 
> On 10/30/25 22:07, Tianling Shen wrote:
>> [You don't often get email from cnsztl@gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>>
>> Add support for FudanMicro FM25S01A SPI NAND.
>>
>> This driver is ported from linux v6.18 and tested on a MT7981 board.
>>
>> Link: https://lore.kernel.org/linux-mtd/20250824170013.3328777-1-cnsztl@gmail.com/
>> Signed-off-by: Tianling Shen <cnsztl@gmail.com>
>> ---
>>   drivers/mtd/nand/spi/Makefile |  2 +-
>>   drivers/mtd/nand/spi/fmsh.c   | 76 +++++++++++++++++++++++++++++++++++
>>   2 files changed, 77 insertions(+), 1 deletion(-)
>>   create mode 100644 drivers/mtd/nand/spi/fmsh.c
>>
>> diff --git a/drivers/mtd/nand/spi/Makefile b/drivers/mtd/nand/spi/Makefile
>> index 152aa1a3783c..a7a0b2cb4b9e 100644
>> --- a/drivers/mtd/nand/spi/Makefile
>> +++ b/drivers/mtd/nand/spi/Makefile
>> @@ -1,6 +1,6 @@
>>   # SPDX-License-Identifier: GPL-2.0
>>
>>   spinand-objs := core.o otp.o
>> -spinand-objs += alliancememory.o ato.o esmt.o foresee.o gigadevice.o macronix.o
>> +spinand-objs += alliancememory.o ato.o esmt.o fmsh.o foresee.o gigadevice.o macronix.o
>>   spinand-objs += micron.o paragon.o skyhigh.o toshiba.o winbond.o xtx.o
>>   obj-$(CONFIG_MTD_SPI_NAND) += spinand.o
>> diff --git a/drivers/mtd/nand/spi/fmsh.c b/drivers/mtd/nand/spi/fmsh.c
>> new file mode 100644
>> index 000000000000..84a567919ebb
>> --- /dev/null
>> +++ b/drivers/mtd/nand/spi/fmsh.c
>> @@ -0,0 +1,76 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * Copyright (c) 2020-2021 Rockchip Electronics Co., Ltd.
>> + *
>> + * Author: Dingqiang Lin <jon.lin@rock-chips.com>
>> + */
>> +
>> +#ifndef __UBOOT__
>> +#include <linux/device.h>
>> +#include <linux/kernel.h>
>> +#endif
>> +#include <linux/mtd/spinand.h>
>> +
>> +#define SPINAND_MFR_FMSH               0xA1
>> +
>> +static SPINAND_OP_VARIANTS(read_cache_variants,
>> +               SPINAND_PAGE_READ_FROM_CACHE_1S_4S_4S_OP(0, 2, NULL, 0, 0),
>> +               SPINAND_PAGE_READ_FROM_CACHE_1S_1S_4S_OP(0, 1, NULL, 0, 0),
>> +               SPINAND_PAGE_READ_FROM_CACHE_1S_2S_2S_OP(0, 1, NULL, 0, 0),
>> +               SPINAND_PAGE_READ_FROM_CACHE_1S_1S_2S_OP(0, 1, NULL, 0, 0),
>> +               SPINAND_PAGE_READ_FROM_CACHE_FAST_1S_1S_1S_OP(0, 1, NULL, 0, 0),
>> +               SPINAND_PAGE_READ_FROM_CACHE_1S_1S_1S_OP(0, 1, NULL, 0, 0));
>> +
>> +static SPINAND_OP_VARIANTS(write_cache_variants,
>> +               SPINAND_PROG_LOAD_1S_1S_4S_OP(true, 0, NULL, 0),
>> +               SPINAND_PROG_LOAD_1S_1S_1S_OP(true, 0, NULL, 0));
>> +
>> +static SPINAND_OP_VARIANTS(update_cache_variants,
>> +               SPINAND_PROG_LOAD_1S_1S_4S_OP(false, 0, NULL, 0),
>> +               SPINAND_PROG_LOAD_1S_1S_1S_OP(false, 0, NULL, 0));
>> +
>> +static int fm25s01a_ooblayout_ecc(struct mtd_info *mtd, int section,
>> +                                 struct mtd_oob_region *region)
>> +{
>> +       return -ERANGE;
>> +}
>> +
>> +static int fm25s01a_ooblayout_free(struct mtd_info *mtd, int section,
>> +                                  struct mtd_oob_region *region)
>> +{
>> +       if (section)
>> +               return -ERANGE;
>> +
>> +       region->offset = 2;
>> +       region->length = 62;
>> +
>> +       return 0;
>> +}
>> +
>> +static const struct mtd_ooblayout_ops fm25s01a_ooblayout = {
>> +       .ecc = fm25s01a_ooblayout_ecc,
>> +       .rfree = fm25s01a_ooblayout_free,
>> +};
>> +
>> +static const struct spinand_info fmsh_spinand_table[] = {
>> +       SPINAND_INFO("FM25S01A",
>> +                    SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0xE4),
>> +                    NAND_MEMORG(1, 2048, 64, 64, 1024, 20, 1, 1, 1),
>> +                    NAND_ECCREQ(1, 512),
>> +                    SPINAND_INFO_OP_VARIANTS(&read_cache_variants,
>> +                                             &write_cache_variants,
>> +                                             &update_cache_variants),
>> +                    SPINAND_HAS_QE_BIT,
>> +                    SPINAND_ECCINFO(&fm25s01a_ooblayout, NULL)),
>> +};
>> +
>> +static const struct spinand_manufacturer_ops fmsh_spinand_manuf_ops = {
>> +};
>> +
>> +const struct spinand_manufacturer fmsh_spinand_manufacturer = {
>> +       .id = SPINAND_MFR_FMSH,
>> +       .name = "Fudan Micro",
>> +       .chips = fmsh_spinand_table,
>> +       .nchips = ARRAY_SIZE(fmsh_spinand_table),
>> +       .ops = &fmsh_spinand_manuf_ops,
>> +};
>> --
>> 2.51.1
>>


^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2025-11-01  5:17 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-10 13:38 [PATCH] mtd: spinand: add support for FudanMicro FM25S01A Tianling Shen
2025-08-10 13:38 ` Tianling Shen
2025-08-24 15:46 ` Miquel Raynal
2025-08-24 15:46   ` Miquel Raynal
2025-08-24 17:04   ` Tianling Shen
2025-08-24 17:04     ` Tianling Shen
  -- strict thread matches above, loose matches on Subject: below --
2025-10-30 19:07 Tianling Shen
2025-11-01  4:20 ` Mikhail Kshevetskiy
2025-11-01  5:17   ` Tianling Shen
2025-11-01  4:24 ` Mikhail Kshevetskiy

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.