From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: "Mike Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@codeaurora.org>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
linux-arm-kernel@lists.infradead.org,
"Jason Cooper" <jason@lakedaemon.net>,
"Andrew Lunn" <andrew@lunn.ch>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
"Antoine Tenart" <antoine.tenart@bootlin.com>,
"Miquèl Raynal" <miquel.raynal@bootlin.com>,
"Maxime Chevallier" <maxime.chevallier@bootlin.com>
Subject: Re: [PATCH 3/6] clk: mvebu: add CPU clock driver for Armada 7K/8K
Date: Tue, 27 Nov 2018 17:27:40 +0100 [thread overview]
Message-ID: <87wooymqo3.fsf@bootlin.com> (raw)
In-Reply-To: <87y39tufwe.fsf@bootlin.com> (Gregory CLEMENT's message of "Fri, 16 Nov 2018 00:22:59 +0100")
Hi Stephen,
On ven., nov. 16 2018, Gregory CLEMENT <gregory.clement@bootlin.com> wrote:
>>> +static int ap_cpu_clock_probe(struct platform_device *pdev)
>>> +{
>>> + int ret, nclusters = 0, cluster_index = 0;
>>> + struct device *dev = &pdev->dev;
>>> + struct device_node *dn, *np = dev->of_node;
>>> + struct ap_cpu_clk *ap_cpu_clk;
>>> + struct regmap *regmap;
>>> +
>>> + regmap = syscon_node_to_regmap(np->parent);
>>
>> Can we just call dev_get_remap() on pdev->dev.parent?
>
> we could do regmap = dev_get_regmap(pdev->dev.parent, NULL); instead of
> this line. But is it really better?
Actually we can't, because we really depend on a syscon and at this
moment there is no regmap. It is the syscon_node_to_regmap function which
creates this regmap when needed.
Gregory
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: gregory.clement@bootlin.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/6] clk: mvebu: add CPU clock driver for Armada 7K/8K
Date: Tue, 27 Nov 2018 17:27:40 +0100 [thread overview]
Message-ID: <87wooymqo3.fsf@bootlin.com> (raw)
In-Reply-To: <87y39tufwe.fsf@bootlin.com> (Gregory CLEMENT's message of "Fri, 16 Nov 2018 00:22:59 +0100")
Hi Stephen,
On ven., nov. 16 2018, Gregory CLEMENT <gregory.clement@bootlin.com> wrote:
>>> +static int ap_cpu_clock_probe(struct platform_device *pdev)
>>> +{
>>> + int ret, nclusters = 0, cluster_index = 0;
>>> + struct device *dev = &pdev->dev;
>>> + struct device_node *dn, *np = dev->of_node;
>>> + struct ap_cpu_clk *ap_cpu_clk;
>>> + struct regmap *regmap;
>>> +
>>> + regmap = syscon_node_to_regmap(np->parent);
>>
>> Can we just call dev_get_remap() on pdev->dev.parent?
>
> we could do regmap = dev_get_regmap(pdev->dev.parent, NULL); instead of
> this line. But is it really better?
Actually we can't, because we really depend on a syscon and at this
moment there is no regmap. It is the syscon_node_to_regmap function which
creates this regmap when needed.
Gregory
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
next prev parent reply other threads:[~2018-11-27 16:27 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-22 18:17 [PATCH 0/6] Add CPU clock support for Armada 7K/8K Gregory CLEMENT
2018-09-22 18:17 ` Gregory CLEMENT
2018-09-22 18:17 ` [PATCH 1/6] dt-bindings: ap806: add the cluster clock node in the syscon file Gregory CLEMENT
2018-09-22 18:17 ` Gregory CLEMENT
2018-10-16 20:56 ` Stephen Boyd
2018-10-16 20:56 ` Stephen Boyd
2018-10-16 20:56 ` Stephen Boyd
2018-09-22 18:17 ` [PATCH 2/6] clk: mvebu: add helper file for Armada AP and CP clocks Gregory CLEMENT
2018-09-22 18:17 ` Gregory CLEMENT
2018-10-17 18:32 ` Stephen Boyd
2018-10-17 18:32 ` Stephen Boyd
2018-09-22 18:17 ` [PATCH 3/6] clk: mvebu: add CPU clock driver for Armada 7K/8K Gregory CLEMENT
2018-09-22 18:17 ` Gregory CLEMENT
2018-10-17 18:28 ` Stephen Boyd
2018-10-17 18:28 ` Stephen Boyd
2018-11-15 23:22 ` Gregory CLEMENT
2018-11-15 23:22 ` Gregory CLEMENT
2018-11-27 16:27 ` Gregory CLEMENT [this message]
2018-11-27 16:27 ` Gregory CLEMENT
2018-11-28 21:58 ` Stephen Boyd
2018-11-28 21:58 ` Stephen Boyd
2018-11-28 21:58 ` Stephen Boyd
2018-11-28 21:58 ` Stephen Boyd
2018-09-22 18:17 ` [PATCH 4/6] clk: mvebu: ap806: Fix clock name for the cluster Gregory CLEMENT
2018-09-22 18:17 ` Gregory CLEMENT
2018-10-17 18:28 ` Stephen Boyd
2018-10-17 18:28 ` Stephen Boyd
2018-11-23 14:42 ` Gregory CLEMENT
2018-11-23 14:42 ` Gregory CLEMENT
2018-11-28 22:00 ` Stephen Boyd
2018-11-28 22:00 ` Stephen Boyd
2018-09-22 18:17 ` [PATCH 5/6] arm64: marvell: enable the Armada 7K/8K CPU clk driver Gregory CLEMENT
2018-09-22 18:17 ` Gregory CLEMENT
2018-09-22 18:17 ` [PATCH 6/6] arm64: dts: marvell: Add cpu clock node on Armada 7K/8K Gregory CLEMENT
2018-09-22 18:17 ` Gregory CLEMENT
2018-10-12 17:42 ` Stephen Boyd
2018-10-12 17:42 ` Stephen Boyd
2018-11-23 15:02 ` Gregory CLEMENT
2018-11-23 15:02 ` Gregory CLEMENT
2018-11-28 22:03 ` Stephen Boyd
2018-11-28 22:03 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wooymqo3.fsf@bootlin.com \
--to=gregory.clement@bootlin.com \
--cc=andrew@lunn.ch \
--cc=antoine.tenart@bootlin.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=miquel.raynal@bootlin.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=sboyd@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.