From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Peng Hao <peng.hao2@zte.com.cn>
Cc: Peng Hao <peng.hao2@zte.com.cn>,
ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com,
rkrcmar@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com
Subject: Re: [PATCH V6 1/5] target/i386 : add coalesced pio support
Date: Wed, 17 Oct 2018 17:04:06 +0200 [thread overview]
Message-ID: <87woqgr4wp.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <1539795177-21038-2-git-send-email-peng.hao2@zte.com.cn>
Peng Hao <peng.hao2@zte.com.cn> writes:
> diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h
> index 83ba4eb..b5d4289 100644
> --- a/linux-headers/linux/kvm.h
> +++ b/linux-headers/linux/kvm.h
> @@ -420,13 +420,19 @@ struct kvm_run {
> struct kvm_coalesced_mmio_zone {
> __u64 addr;
> __u32 size;
> - __u32 pad;
> + union {
> + __u32 pad;
> + __u32 pio;
> + };
> };
I was just passing by, but what's the point in keeping 'pad'?
>
> struct kvm_coalesced_mmio {
> __u64 phys_addr;
> __u32 len;
> + unino {
'union' I would guess? How does it compile?
> __u32 pad;
> + __u32 pio;
> + };
> __u8 data[8];
> };
>
> @@ -953,6 +959,7 @@ struct kvm_ppc_resize_hpt {
> #define KVM_CAP_NESTED_STATE 157
> #define KVM_CAP_ARM_INJECT_SERROR_ESR 158
> #define KVM_CAP_MSR_PLATFORM_INFO 159
> +#define KVM_CAP_COALESCED_PIO 160
>
> #ifdef KVM_CAP_IRQ_ROUTING
--
Vitaly
WARNING: multiple messages have this Message-ID (diff)
From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Peng Hao <peng.hao2@zte.com.cn>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, pbonzini@redhat.com,
rkrcmar@redhat.com, mst@redhat.com, ehabkost@redhat.com
Subject: Re: [Qemu-devel] [PATCH V6 1/5] target/i386 : add coalesced pio support
Date: Wed, 17 Oct 2018 17:04:06 +0200 [thread overview]
Message-ID: <87woqgr4wp.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <1539795177-21038-2-git-send-email-peng.hao2@zte.com.cn>
Peng Hao <peng.hao2@zte.com.cn> writes:
> diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h
> index 83ba4eb..b5d4289 100644
> --- a/linux-headers/linux/kvm.h
> +++ b/linux-headers/linux/kvm.h
> @@ -420,13 +420,19 @@ struct kvm_run {
> struct kvm_coalesced_mmio_zone {
> __u64 addr;
> __u32 size;
> - __u32 pad;
> + union {
> + __u32 pad;
> + __u32 pio;
> + };
> };
I was just passing by, but what's the point in keeping 'pad'?
>
> struct kvm_coalesced_mmio {
> __u64 phys_addr;
> __u32 len;
> + unino {
'union' I would guess? How does it compile?
> __u32 pad;
> + __u32 pio;
> + };
> __u8 data[8];
> };
>
> @@ -953,6 +959,7 @@ struct kvm_ppc_resize_hpt {
> #define KVM_CAP_NESTED_STATE 157
> #define KVM_CAP_ARM_INJECT_SERROR_ESR 158
> #define KVM_CAP_MSR_PLATFORM_INFO 159
> +#define KVM_CAP_COALESCED_PIO 160
>
> #ifdef KVM_CAP_IRQ_ROUTING
--
Vitaly
next prev parent reply other threads:[~2018-10-17 15:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 16:52 [PATCH 0/5] target/i386: introduce coalesced pio Peng Hao
2018-10-17 16:52 ` [Qemu-devel] " Peng Hao
2018-10-17 16:52 ` [PATCH V6 1/5] target/i386 : add coalesced pio support Peng Hao
2018-10-17 16:52 ` [Qemu-devel] " Peng Hao
2018-10-17 15:04 ` Vitaly Kuznetsov [this message]
2018-10-17 15:04 ` Vitaly Kuznetsov
2018-10-17 17:05 ` Paolo Bonzini
2018-10-17 17:05 ` [Qemu-devel] " Paolo Bonzini
2018-10-17 16:52 ` [PATCH V6 2/5] target-i386 : add coalesced_pio API Peng Hao
2018-10-17 16:52 ` [Qemu-devel] " Peng Hao
2018-10-17 16:52 ` [PATCH V6 3/5] target-i386: add rtc 0x70 port as coalesced_pio Peng Hao
2018-10-17 16:52 ` [Qemu-devel] " Peng Hao
2018-10-17 10:31 ` Paolo Bonzini
2018-10-17 10:31 ` [Qemu-devel] " Paolo Bonzini
2018-10-18 8:03 ` peng.hao2
2018-10-18 8:03 ` [Qemu-devel] " peng.hao2
2018-10-18 10:13 ` Paolo Bonzini
2018-10-18 10:13 ` [Qemu-devel] " Paolo Bonzini
2018-10-18 10:43 ` peng.hao2
2018-10-18 10:43 ` [Qemu-devel] " peng.hao2
2018-10-17 16:52 ` [PATCH V6 4/5] target-i386: add i440fx 0xcf8 " Peng Hao
2018-10-17 16:52 ` [Qemu-devel] " Peng Hao
2018-10-17 16:52 ` [PATCH V6 5/5] target-i386: add q35 " Peng Hao
2018-10-17 16:52 ` [Qemu-devel] " Peng Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87woqgr4wp.fsf@vitty.brq.redhat.com \
--to=vkuznets@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peng.hao2@zte.com.cn \
--cc=qemu-devel@nongnu.org \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.