All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Vinay Simha <simhavcs@gmail.com>
Cc: open list <linux-kernel@vger.kernel.org>,
	"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
	Archit Taneja <archit.taneja@gmail.com>
Subject: Re: [PATCH 2/2] drm/dsi: Implement dcs backlight brightness
Date: Mon, 06 Jun 2016 21:04:36 +0300	[thread overview]
Message-ID: <87wpm26vnv.fsf@intel.com> (raw)
In-Reply-To: <CAGWqDJ7eU59foYTcqQ=PVM_13K-eJig21NZxQCn9_Vn_et+0eA@mail.gmail.com>

On Mon, 06 Jun 2016, Vinay Simha <simhavcs@gmail.com> wrote:
> On Mon, Jun 6, 2016 at 1:07 PM, Jani Nikula <jani.nikula@linux.intel.com> wrote:
>> On Thu, 02 Jun 2016, Vinay Simha BN <simhavcs@gmail.com> wrote:
>>> Provide a small convenience wrapper that set/get the
>>> backlight brightness control and creates the backlight
>>> device for the panel interface
>>
>> To be pedantic, we should downplay "backlight" in the DSI DCS brightness
>> control... there need not be a backlight, at all, for brightness control
>> (see AMOLED).
> but this jdi display and few other dsi display can be controlled by
> dcs commands

The point I was trying to convey was that the DSI DCS interface is
agnostic to the actual method of controlling brightness. Whether the
panel has a backlight to control brightness is a panel implementation
detail. So maybe we shouldn't have "backlight" in the interface
nomenclature either.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Vinay Simha <simhavcs@gmail.com>
Cc: open list <linux-kernel@vger.kernel.org>,
	"open list\:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
	Archit Taneja <archit.taneja@gmail.com>,
	Rob Clark <robdclark@gmail.com>,
	Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH 2/2] drm/dsi: Implement dcs backlight brightness
Date: Mon, 06 Jun 2016 21:04:36 +0300	[thread overview]
Message-ID: <87wpm26vnv.fsf@intel.com> (raw)
In-Reply-To: <CAGWqDJ7eU59foYTcqQ=PVM_13K-eJig21NZxQCn9_Vn_et+0eA@mail.gmail.com>

On Mon, 06 Jun 2016, Vinay Simha <simhavcs@gmail.com> wrote:
> On Mon, Jun 6, 2016 at 1:07 PM, Jani Nikula <jani.nikula@linux.intel.com> wrote:
>> On Thu, 02 Jun 2016, Vinay Simha BN <simhavcs@gmail.com> wrote:
>>> Provide a small convenience wrapper that set/get the
>>> backlight brightness control and creates the backlight
>>> device for the panel interface
>>
>> To be pedantic, we should downplay "backlight" in the DSI DCS brightness
>> control... there need not be a backlight, at all, for brightness control
>> (see AMOLED).
> but this jdi display and few other dsi display can be controlled by
> dcs commands

The point I was trying to convey was that the DSI DCS interface is
agnostic to the actual method of controlling brightness. Whether the
panel has a backlight to control brightness is a panel implementation
detail. So maybe we shouldn't have "backlight" in the interface
nomenclature either.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Technology Center

  reply	other threads:[~2016-06-06 18:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-02  1:48 [PATCH 1/2] drm/dsi: Implement set tear scanline Vinay Simha BN
2016-06-02  1:48 ` Vinay Simha BN
2016-06-02  1:48 ` [PATCH 2/2] drm/dsi: Implement dcs backlight brightness Vinay Simha BN
2016-06-02  1:48   ` Vinay Simha BN
2016-06-06  7:37   ` Jani Nikula
2016-06-06  7:37     ` Jani Nikula
2016-06-06 17:48     ` Vinay Simha
2016-06-06 18:04       ` Jani Nikula [this message]
2016-06-06 18:04         ` Jani Nikula
2016-06-06  7:23 ` [PATCH 1/2] drm/dsi: Implement set tear scanline Jani Nikula
2016-06-06  7:23   ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wpm26vnv.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=archit.taneja@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=simhavcs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.