All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Daniel Vetter <daniel.vetter@intel.com>, David Airlie <airlied@linux.ie>
Cc: Geliang Tang <geliangtang@163.com>,
	intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: fix kernel-doc warnings in i915_gem_gtt.c
Date: Wed, 16 Sep 2015 17:08:22 +0300	[thread overview]
Message-ID: <87wpvqtq21.fsf@intel.com> (raw)
In-Reply-To: <6d965fc0ee156ffa54de676203e9265939ea698e.1442350180.git.geliangtang@163.com>

On Tue, 15 Sep 2015, Geliang Tang <geliangtang@163.com> wrote:
> Fix the following 'make htmldocs' warnings:
>
>   .//drivers/gpu/drm/i915/i915_gem_gtt.c:758: warning: No description found for parameter 'length'
>   .//drivers/gpu/drm/i915/i915_gem_gtt.c:818: warning: No description found for parameter 'length'
>   .//drivers/gpu/drm/i915/i915_gem_gtt.c:818: warning: No description found for parameter 'new_pds'
>   .//drivers/gpu/drm/i915/i915_gem_gtt.c:758: warning: No description found for parameter 'length'
>   .//drivers/gpu/drm/i915/i915_gem_gtt.c:818: warning: No description found for parameter 'length'
>   .//drivers/gpu/drm/i915/i915_gem_gtt.c:818: warning: No description found for parameter 'new_pds'

These are already fixed by

commit d4ec9da0e17cb6a86c0b76c5b254981601d25031
Author: Michel Thierry <michel.thierry@intel.com>
Date:   Thu Jul 30 11:02:03 2015 +0100

    drm/i915/gen8: Abstract PDP usage

Thanks,
Jani.


>
> Signed-off-by: Geliang Tang <geliangtang@163.com>
> ---
>  drivers/gpu/drm/i915/i915_gem_gtt.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> index 96054a5..c070a1f 100644
> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> @@ -737,7 +737,7 @@ static void gen8_ppgtt_cleanup(struct i915_address_space *vm)
>   * @ppgtt:	Master ppgtt structure.
>   * @pd:		Page directory for this address range.
>   * @start:	Starting virtual address to begin allocations.
> - * @length	Size of the allocations.
> + * @length:	Size of the allocations.
>   * @new_pts:	Bitmap set by function with new allocations. Likely used by the
>   *		caller to free on error.
>   *
> @@ -792,8 +792,8 @@ unwind_out:
>   * @ppgtt:	Master ppgtt structure.
>   * @pdp:	Page directory pointer for this address range.
>   * @start:	Starting virtual address to begin allocations.
> - * @length	Size of the allocations.
> - * @new_pds	Bitmap set by function with new allocations. Likely used by the
> + * @length:	Size of the allocations.
> + * @new_pds:	Bitmap set by function with new allocations. Likely used by the
>   *		caller to free on error.
>   *
>   * Allocate the required number of page directories starting at the pde index of
> -- 
> 1.9.1
>
>

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Geliang Tang <geliangtang@163.com>,
	Daniel Vetter <daniel.vetter@intel.com>,
	David Airlie <airlied@linux.ie>
Cc: Geliang Tang <geliangtang@163.com>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/i915: fix kernel-doc warnings in i915_gem_gtt.c
Date: Wed, 16 Sep 2015 17:08:22 +0300	[thread overview]
Message-ID: <87wpvqtq21.fsf@intel.com> (raw)
In-Reply-To: <6d965fc0ee156ffa54de676203e9265939ea698e.1442350180.git.geliangtang@163.com>

On Tue, 15 Sep 2015, Geliang Tang <geliangtang@163.com> wrote:
> Fix the following 'make htmldocs' warnings:
>
>   .//drivers/gpu/drm/i915/i915_gem_gtt.c:758: warning: No description found for parameter 'length'
>   .//drivers/gpu/drm/i915/i915_gem_gtt.c:818: warning: No description found for parameter 'length'
>   .//drivers/gpu/drm/i915/i915_gem_gtt.c:818: warning: No description found for parameter 'new_pds'
>   .//drivers/gpu/drm/i915/i915_gem_gtt.c:758: warning: No description found for parameter 'length'
>   .//drivers/gpu/drm/i915/i915_gem_gtt.c:818: warning: No description found for parameter 'length'
>   .//drivers/gpu/drm/i915/i915_gem_gtt.c:818: warning: No description found for parameter 'new_pds'

These are already fixed by

commit d4ec9da0e17cb6a86c0b76c5b254981601d25031
Author: Michel Thierry <michel.thierry@intel.com>
Date:   Thu Jul 30 11:02:03 2015 +0100

    drm/i915/gen8: Abstract PDP usage

Thanks,
Jani.


>
> Signed-off-by: Geliang Tang <geliangtang@163.com>
> ---
>  drivers/gpu/drm/i915/i915_gem_gtt.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> index 96054a5..c070a1f 100644
> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> @@ -737,7 +737,7 @@ static void gen8_ppgtt_cleanup(struct i915_address_space *vm)
>   * @ppgtt:	Master ppgtt structure.
>   * @pd:		Page directory for this address range.
>   * @start:	Starting virtual address to begin allocations.
> - * @length	Size of the allocations.
> + * @length:	Size of the allocations.
>   * @new_pts:	Bitmap set by function with new allocations. Likely used by the
>   *		caller to free on error.
>   *
> @@ -792,8 +792,8 @@ unwind_out:
>   * @ppgtt:	Master ppgtt structure.
>   * @pdp:	Page directory pointer for this address range.
>   * @start:	Starting virtual address to begin allocations.
> - * @length	Size of the allocations.
> - * @new_pds	Bitmap set by function with new allocations. Likely used by the
> + * @length:	Size of the allocations.
> + * @new_pds:	Bitmap set by function with new allocations. Likely used by the
>   *		caller to free on error.
>   *
>   * Allocate the required number of page directories starting at the pde index of
> -- 
> 1.9.1
>
>

-- 
Jani Nikula, Intel Open Source Technology Center

  reply	other threads:[~2015-09-16 14:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-15 12:52 [PATCH] drm/i915: fix kernel-doc warnings in i915_gem_gtt.c Geliang Tang
2015-09-16 14:08 ` Jani Nikula [this message]
2015-09-16 14:08   ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wpvqtq21.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=airlied@linux.ie \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=geliangtang@163.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.