From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: Daiwei Li <daiweili@gmail.com>
Cc: sasha.neftin@intel.com, netdev@vger.kernel.org,
richardcochran@gmail.com, kurt@linutronix.de,
jesse.brandeburg@intel.com, linux-kernel@vger.kernel.org,
edumazet@google.com, intel-wired-lan@lists.osuosl.org,
jeffrey.t.kirsher@intel.com, kuba@kernel.org,
anthony.l.nguyen@intel.com, pabeni@redhat.com,
davem@davemloft.net
Subject: Re: [Intel-wired-lan] [iwl-net v2 2/2] igb: Fix missing time sync events
Date: Fri, 09 Aug 2024 09:38:58 -0700 [thread overview]
Message-ID: <87y155wt0d.fsf@intel.com> (raw)
In-Reply-To: <CAN0jFd1kO0MMtOh8N2Ztxn6f7vvDKp2h507sMryobkBKe=xk=w@mail.gmail.com>
Daiwei Li <daiweili@gmail.com> writes:
> Hi,
>
> It appears this change breaks PTP on the 82580 controller, as ptp4l reports:
>
>> timed out while polling for tx timestamp increasing tx_timestamp_timeout or
>> increasing kworker priority may correct this issue, but a driver bug likely
>> causes it
>
> The 82580 controller has a hardware bug in which reading TSICR doesn't clear
> it. See this thread
> https://lore.kernel.org/all/CDCB8BE0.1EC2C%25matthew.vick@intel.com/ where the
> bug was confirmed by an Intel employee. Any chance we could add back the ack
> for 82580 specifically? Thanks!
Of course, I'll prepare a patch for that.
Thanks for digging that one up.
Cheers,
--
Vinicius
WARNING: multiple messages have this Message-ID (diff)
From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: Daiwei Li <daiweili@gmail.com>
Cc: anthony.l.nguyen@intel.com, davem@davemloft.net,
edumazet@google.com, intel-wired-lan@lists.osuosl.org,
jeffrey.t.kirsher@intel.com, jesse.brandeburg@intel.com,
kuba@kernel.org, kurt@linutronix.de,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
pabeni@redhat.com, richardcochran@gmail.com,
sasha.neftin@intel.com
Subject: Re: [Intel-wired-lan] [iwl-net v2 2/2] igb: Fix missing time sync events
Date: Fri, 09 Aug 2024 09:38:58 -0700 [thread overview]
Message-ID: <87y155wt0d.fsf@intel.com> (raw)
In-Reply-To: <CAN0jFd1kO0MMtOh8N2Ztxn6f7vvDKp2h507sMryobkBKe=xk=w@mail.gmail.com>
Daiwei Li <daiweili@gmail.com> writes:
> Hi,
>
> It appears this change breaks PTP on the 82580 controller, as ptp4l reports:
>
>> timed out while polling for tx timestamp increasing tx_timestamp_timeout or
>> increasing kworker priority may correct this issue, but a driver bug likely
>> causes it
>
> The 82580 controller has a hardware bug in which reading TSICR doesn't clear
> it. See this thread
> https://lore.kernel.org/all/CDCB8BE0.1EC2C%25matthew.vick@intel.com/ where the
> bug was confirmed by an Intel employee. Any chance we could add back the ack
> for 82580 specifically? Thanks!
Of course, I'll prepare a patch for that.
Thanks for digging that one up.
Cheers,
--
Vinicius
next prev parent reply other threads:[~2024-08-09 16:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 5:42 [Intel-wired-lan] [iwl-net v2 2/2] igb: Fix missing time sync events Daiwei Li
2024-08-09 5:42 ` Daiwei Li
2024-08-09 16:38 ` Vinicius Costa Gomes [this message]
2024-08-09 16:38 ` Vinicius Costa Gomes
2024-08-09 21:04 ` Daiwei Li
2024-08-09 21:04 ` Daiwei Li
-- strict thread matches above, loose matches on Subject: below --
2024-02-20 23:57 [Intel-wired-lan] [iwl-net v2 0/2] igc/igb: " Vinicius Costa Gomes
2024-02-20 23:57 ` [Intel-wired-lan] [iwl-net v2 2/2] igb: " Vinicius Costa Gomes
2024-02-27 12:04 ` Pucha, HimasekharX Reddy
2024-02-27 12:04 ` Pucha, HimasekharX Reddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y155wt0d.fsf@intel.com \
--to=vinicius.gomes@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=daiweili@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=sasha.neftin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.