From: Marc Zyngier <maz@kernel.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: kexec@lists.infradead.org,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
James Morse <james.morse@arm.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Hanjun Guo <guohanjun@huawei.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Eric Biederman <ebiederm@xmission.com>,
Bhupesh SHARMA <bhupesh.sharma@linaro.org>,
AKASHI Takahiro <takahiro.akashi@linaro.org>,
Dave Young <dyoung@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Moritz Fischer <mdf@kernel.org>,
Android Kernel Team <kernel-team@android.com>,
"# 3.4.x" <stable@vger.kernel.org>
Subject: Re: [PATCH v2 1/5] arm64: kexec_file: Forbid non-crash kernels
Date: Tue, 01 Jun 2021 09:36:27 +0100 [thread overview]
Message-ID: <87y2bu0yno.wl-maz@kernel.org> (raw)
In-Reply-To: <CAMj1kXFNUAtXPzO+EbMzZQPxgst4BMEUuYbrWwYer3P9trYdLQ@mail.gmail.com>
On Mon, 31 May 2021 20:37:49 +0100,
Ard Biesheuvel <ardb@kernel.org> wrote:
>
> On Mon, 31 May 2021 at 11:57, Marc Zyngier <maz@kernel.org> wrote:
> >
> > It has been reported that kexec_file doesn't really work on arm64.
> > It completely ignores any of the existing reservations, which results
> > in the secondary kernel being loaded where the GICv3 LPI tables live,
> > or even corrupting the ACPI tables.
> >
> > Since only crash kernels are imune to this as they use a reserved
> > memory region, disable the non-crash kernel use case. Further
> > patches will try and restore the functionality.
> >
> > Reported-by: Moritz Fischer <mdf@kernel.org>
> > Signed-off-by: Marc Zyngier <maz@kernel.org>
> > Cc: stable@vger.kernel.org # 5.10
>
> Acked-by: Ard Biesheuvel <ardb@kernel.org>
>
> ... but do we really only need this in 5.10 and not earlier?
We *do* need something in earlier kernel (as mentioned in the cover
letter), but not this patch (arch_kexec_locate_mem_hole doesn't exist
there, so there is nothing to override).
I guess that completely disabling CONFIG_KEXEC_FILE on arm64 is the
way to go for 5.4 and earlier, as I don't think there is any crash
kernel support there.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: kexec@lists.infradead.org,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
James Morse <james.morse@arm.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Hanjun Guo <guohanjun@huawei.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Eric Biederman <ebiederm@xmission.com>,
Bhupesh SHARMA <bhupesh.sharma@linaro.org>,
AKASHI Takahiro <takahiro.akashi@linaro.org>,
Dave Young <dyoung@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Moritz Fischer <mdf@kernel.org>,
Android Kernel Team <kernel-team@android.com>,
"# 3.4.x" <stable@vger.kernel.org>
Subject: Re: [PATCH v2 1/5] arm64: kexec_file: Forbid non-crash kernels
Date: Tue, 01 Jun 2021 09:36:27 +0100 [thread overview]
Message-ID: <87y2bu0yno.wl-maz@kernel.org> (raw)
In-Reply-To: <CAMj1kXFNUAtXPzO+EbMzZQPxgst4BMEUuYbrWwYer3P9trYdLQ@mail.gmail.com>
On Mon, 31 May 2021 20:37:49 +0100,
Ard Biesheuvel <ardb@kernel.org> wrote:
>
> On Mon, 31 May 2021 at 11:57, Marc Zyngier <maz@kernel.org> wrote:
> >
> > It has been reported that kexec_file doesn't really work on arm64.
> > It completely ignores any of the existing reservations, which results
> > in the secondary kernel being loaded where the GICv3 LPI tables live,
> > or even corrupting the ACPI tables.
> >
> > Since only crash kernels are imune to this as they use a reserved
> > memory region, disable the non-crash kernel use case. Further
> > patches will try and restore the functionality.
> >
> > Reported-by: Moritz Fischer <mdf@kernel.org>
> > Signed-off-by: Marc Zyngier <maz@kernel.org>
> > Cc: stable@vger.kernel.org # 5.10
>
> Acked-by: Ard Biesheuvel <ardb@kernel.org>
>
> ... but do we really only need this in 5.10 and not earlier?
We *do* need something in earlier kernel (as mentioned in the cover
letter), but not this patch (arch_kexec_locate_mem_hole doesn't exist
there, so there is nothing to override).
I guess that completely disabling CONFIG_KEXEC_FILE on arm64 is the
way to go for 5.4 and earlier, as I don't think there is any crash
kernel support there.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: kexec@lists.infradead.org,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
James Morse <james.morse@arm.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Hanjun Guo <guohanjun@huawei.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Eric Biederman <ebiederm@xmission.com>,
Bhupesh SHARMA <bhupesh.sharma@linaro.org>,
AKASHI Takahiro <takahiro.akashi@linaro.org>,
Dave Young <dyoung@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Moritz Fischer <mdf@kernel.org>,
Android Kernel Team <kernel-team@android.com>,
"# 3.4.x" <stable@vger.kernel.org>
Subject: Re: [PATCH v2 1/5] arm64: kexec_file: Forbid non-crash kernels
Date: Tue, 01 Jun 2021 09:36:27 +0100 [thread overview]
Message-ID: <87y2bu0yno.wl-maz@kernel.org> (raw)
In-Reply-To: <CAMj1kXFNUAtXPzO+EbMzZQPxgst4BMEUuYbrWwYer3P9trYdLQ@mail.gmail.com>
On Mon, 31 May 2021 20:37:49 +0100,
Ard Biesheuvel <ardb@kernel.org> wrote:
>
> On Mon, 31 May 2021 at 11:57, Marc Zyngier <maz@kernel.org> wrote:
> >
> > It has been reported that kexec_file doesn't really work on arm64.
> > It completely ignores any of the existing reservations, which results
> > in the secondary kernel being loaded where the GICv3 LPI tables live,
> > or even corrupting the ACPI tables.
> >
> > Since only crash kernels are imune to this as they use a reserved
> > memory region, disable the non-crash kernel use case. Further
> > patches will try and restore the functionality.
> >
> > Reported-by: Moritz Fischer <mdf@kernel.org>
> > Signed-off-by: Marc Zyngier <maz@kernel.org>
> > Cc: stable@vger.kernel.org # 5.10
>
> Acked-by: Ard Biesheuvel <ardb@kernel.org>
>
> ... but do we really only need this in 5.10 and not earlier?
We *do* need something in earlier kernel (as mentioned in the cover
letter), but not this patch (arch_kexec_locate_mem_hole doesn't exist
there, so there is nothing to override).
I guess that completely disabling CONFIG_KEXEC_FILE on arm64 is the
way to go for 5.4 and earlier, as I don't think there is any crash
kernel support there.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2021-06-01 8:36 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 9:57 [PATCH v2 0/5] arm64: Make kexec_file_load honor iomem reservations Marc Zyngier
2021-05-31 9:57 ` Marc Zyngier
2021-05-31 9:57 ` Marc Zyngier
2021-05-31 9:57 ` [PATCH v2 1/5] arm64: kexec_file: Forbid non-crash kernels Marc Zyngier
2021-05-31 9:57 ` Marc Zyngier
2021-05-31 9:57 ` Marc Zyngier
2021-05-31 19:37 ` Ard Biesheuvel
2021-05-31 19:37 ` Ard Biesheuvel
2021-05-31 19:37 ` Ard Biesheuvel
2021-06-01 8:36 ` Marc Zyngier [this message]
2021-06-01 8:36 ` Marc Zyngier
2021-06-01 8:36 ` Marc Zyngier
2021-06-04 16:20 ` James Morse
2021-06-04 16:20 ` James Morse
2021-06-04 16:20 ` James Morse
2021-05-31 9:57 ` [PATCH v2 2/5] kexec_file: Make locate_mem_hole_callback global Marc Zyngier
2021-05-31 9:57 ` Marc Zyngier
2021-05-31 9:57 ` Marc Zyngier
2021-05-31 9:57 ` [PATCH v2 3/5] kernel/resource: Allow find_next_iomem_res() to exclude overlapping child resources Marc Zyngier
2021-05-31 9:57 ` Marc Zyngier
2021-05-31 9:57 ` Marc Zyngier
2021-05-31 9:57 ` [PATCH v2 4/5] kernel/resource: Introduce walk_system_ram_excluding_child_res() Marc Zyngier
2021-05-31 9:57 ` Marc Zyngier
2021-05-31 9:57 ` Marc Zyngier
2021-05-31 9:57 ` [PATCH v2 5/5] arm64: kexec_image: Restore full kexec functionnality Marc Zyngier
2021-05-31 9:57 ` Marc Zyngier
2021-05-31 9:57 ` Marc Zyngier
2021-05-31 19:36 ` [PATCH v2 0/5] arm64: Make kexec_file_load honor iomem reservations Ard Biesheuvel
2021-05-31 19:36 ` Ard Biesheuvel
2021-05-31 19:36 ` Ard Biesheuvel
2021-06-04 16:20 ` James Morse
2021-06-04 16:20 ` James Morse
2021-06-04 16:20 ` James Morse
2021-06-09 22:39 ` Moritz Fischer
2021-06-09 22:39 ` Moritz Fischer
2021-06-09 22:39 ` Moritz Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2bu0yno.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=bhupesh.sharma@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=guohanjun@huawei.com \
--cc=james.morse@arm.com \
--cc=kernel-team@android.com \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=mdf@kernel.org \
--cc=stable@vger.kernel.org \
--cc=sudeep.holla@arm.com \
--cc=takahiro.akashi@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.