From: Felipe Balbi <balbi@kernel.org>
To: Roger Quadros <rogerq@ti.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [v2] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume
Date: Fri, 16 Mar 2018 13:00:47 +0200 [thread overview]
Message-ID: <87y3isffog.fsf@linux.intel.com> (raw)
Hi,
Roger Quadros <rogerq@ti.com> writes:
> Hi Felipe,
>
> On 09/03/18 14:47, Roger Quadros wrote:
>> In the following test we get stuck by sleeping forever in _dwc3_set_mode()
>> after which dual-role switching doesn't work.
>>
>> On dra7-evm's dual-role port,
>> - Load g_zero gadget driver and enumerate to host
>> - suspend to mem
>> - disconnect USB cable to host and connect otg cable with Pen drive in it.
>> - resume system
>> - we sleep indefinitely in _dwc3_set_mode due to.
>> dwc3_gadget_exit()->usb_del_gadget_udc()->udc_stop()->
>> dwc3_gadget_stop()->wait_event_lock_irq()
>>
>> To fix this instead of waiting indefinitely with wait_event_lock_irq()
>> we use wait_event_interruptible_lock_irq_timeout() and print
>> and error message if there was a timeout.
>>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>
> Thanks for picking this for -next.
> Is it better to have this in v4.16-rc fixes?
> and also stable? v4.12+
Well, there was no "Fixes: foobar" or "Cc: stable" lines in the commit
log ;-)
The best we can do now, is wait for -rc1 and manually send the commit to
stable.
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@kernel.org>
To: Roger Quadros <rogerq@ti.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume
Date: Fri, 16 Mar 2018 13:00:47 +0200 [thread overview]
Message-ID: <87y3isffog.fsf@linux.intel.com> (raw)
In-Reply-To: <69517684-bd39-e945-0c9e-ccd52b8050d5@ti.com>
Hi,
Roger Quadros <rogerq@ti.com> writes:
> Hi Felipe,
>
> On 09/03/18 14:47, Roger Quadros wrote:
>> In the following test we get stuck by sleeping forever in _dwc3_set_mode()
>> after which dual-role switching doesn't work.
>>
>> On dra7-evm's dual-role port,
>> - Load g_zero gadget driver and enumerate to host
>> - suspend to mem
>> - disconnect USB cable to host and connect otg cable with Pen drive in it.
>> - resume system
>> - we sleep indefinitely in _dwc3_set_mode due to.
>> dwc3_gadget_exit()->usb_del_gadget_udc()->udc_stop()->
>> dwc3_gadget_stop()->wait_event_lock_irq()
>>
>> To fix this instead of waiting indefinitely with wait_event_lock_irq()
>> we use wait_event_interruptible_lock_irq_timeout() and print
>> and error message if there was a timeout.
>>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>
> Thanks for picking this for -next.
> Is it better to have this in v4.16-rc fixes?
> and also stable? v4.12+
Well, there was no "Fixes: foobar" or "Cc: stable" lines in the commit
log ;-)
The best we can do now, is wait for -rc1 and manually send the commit to
stable.
--
balbi
next reply other threads:[~2018-03-16 11:00 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 11:00 Felipe Balbi [this message]
2018-03-16 11:00 ` [PATCH v2] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume Felipe Balbi
-- strict thread matches above, loose matches on Subject: below --
2018-04-10 7:31 [v2] " Felipe Balbi
2018-04-10 7:31 ` [PATCH v2] " Felipe Balbi
2018-04-10 6:29 [v2] " Minas Harutyunyan
2018-04-10 6:29 ` [PATCH v2] " Minas Harutyunyan
2018-03-19 13:53 [v2] " Minas Harutyunyan
2018-03-19 13:53 ` [PATCH v2] " Minas Harutyunyan
2018-03-19 11:36 [v2] " Minas Harutyunyan
2018-03-19 11:36 ` [PATCH v2] " Minas Harutyunyan
2018-03-19 8:54 [v2] " Felipe Balbi
2018-03-19 8:54 ` [PATCH v2] " Felipe Balbi
2018-03-17 6:33 [v2] " Minas Harutyunyan
2018-03-17 6:33 ` [PATCH v2] " Minas Harutyunyan
2018-03-16 12:25 [v2] " Felipe Balbi
2018-03-16 12:25 ` [PATCH v2] " Felipe Balbi
2018-03-16 11:43 [v2] " Minas Harutyunyan
2018-03-16 11:43 ` [PATCH v2] " Minas Harutyunyan
2018-03-16 11:03 [v2] " Roger Quadros
2018-03-16 11:03 ` [PATCH v2] " Roger Quadros
2018-03-16 10:34 [v2] " Roger Quadros
2018-03-16 10:34 ` [PATCH v2] " Roger Quadros
2018-03-09 12:47 [v2] " Roger Quadros
2018-03-09 12:47 ` [PATCH v2] " Roger Quadros
2018-03-09 10:39 Felipe Balbi
2018-03-09 10:39 ` [PATCH] " Felipe Balbi
2018-03-09 10:36 Felipe Balbi
2018-03-09 10:36 ` [PATCH] " Felipe Balbi
2018-03-09 9:49 Roger Quadros
2018-03-09 9:49 ` [PATCH] " Roger Quadros
2018-03-09 9:26 Roger Quadros
2018-03-09 9:26 ` [PATCH] " Roger Quadros
2018-03-09 9:23 Felipe Balbi
2018-03-09 9:23 ` [PATCH] " Felipe Balbi
2018-03-09 9:19 Roger Quadros
2018-03-09 9:19 ` [PATCH] " Roger Quadros
2018-03-05 11:27 Felipe Balbi
2018-03-05 11:27 ` [PATCH] " Felipe Balbi
2018-03-05 11:25 Felipe Balbi
2018-03-05 11:25 ` [PATCH] " Felipe Balbi
2018-03-05 11:25 Baolin Wang
2018-03-05 11:25 ` [PATCH] " Baolin Wang
2018-03-05 11:14 Roger Quadros
2018-03-05 11:14 ` [PATCH] " Roger Quadros
2018-03-05 11:06 Felipe Balbi
2018-03-05 11:06 ` [PATCH] " Felipe Balbi
2018-03-05 11:03 Roger Quadros
2018-03-05 11:03 ` [PATCH] " Roger Quadros
2018-03-05 10:41 Baolin Wang
2018-03-05 10:41 ` [PATCH] " Baolin Wang
2018-03-05 9:45 Roger Quadros
2018-03-05 9:45 ` [PATCH] " Roger Quadros
2018-03-05 8:49 Felipe Balbi
2018-03-05 8:49 ` [PATCH] " Felipe Balbi
2018-02-28 9:59 Roger Quadros
2018-02-28 9:59 ` [PATCH] " Roger Quadros
2018-02-28 9:55 Roger Quadros
2018-02-28 9:55 ` [PATCH] " Roger Quadros
2018-02-28 7:53 Felipe Balbi
2018-02-28 7:53 ` [PATCH] " Felipe Balbi
2018-02-28 3:04 Baolin Wang
2018-02-28 3:04 ` [PATCH] " Baolin Wang
2018-02-27 11:22 Roger Quadros
2018-02-27 11:22 ` [PATCH] " Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3isffog.fsf@linux.intel.com \
--to=balbi@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rogerq@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.