From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: jlu@pengutronix.de, linux@armlinux.org.uk, bp@alien8.de,
linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org, Jason Cooper <jason@lakedaemon.net>,
Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org
Subject: [1/3] ARM: dts: enable L2 cache parity and ecc on db-xc3-24g4xg board
Date: Wed, 10 Jan 2018 09:24:04 +0100 [thread overview]
Message-ID: <87y3l66s0r.fsf@free-electrons.com> (raw)
Hi Chris,
On mar., janv. 09 2018, Chris Packham <chris.packham@alliedtelesis.co.nz> wrote:
Could you have add a (even small) message in the commit log?
Also could you improve the title by specify that it applies on
armada-xp, like this:
ARM: dts: armada-xp: enable L2 cache parity and ecc on db-xc3-24g4xg
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
> arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts b/arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts
> index 06fce35d7491..00ca489fc788 100644
> --- a/arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts
> +++ b/arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts
> @@ -70,6 +70,11 @@
> };
> };
>
> +&L2 {
> + arm,parity-enable;
> + marvell,ecc-enable;
It is not a problem for me to already applied the device tree change
even if the driver is not merged yet. But I would like to have an
acked-by on this new property by either a device tree maintainer or at
least the EDAC maintainer, of course having both acked-by would be
perfect ! :)
Thanks,
Gregory
> +};
> +
> &devbus_bootcs {
> status = "okay";
>
> --
> 2.15.1
>
WARNING: multiple messages have this Message-ID (diff)
From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ARM: dts: enable L2 cache parity and ecc on db-xc3-24g4xg board
Date: Wed, 10 Jan 2018 09:24:04 +0100 [thread overview]
Message-ID: <87y3l66s0r.fsf@free-electrons.com> (raw)
In-Reply-To: <20180108223158.21930-2-chris.packham@alliedtelesis.co.nz> (Chris Packham's message of "Tue, 9 Jan 2018 11:31:56 +1300")
Hi Chris,
On mar., janv. 09 2018, Chris Packham <chris.packham@alliedtelesis.co.nz> wrote:
Could you have add a (even small) message in the commit log?
Also could you improve the title by specify that it applies on
armada-xp, like this:
ARM: dts: armada-xp: enable L2 cache parity and ecc on db-xc3-24g4xg
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
> arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts b/arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts
> index 06fce35d7491..00ca489fc788 100644
> --- a/arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts
> +++ b/arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts
> @@ -70,6 +70,11 @@
> };
> };
>
> +&L2 {
> + arm,parity-enable;
> + marvell,ecc-enable;
It is not a problem for me to already applied the device tree change
even if the driver is not merged yet. But I would like to have an
acked-by on this new property by either a device tree maintainer or at
least the EDAC maintainer, of course having both acked-by would be
perfect ! :)
Thanks,
Gregory
> +};
> +
> &devbus_bootcs {
> status = "okay";
>
> --
> 2.15.1
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: jlu@pengutronix.de, linux@armlinux.org.uk, bp@alien8.de,
linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org, Jason Cooper <jason@lakedaemon.net>,
Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/3] ARM: dts: enable L2 cache parity and ecc on db-xc3-24g4xg board
Date: Wed, 10 Jan 2018 09:24:04 +0100 [thread overview]
Message-ID: <87y3l66s0r.fsf@free-electrons.com> (raw)
In-Reply-To: <20180108223158.21930-2-chris.packham@alliedtelesis.co.nz> (Chris Packham's message of "Tue, 9 Jan 2018 11:31:56 +1300")
Hi Chris,
On mar., janv. 09 2018, Chris Packham <chris.packham@alliedtelesis.co.nz> wrote:
Could you have add a (even small) message in the commit log?
Also could you improve the title by specify that it applies on
armada-xp, like this:
ARM: dts: armada-xp: enable L2 cache parity and ecc on db-xc3-24g4xg
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
> arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts b/arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts
> index 06fce35d7491..00ca489fc788 100644
> --- a/arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts
> +++ b/arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts
> @@ -70,6 +70,11 @@
> };
> };
>
> +&L2 {
> + arm,parity-enable;
> + marvell,ecc-enable;
It is not a problem for me to already applied the device tree change
even if the driver is not merged yet. But I would like to have an
acked-by on this new property by either a device tree maintainer or at
least the EDAC maintainer, of course having both acked-by would be
perfect ! :)
Thanks,
Gregory
> +};
> +
> &devbus_bootcs {
> status = "okay";
>
> --
> 2.15.1
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next reply other threads:[~2018-01-10 8:24 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 8:24 Gregory CLEMENT [this message]
2018-01-10 8:24 ` [PATCH 1/3] ARM: dts: enable L2 cache parity and ecc on db-xc3-24g4xg board Gregory CLEMENT
2018-01-10 8:24 ` Gregory CLEMENT
-- strict thread matches above, loose matches on Subject: below --
2018-01-11 9:06 [2/3] ARM: dts: mvebu: add sdram controller node to Armada-38x Gregory CLEMENT
2018-01-11 9:06 ` [PATCH 2/3] " Gregory CLEMENT
2018-01-11 9:06 ` Gregory CLEMENT
2018-01-11 9:06 ` Gregory CLEMENT
2018-01-10 20:19 [2/3] " Chris Packham
2018-01-10 20:19 ` [PATCH 2/3] " Chris Packham
2018-01-10 20:19 ` Chris Packham
2018-01-10 20:08 [1/3] ARM: dts: enable L2 cache parity and ecc on db-xc3-24g4xg board Chris Packham
2018-01-10 20:08 ` [PATCH 1/3] " Chris Packham
2018-01-10 20:08 ` Chris Packham
2018-01-10 8:31 [2/3] ARM: dts: mvebu: add sdram controller node to Armada-38x Gregory CLEMENT
2018-01-10 8:31 ` [PATCH 2/3] " Gregory CLEMENT
2018-01-10 8:31 ` Gregory CLEMENT
2018-01-10 8:31 ` Gregory CLEMENT
2018-01-08 22:31 [3/3] EDAC: armada_xp: Add support for more SoCs Chris Packham
2018-01-08 22:31 ` [PATCH 3/3] " Chris Packham
2018-01-08 22:31 ` Chris Packham
2018-01-08 22:31 [2/3] ARM: dts: mvebu: add sdram controller node to Armada-38x Chris Packham
2018-01-08 22:31 ` [PATCH 2/3] " Chris Packham
2018-01-08 22:31 ` Chris Packham
2018-01-08 22:31 [1/3] ARM: dts: enable L2 cache parity and ecc on db-xc3-24g4xg board Chris Packham
2018-01-08 22:31 ` [PATCH 1/3] " Chris Packham
2018-01-08 22:31 ` Chris Packham
2018-01-08 22:31 ` Chris Packham
2018-01-08 22:31 [PATCH 0/3] EDAC: support for Armada 38x and 98dx3236 SoCs Chris Packham
2018-01-08 22:31 ` Chris Packham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3l66s0r.fsf@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=bp@alien8.de \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=jlu@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.