All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Anholt <eric@anholt.net>
To: Colin King <colin.king@canonical.com>,
	David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/vc4: clean up error handling on devm_kzalloc failure
Date: Fri, 08 Sep 2017 18:08:18 +0000	[thread overview]
Message-ID: <87y3ppm5bh.fsf@anholt.net> (raw)
In-Reply-To: <20170908131704.32517-1-colin.king@canonical.com>

[-- Attachment #1: Type: text/plain, Size: 496 bytes --]

Colin King <colin.king@canonical.com> writes:

> From: Colin Ian King <colin.king@canonical.com>
>
> The current error handling on devm_kzalloc failures performs a non-null
> check on connector. Thss check is redundant because connector is null
> at that failure point.  With this check removed, we may as well make
> the failure path into a trivial -ENOMEM return to clean up the error
> handling.
>
> Detected by CoverityScan CID#1339527 ("Logically dead code")

Reviewed and applied.  Thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Eric Anholt <eric@anholt.net>
To: Colin King <colin.king@canonical.com>,
	David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/vc4: clean up error handling on devm_kzalloc failure
Date: Fri, 08 Sep 2017 11:08:18 -0700	[thread overview]
Message-ID: <87y3ppm5bh.fsf@anholt.net> (raw)
In-Reply-To: <20170908131704.32517-1-colin.king@canonical.com>


[-- Attachment #1.1: Type: text/plain, Size: 496 bytes --]

Colin King <colin.king@canonical.com> writes:

> From: Colin Ian King <colin.king@canonical.com>
>
> The current error handling on devm_kzalloc failures performs a non-null
> check on connector. Thss check is redundant because connector is null
> at that failure point.  With this check removed, we may as well make
> the failure path into a trivial -ENOMEM return to clean up the error
> handling.
>
> Detected by CoverityScan CID#1339527 ("Logically dead code")

Reviewed and applied.  Thanks!

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Eric Anholt <eric@anholt.net>
To: Colin King <colin.king@canonical.com>,
	David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/vc4: clean up error handling on devm_kzalloc failure
Date: Fri, 08 Sep 2017 11:08:18 -0700	[thread overview]
Message-ID: <87y3ppm5bh.fsf@anholt.net> (raw)
In-Reply-To: <20170908131704.32517-1-colin.king@canonical.com>

[-- Attachment #1: Type: text/plain, Size: 496 bytes --]

Colin King <colin.king@canonical.com> writes:

> From: Colin Ian King <colin.king@canonical.com>
>
> The current error handling on devm_kzalloc failures performs a non-null
> check on connector. Thss check is redundant because connector is null
> at that failure point.  With this check removed, we may as well make
> the failure path into a trivial -ENOMEM return to clean up the error
> handling.
>
> Detected by CoverityScan CID#1339527 ("Logically dead code")

Reviewed and applied.  Thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  parent reply	other threads:[~2017-09-08 18:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-08 13:17 [PATCH] drm/vc4: clean up error handling on devm_kzalloc failure Colin King
2017-09-08 13:17 ` Colin King
2017-09-08 13:17 ` Colin King
2017-09-08 13:39 ` Eric Engestrom
2017-09-08 13:39   ` Eric Engestrom
2017-09-08 13:39   ` Eric Engestrom
2017-09-08 13:45 ` Emil Velikov
2017-09-08 13:45   ` Emil Velikov
2017-09-08 13:45   ` Emil Velikov
2017-09-08 18:08 ` Eric Anholt [this message]
2017-09-08 18:08   ` Eric Anholt
2017-09-08 18:08   ` Eric Anholt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y3ppm5bh.fsf@anholt.net \
    --to=eric@anholt.net \
    --cc=airlied@linux.ie \
    --cc=colin.king@canonical.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.