All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>, Rainer Hochecker <fernetmenta@kodi.tv>
Cc: ben@bwidawsk.net, intel-gfx@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	fernetmenta@online.de, Eric.Engestrom@imgtec.com
Subject: Re: [PATCH v2] drm: add fourcc codes for 16bit R and GR
Date: Wed, 04 Jan 2017 11:06:09 +0200	[thread overview]
Message-ID: <87y3yrgpoe.fsf@intel.com> (raw)
In-Reply-To: <20170104085201.av3shack7hd74ubs@phenom.ffwll.local>

On Wed, 04 Jan 2017, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Tue, Jan 03, 2017 at 08:02:07PM +0100, Rainer Hochecker wrote:
>> From: Rainer Hochecker <fernetmenta@online.de>
>> 
>> Now sent with git send-email:
>> 
>> Signed-off-by: Rainer Hochecker <fernetmenta@online.de>
>> ---
>>  include/uapi/drm/drm_fourcc.h | 7 +++++++
>>  1 file changed, 7 insertions(+)
>> 
>> diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
>> index a5890bf..f1ef9cb 100644
>> --- a/include/uapi/drm/drm_fourcc.h
>> +++ b/include/uapi/drm/drm_fourcc.h
>> @@ -41,10 +41,17 @@ extern "C" {
>>  /* 8 bpp Red */
>>  #define DRM_FORMAT_R8		fourcc_code('R', '8', ' ', ' ') /* [7:0] R */
>>  
>> +/* 16 bpp Red */
>> +#define DRM_FORMAT_R16		fourcc_code('R', '1', '6', ' ') /* [15:0] R */
>> +
>>  /* 16 bpp RG */
>>  #define DRM_FORMAT_RG88		fourcc_code('R', 'G', '8', '8') /* [15:0] R:G 8:8 little endian */
>>  #define DRM_FORMAT_GR88		fourcc_code('G', 'R', '8', '8') /* [15:0] G:R 8:8 little endian */
>>  
>> +/* 32 bpp GR */
>> +#define DRM_FORMAT_RG32		fourcc_code('R', 'G', '3', '2') /* [31:0] G:R 16:16 little endian */
>> +#define DRM_FORMAT_GR32		fourcc_code('G', 'R', '3', '2') /* [31:0] G:R 16:16 little endian */
>
> Now the define's name is inconsistent, since that would suggest a 5 bpp
> format with 3 bits for R and 2 bits for G. I think what we want here for
> consistency is _RG16_16 and _GR16_16, along the lines of what Ville
> suggested.
>
> Sorry that this is such a bikeshed heaven ;-)

If there's going to be another version, please fix the commit message
while at it. "Now sent with git send-email" is useless for posterity.

BR,
Jani.


> -Daniel
>
>> +
>>  /* 8 bpp RGB */
>>  #define DRM_FORMAT_RGB332	fourcc_code('R', 'G', 'B', '8') /* [7:0] R:G:B 3:3:2 */
>>  #define DRM_FORMAT_BGR233	fourcc_code('B', 'G', 'R', '8') /* [7:0] B:G:R 2:3:3 */
>> -- 
>> 2.9.3
>> 

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>, Rainer Hochecker <fernetmenta@kodi.tv>
Cc: ben@bwidawsk.net, intel-gfx@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	fernetmenta@online.de, Eric.Engestrom@imgtec.com
Subject: Re: [Intel-gfx] [PATCH v2] drm: add fourcc codes for 16bit R and GR
Date: Wed, 04 Jan 2017 11:06:09 +0200	[thread overview]
Message-ID: <87y3yrgpoe.fsf@intel.com> (raw)
In-Reply-To: <20170104085201.av3shack7hd74ubs@phenom.ffwll.local>

On Wed, 04 Jan 2017, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Tue, Jan 03, 2017 at 08:02:07PM +0100, Rainer Hochecker wrote:
>> From: Rainer Hochecker <fernetmenta@online.de>
>> 
>> Now sent with git send-email:
>> 
>> Signed-off-by: Rainer Hochecker <fernetmenta@online.de>
>> ---
>>  include/uapi/drm/drm_fourcc.h | 7 +++++++
>>  1 file changed, 7 insertions(+)
>> 
>> diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
>> index a5890bf..f1ef9cb 100644
>> --- a/include/uapi/drm/drm_fourcc.h
>> +++ b/include/uapi/drm/drm_fourcc.h
>> @@ -41,10 +41,17 @@ extern "C" {
>>  /* 8 bpp Red */
>>  #define DRM_FORMAT_R8		fourcc_code('R', '8', ' ', ' ') /* [7:0] R */
>>  
>> +/* 16 bpp Red */
>> +#define DRM_FORMAT_R16		fourcc_code('R', '1', '6', ' ') /* [15:0] R */
>> +
>>  /* 16 bpp RG */
>>  #define DRM_FORMAT_RG88		fourcc_code('R', 'G', '8', '8') /* [15:0] R:G 8:8 little endian */
>>  #define DRM_FORMAT_GR88		fourcc_code('G', 'R', '8', '8') /* [15:0] G:R 8:8 little endian */
>>  
>> +/* 32 bpp GR */
>> +#define DRM_FORMAT_RG32		fourcc_code('R', 'G', '3', '2') /* [31:0] G:R 16:16 little endian */
>> +#define DRM_FORMAT_GR32		fourcc_code('G', 'R', '3', '2') /* [31:0] G:R 16:16 little endian */
>
> Now the define's name is inconsistent, since that would suggest a 5 bpp
> format with 3 bits for R and 2 bits for G. I think what we want here for
> consistency is _RG16_16 and _GR16_16, along the lines of what Ville
> suggested.
>
> Sorry that this is such a bikeshed heaven ;-)

If there's going to be another version, please fix the commit message
while at it. "Now sent with git send-email" is useless for posterity.

BR,
Jani.


> -Daniel
>
>> +
>>  /* 8 bpp RGB */
>>  #define DRM_FORMAT_RGB332	fourcc_code('R', 'G', 'B', '8') /* [7:0] R:G:B 3:3:2 */
>>  #define DRM_FORMAT_BGR233	fourcc_code('B', 'G', 'R', '8') /* [7:0] B:G:R 2:3:3 */
>> -- 
>> 2.9.3
>> 

-- 
Jani Nikula, Intel Open Source Technology Center

  reply	other threads:[~2017-01-04  9:06 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-02 10:41 [PATCH] drm: add fourcc codes for 16bit R and GR Rainer Hochecker
2017-01-02 12:23 ` David Herrmann
2017-01-02 14:05   ` Ville Syrjälä
2017-01-02 14:26     ` Rainer Hochecker
2017-01-02 14:31     ` Rainer Hochecker
2017-01-03 16:56       ` Rainer Hochecker
2017-01-03 18:21         ` Eric Engestrom
2017-01-03 18:21           ` Eric Engestrom
2017-01-03 19:02         ` [PATCH v2] " Rainer Hochecker
2017-01-04  8:52           ` Daniel Vetter
2017-01-04  8:52             ` Daniel Vetter
2017-01-04  9:06             ` Jani Nikula [this message]
2017-01-04  9:06               ` [Intel-gfx] " Jani Nikula
2017-01-04 10:19               ` Eric Engestrom
2017-01-04 10:19                 ` [Intel-gfx] " Eric Engestrom
2017-01-04  9:23         ` ✓ Fi.CI.BAT: success for " Patchwork
2017-01-04 13:45         ` [PATCH v3] drm: add fourcc codes for 16bit R and RG Rainer Hochecker
2017-01-04 13:45           ` Rainer Hochecker
2017-01-04 13:50         ` [PATCH v4] " Rainer Hochecker
2017-01-04 13:50           ` Rainer Hochecker
2017-01-04 18:04           ` Eric Engestrom
2017-01-04 18:04             ` Eric Engestrom
2017-01-04 18:24             ` [PATCH v5] " Rainer Hochecker
2017-01-04 18:24               ` Rainer Hochecker
2017-01-04 18:28               ` Ville Syrjälä
2017-01-04 18:28                 ` Ville Syrjälä
2017-01-04 18:38                 ` [PATCH v6] " Rainer Hochecker
2017-01-04 18:38                   ` Rainer Hochecker
2017-01-05 11:37                   ` Ville Syrjälä
2017-01-05 11:37                     ` Ville Syrjälä
2017-01-05 13:45                     ` Christian König
2017-01-05 13:45                       ` Christian König
2017-01-11 15:05                       ` Ville Syrjälä
2017-01-11 15:05                         ` Ville Syrjälä
2017-01-11 15:44                         ` Ben Widawsky
2017-01-11 15:44                           ` Ben Widawsky
2017-01-11 16:41                           ` Ville Syrjälä
2017-01-04 18:53         ` ✗ Fi.CI.BAT: failure for drm: add fourcc codes for 16bit R and RG (rev2) Patchwork
2017-01-04 19:15         ` ✓ Fi.CI.BAT: success for drm: add fourcc codes for 16bit R and RG (rev3) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y3yrgpoe.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=Eric.Engestrom@imgtec.com \
    --cc=ben@bwidawsk.net \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fernetmenta@kodi.tv \
    --cc=fernetmenta@online.de \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.