All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>,
	stable@vger.kernel.org, Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH] drm/i915: disable PSR by default on HSW/BDW
Date: Wed, 14 Dec 2016 13:58:52 +0200	[thread overview]
Message-ID: <87y3zirabn.fsf@intel.com> (raw)
In-Reply-To: <1481662664-18986-1-git-send-email-paulo.r.zanoni@intel.com>

On Tue, 13 Dec 2016, Paulo Zanoni <paulo.r.zanoni@intel.com> wrote:
> We've been ignoring the poor bugzilla reporters that say PSR causes
> system lockups and all other sorts of problems. The earliest bug
> report is from April, so I think we can use the "revert the offending
> commit if no fixes are presented within 8 months" rule here.

Ugh. Should be more like 2 weeks or so. We suck. :(

Acked-by: Jani Nikula <jani.nikula@intel.com>

PS. You're using a version of git that screws up # comments at the end
of Cc: lines, so I presume this didn't make it to stable list. It's
enough to have the Cc: in the commit when it gets applied though.

>
> Fixes: 9b58e352b463 ("drm/i915: Enable PSR by default on Haswell and Broadwell.")
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97602
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97515
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96736
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96704
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96569
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=95176
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94985
> Cc: <stable@vger.kernel.org> # v4.6+
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Jim Bride <jim.bride@linux.intel.com>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_psr.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c
> index d5f8d03..6aca8ff 100644
> --- a/drivers/gpu/drm/i915/intel_psr.c
> +++ b/drivers/gpu/drm/i915/intel_psr.c
> @@ -823,13 +823,9 @@ void intel_psr_init(struct drm_i915_private *dev_priv)
>  	dev_priv->psr_mmio_base = IS_HASWELL(dev_priv) ?
>  		HSW_EDP_PSR_BASE : BDW_EDP_PSR_BASE;
>  
> -	/* Per platform default */
> -	if (i915.enable_psr == -1) {
> -		if (IS_HASWELL(dev_priv) || IS_BROADWELL(dev_priv))
> -			i915.enable_psr = 1;
> -		else
> -			i915.enable_psr = 0;
> -	}
> +	/* Per platform default: all disabled. */
> +	if (i915.enable_psr == -1)
> +		i915.enable_psr = 0;
>  
>  	/* Set link_standby x link_off defaults */
>  	if (IS_HASWELL(dev_priv) || IS_BROADWELL(dev_priv))

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Paulo Zanoni <paulo.r.zanoni@intel.com>, intel-gfx@lists.freedesktop.org
Cc: stable@vger.kernel.org, Paulo Zanoni <paulo.r.zanoni@intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: disable PSR by default on HSW/BDW
Date: Wed, 14 Dec 2016 13:58:52 +0200	[thread overview]
Message-ID: <87y3zirabn.fsf@intel.com> (raw)
In-Reply-To: <1481662664-18986-1-git-send-email-paulo.r.zanoni@intel.com>

On Tue, 13 Dec 2016, Paulo Zanoni <paulo.r.zanoni@intel.com> wrote:
> We've been ignoring the poor bugzilla reporters that say PSR causes
> system lockups and all other sorts of problems. The earliest bug
> report is from April, so I think we can use the "revert the offending
> commit if no fixes are presented within 8 months" rule here.

Ugh. Should be more like 2 weeks or so. We suck. :(

Acked-by: Jani Nikula <jani.nikula@intel.com>

PS. You're using a version of git that screws up # comments at the end
of Cc: lines, so I presume this didn't make it to stable list. It's
enough to have the Cc: in the commit when it gets applied though.

>
> Fixes: 9b58e352b463 ("drm/i915: Enable PSR by default on Haswell and Broadwell.")
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97602
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97515
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96736
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96704
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96569
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=95176
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94985
> Cc: <stable@vger.kernel.org> # v4.6+
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Jim Bride <jim.bride@linux.intel.com>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_psr.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c
> index d5f8d03..6aca8ff 100644
> --- a/drivers/gpu/drm/i915/intel_psr.c
> +++ b/drivers/gpu/drm/i915/intel_psr.c
> @@ -823,13 +823,9 @@ void intel_psr_init(struct drm_i915_private *dev_priv)
>  	dev_priv->psr_mmio_base = IS_HASWELL(dev_priv) ?
>  		HSW_EDP_PSR_BASE : BDW_EDP_PSR_BASE;
>  
> -	/* Per platform default */
> -	if (i915.enable_psr == -1) {
> -		if (IS_HASWELL(dev_priv) || IS_BROADWELL(dev_priv))
> -			i915.enable_psr = 1;
> -		else
> -			i915.enable_psr = 0;
> -	}
> +	/* Per platform default: all disabled. */
> +	if (i915.enable_psr == -1)
> +		i915.enable_psr = 0;
>  
>  	/* Set link_standby x link_off defaults */
>  	if (IS_HASWELL(dev_priv) || IS_BROADWELL(dev_priv))

-- 
Jani Nikula, Intel Open Source Technology Center

  parent reply	other threads:[~2016-12-14 11:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-13 20:57 [PATCH] drm/i915: disable PSR by default on HSW/BDW Paulo Zanoni
2016-12-13 21:22 ` Vivi, Rodrigo
2016-12-14  8:00   ` Argotti, Yann
2016-12-14 10:29     ` Paulo Zanoni
2016-12-14 18:53     ` Vivi, Rodrigo
2016-12-14 18:55       ` Argotti, Yann
2016-12-14 20:24   ` Paulo Zanoni
2016-12-13 22:45 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-12-14 11:58 ` Jani Nikula [this message]
2016-12-14 11:58   ` [Intel-gfx] [PATCH] " Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y3zirabn.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=paulo.r.zanoni@intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.