All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Md Sadre Alam <md.alam@oss.qualcomm.com>
Cc: richard@nod.at,  vigneshr@ti.com,  tudor.ambarus@linaro.org,
	s-k6@ti.com,  linux-mtd@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	 varadarajan.narayanan@oss.qualcomm.com
Subject: Re: [PATCH 1/2] mtd: spinand: winbond: add support for W25N04LW
Date: Fri, 07 Aug 2026 15:52:12 +0200	[thread overview]
Message-ID: <87zeyyavhv.fsf@bootlin.com> (raw)
In-Reply-To: <20260807064339.1632249-2-md.alam@oss.qualcomm.com> (Md Sadre Alam's message of "Fri, 7 Aug 2026 12:13:38 +0530")

On 07/08/2026 at 12:13:38 +0530, Md Sadre Alam <md.alam@oss.qualcomm.com> wrote:

> Add support for Winbond W25N04LW 4Gbit SPI-NAND.
> It has 8-bit on-die ECC and a 4096+256 byte page
> (4096 byte main area, 128 byte usable OOB once
> on-chip ECC hides the 128 byte parity area),

That is not what you did below. Below you declare 254 free bytes.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Md Sadre Alam <md.alam@oss.qualcomm.com>
Cc: richard@nod.at,  vigneshr@ti.com,  tudor.ambarus@linaro.org,
	s-k6@ti.com,  linux-mtd@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	 varadarajan.narayanan@oss.qualcomm.com
Subject: Re: [PATCH 1/2] mtd: spinand: winbond: add support for W25N04LW
Date: Fri, 07 Aug 2026 15:52:12 +0200	[thread overview]
Message-ID: <87zeyyavhv.fsf@bootlin.com> (raw)
In-Reply-To: <20260807064339.1632249-2-md.alam@oss.qualcomm.com> (Md Sadre Alam's message of "Fri, 7 Aug 2026 12:13:38 +0530")

On 07/08/2026 at 12:13:38 +0530, Md Sadre Alam <md.alam@oss.qualcomm.com> wrote:

> Add support for Winbond W25N04LW 4Gbit SPI-NAND.
> It has 8-bit on-die ECC and a 4096+256 byte page
> (4096 byte main area, 128 byte usable OOB once
> on-chip ECC hides the 128 byte parity area),

That is not what you did below. Below you declare 254 free bytes.

Thanks,
Miquèl

  reply	other threads:[~2026-08-07 13:52 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-07  6:43 [PATCH 0/2] mtd: spinand: winbond: add support for additional SPI-NAND devices Md Sadre Alam
2026-08-07  6:43 ` Md Sadre Alam
2026-08-07  6:43 ` [PATCH 1/2] mtd: spinand: winbond: add support for W25N04LW Md Sadre Alam
2026-08-07  6:43   ` Md Sadre Alam
2026-08-07 13:52   ` Miquel Raynal [this message]
2026-08-07 13:52     ` Miquel Raynal
2026-08-10  8:28   ` Dominique MARTINET
2026-08-10  8:28     ` Dominique MARTINET
2026-08-10 12:43     ` Miquel Raynal
2026-08-10 12:43       ` Miquel Raynal
2026-08-11 12:48       ` Md Sadre Alam
2026-08-11 12:48         ` Md Sadre Alam
2026-08-11 12:40     ` Md Sadre Alam
2026-08-11 12:40       ` Md Sadre Alam
2026-08-07  6:43 ` [PATCH 2/2] mtd: spinand: winbond: add support for W25N01KW and W25N02LW Md Sadre Alam
2026-08-07  6:43   ` Md Sadre Alam
2026-08-07 13:50   ` Miquel Raynal
2026-08-07 13:50     ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zeyyavhv.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=md.alam@oss.qualcomm.com \
    --cc=richard@nod.at \
    --cc=s-k6@ti.com \
    --cc=tudor.ambarus@linaro.org \
    --cc=varadarajan.narayanan@oss.qualcomm.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.